From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12175 invoked by alias); 23 May 2011 15:24:44 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 29348 Received: (qmail 23180 invoked from network); 23 May 2011 15:24:42 -0000 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 Received-SPF: pass (ns1.primenet.com.au: SPF record at _spf.google.com designates 209.85.220.171 as permitted sender) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=Q/4w2t4ZJmRw0pkJzTiWYoNZbvYx9SXT/iXDZAG1hoo=; b=oCV0/JsbLD2JX40mN1+14cAxAQ7KwIzoVjgqa3sscXp4SifsAtIFUu5LOowaPUd8Er 5F66uIHDEym5F5gk/TdMTNvZAifG4Cgw0SfjkkfuhhNMzCP2oJKURtM7bYgjpUWk+Iwf I47rM6I0OEO25UT45+RpU+KrpiiO54PLAK9Pg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=TW73wBFTZuMT6P254jfULPcfjQBsHEk0N8SPgXmFQsW3MrjWCl02l+Qrjd3LlZ8qM0 gmgbj8Em6Fvdz2hECqorVBrpb3t/Y6qtZgbFekJOnECgnvWKGe5y2mcpqPsvlViirAIF Bc990AT8Ul5jzVaAUq11DgOJ6KwNNpDT4vmgE= MIME-Version: 1.0 In-Reply-To: <20110523161035.747f484d@pwslap01u.europe.root.pri> References: <20110523161035.747f484d@pwslap01u.europe.root.pri> Date: Mon, 23 May 2011 17:24:36 +0200 Message-ID: Subject: Re: Test failure with negative substring offsets From: Mikael Magnusson To: Peter Stephenson Cc: "Zsh Hackers' List" Content-Type: text/plain; charset=UTF-8 On 23 May 2011 17:10, Peter Stephenson wrote: > This is now failing: > > ./D04parameter.ztst: starting. > *** /tmp/zsh.ztst.err.18663 Mon May 23 15:58:07 2011 > --- /tmp/zsh.ztst.terr.18663 Mon May 23 15:58:07 2011 > *************** > *** 1 **** > ! (eval):2: substring expression: 3 < 5 > --- 1 ---- > ! (eval):2: substring expression: 3 < 0 > Test ./D04parameter.ztst failed: error output differs from expected as shown above for: > foo="123456789" > print ${foo:5:-6} > Was testing: Regression test for total length < 0 in string > ./D04parameter.ztst: test failed. > ************************************** > 0 successful test scripts, 1 failure, 0 skipped > ************************************** > make: *** [check] Error 1 > > I'll wait for it to stop failing. I'm guessing this is to do with > 29224. Odd, ./D04parameter.ztst: starting. ./D04parameter.ztst: all tests successful. ************************************** 1 successful test script, 0 failures, 0 skipped ************************************** > I think possibly the error could be clearer. It's not really clear what 3 > being less than 5 has got to do with the problem, i.e. that counting > 6 back from the end puts you before the start offset. bash does this, bash: -6: substring expression < 0 I guess we could be more explicit and say something like "substring expression error: end offset before start offset" or something? -- Mikael Magnusson