From: Felipe Contreras <felipe.contreras@gmail.com>
To: Frank Terbeck <ft@bewatermyfriend.org>
Cc: Nikolai Weibull <now@bitwi.se>,
Mikael Magnusson <mikachu@gmail.com>,
zsh-workers@zsh.org
Subject: Re: Slowness issue with git completion
Date: Wed, 27 Apr 2011 12:06:56 +0300 [thread overview]
Message-ID: <BANLkTikPKyFT5CZ0wxabDm4SMr4Vmn6TOg@mail.gmail.com> (raw)
In-Reply-To: <87sjt43wsg.fsf@ft.bewatermyfriend.org>
On Wed, Apr 27, 2011 at 11:47 AM, Frank Terbeck <ft@bewatermyfriend.org> wrote:
> Felipe Contreras wrote:
>> On Wed, Apr 27, 2011 at 9:11 AM, Nikolai Weibull <now@bitwi.se> wrote:
>>>> Are you interested in fixing this use-case even if it means to make
>>>> some compromises in correctness or not?
>>>
>>> No, I’m not.
>>
>> I am not used to zsh development, so is Nikolai's opinion shared by
>> the rest? Even if I provide a fix that make things slightly less
>> correct but usable, you wouldn't take the patch?
>
> I for one, am very fond of the way completion is done (albeit, not its
> performance in huge repositories). It actually *saves* me a whole lot
> of time, because - for example - "git add" only completes file names
> that actually *need* to be staged. So I would be firmly against
> throwing out Nikolai's hard work.
>
> As I was saying in another mail¹, I was also thinking about a scheme to
> give the user the option to choose smart (and slow) and utterly-dumb
> (and quick) file completion in various contexts via zstyle. A boolean
> style is very quick to look up and wouldn't impact performance. That
> way, each user could have it his/her way, fine tuned for all git
> sub-commands. That would be something everyone should be able to live
> with.
>
> Also, improving performance of the existing code would be highly
> appreciated.
I believe the only way to achieve good performance is to write new
helper commands in git.git. I could do that, but first I want the
completion to be fast _now_, and only when the "correct" completion
performs in a reasonable way, then enable it.
Since I'm not seeing a huge amount of reasonable responses (usability
is not important), I'm thinking there's really no point in trying to
improve the zsh completion and I should use the bash one instead.
--
Felipe Contreras
next prev parent reply other threads:[~2011-04-27 9:07 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-26 18:26 Felipe Contreras
2011-04-26 18:43 ` Frank Terbeck
2011-04-26 19:06 ` Nikolai Weibull
2011-04-26 20:10 ` Frank Terbeck
2011-04-26 20:23 ` Felipe Contreras
2011-04-26 20:34 ` Mikael Magnusson
2011-04-26 20:57 ` Felipe Contreras
2011-04-26 20:59 ` Mikael Magnusson
2011-04-26 21:10 ` Felipe Contreras
2011-04-26 21:13 ` Mikael Magnusson
2011-04-26 21:35 ` Felipe Contreras
2011-04-26 22:03 ` Nikolai Weibull
2011-04-26 22:25 ` Felipe Contreras
2011-04-26 23:14 ` Benjamin R. Haskell
2011-04-27 7:01 ` Benjamin R. Haskell
2011-04-27 1:52 ` gi1242+zsh
2011-04-27 6:11 ` Nikolai Weibull
2011-04-27 8:30 ` Felipe Contreras
2011-04-27 8:47 ` Frank Terbeck
2011-04-27 9:06 ` Felipe Contreras [this message]
2011-04-27 10:15 ` Nikolai Weibull
2011-04-27 10:42 ` Felipe Contreras
2011-04-27 11:14 ` Nikolai Weibull
2011-04-27 4:19 ` Bart Schaefer
2011-04-27 6:13 ` Nikolai Weibull
2011-04-27 12:51 ` Nikolai Weibull
2011-04-27 14:55 ` Bart Schaefer
2011-04-27 18:36 ` Nikolai Weibull
2011-04-30 14:37 ` Simon Ruderich
2011-04-30 15:00 ` Simon Ruderich
2011-05-02 9:59 ` Nikolai Weibull
2011-05-03 13:59 ` Nikolai Weibull
2011-04-26 21:52 ` Benjamin R. Haskell
2011-04-26 22:04 ` Felipe Contreras
2011-04-26 22:35 ` Benjamin R. Haskell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTikPKyFT5CZ0wxabDm4SMr4Vmn6TOg@mail.gmail.com \
--to=felipe.contreras@gmail.com \
--cc=ft@bewatermyfriend.org \
--cc=mikachu@gmail.com \
--cc=now@bitwi.se \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).