zsh-workers
 help / color / mirror / code / Atom feed
From: Mikael Magnusson <mikachu@gmail.com>
To: Bart Schaefer <schaefer@brasslantern.com>
Cc: zsh workers <zsh-workers@zsh.org>
Subject: Re: _make doesn't work in dirs with spaces
Date: Tue, 24 May 2011 03:36:59 +0200	[thread overview]
Message-ID: <BANLkTikky8dzzE9U_JOjyq__aU1JeCw3cw@mail.gmail.com> (raw)
In-Reply-To: <110522181051.ZM7938@torch.brasslantern.com>

On 23 May 2011 03:10, Bart Schaefer <schaefer@brasslantern.com> wrote:
> On May 21,  8:03pm, Mikael Magnusson wrote:
> }
> } There's some (q) in there that maybe shouldn't be. Removing the one on
> } line 176 fixes completing in a directory with spaces, but I'm unsure
> } of the intention of it, and the others in the file.
>
> The one on line 176 just looks wrong and should probably be removed.

Okay, I'll remove this one.

> For those on lines 163 an 166, I wonder if they should be (D) ?

Doing that just made completing make -I/-f <tab> start in / instead of
the current dir. I can't make those two work for any combination of
none, (q) and (D) when the path has spaces, but regular completion
does get fixed by removing the one on 176. Maybe some additional
combination with (Q) is needed on the lines that use $~, but at this
point I'm just guessing.

I also just realized that the completer doesn't complete -options at
all, and it redefines the helper functions every time it's invoked.

-- 
Mikael Magnusson


  reply	other threads:[~2011-05-24  1:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-21 18:03 Mikael Magnusson
2011-05-23  1:10 ` Bart Schaefer
2011-05-24  1:36   ` Mikael Magnusson [this message]
2011-05-24  1:38     ` PATCH: _make: put body in _make() and don't redefine helpers every time Mikael Magnusson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BANLkTikky8dzzE9U_JOjyq__aU1JeCw3cw@mail.gmail.com \
    --to=mikachu@gmail.com \
    --cc=schaefer@brasslantern.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).