From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12550 invoked by alias); 24 May 2011 01:37:09 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 29364 Received: (qmail 27832 invoked from network); 24 May 2011 01:37:05 -0000 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 Received-SPF: pass (ns1.primenet.com.au: SPF record at _spf.google.com designates 209.85.220.171 as permitted sender) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=aO1XVO5KjKnMTv+RkJcTsWo7ROWFe+r2qTgqswK9PHQ=; b=xPWC+J5XoieXbGxL7dlJ4oDOJ63XfGQ9tK9lmOrFK7OLeyooZKsZ4KAt6jwNSHGlSP YU3CFxWX3mvH33CrSNaQLp39cr4tNG1x1J9x3z/H+sb3fEPwBG40ePk2+psB7SV7VAP5 W/wuLNQ3DifpLZaCYOyDc4AlS4+bu7dbuSgPc= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=tW/ScN6dhvPfqe6S09aXHGY46qOqyoRnhYK4xdsx+kSTrmLcPlXUpRrTmG+inIoi2B 9GXGEA0vA/aXf2XW/AC7F7frGCV25qXjATt632XQsmMjT5a3Jm0GBCDQvCTb+ncJUwA4 J7PSC3WVmAtmQPflrxI644C6Vtf1Rbh9ysb+0= MIME-Version: 1.0 In-Reply-To: <110522181051.ZM7938@torch.brasslantern.com> References: <110522181051.ZM7938@torch.brasslantern.com> Date: Tue, 24 May 2011 03:36:59 +0200 Message-ID: Subject: Re: _make doesn't work in dirs with spaces From: Mikael Magnusson To: Bart Schaefer Cc: zsh workers Content-Type: text/plain; charset=UTF-8 On 23 May 2011 03:10, Bart Schaefer wrote: > On May 21, 8:03pm, Mikael Magnusson wrote: > } > } There's some (q) in there that maybe shouldn't be. Removing the one on > } line 176 fixes completing in a directory with spaces, but I'm unsure > } of the intention of it, and the others in the file. > > The one on line 176 just looks wrong and should probably be removed. Okay, I'll remove this one. > For those on lines 163 an 166, I wonder if they should be (D) ? Doing that just made completing make -I/-f start in / instead of the current dir. I can't make those two work for any combination of none, (q) and (D) when the path has spaces, but regular completion does get fixed by removing the one on 176. Maybe some additional combination with (Q) is needed on the lines that use $~, but at this point I'm just guessing. I also just realized that the completer doesn't complete -options at all, and it redefines the helper functions every time it's invoked. -- Mikael Magnusson