From: Felipe Contreras <felipe.contreras@gmail.com>
To: Bart Schaefer <schaefer@brasslantern.com>
Cc: zsh-workers@zsh.org
Subject: Re: When can we make a compromise in Git completion?
Date: Fri, 6 May 2011 02:01:20 +0300 [thread overview]
Message-ID: <BANLkTikwkoxA=2bug4VY_4nPdZnRJnmopQ@mail.gmail.com> (raw)
In-Reply-To: <110505153721.ZM20011@torch.brasslantern.com>
On Fri, May 6, 2011 at 1:37 AM, Bart Schaefer <schaefer@brasslantern.com> wrote:
> On May 6, 1:07am, Felipe Contreras wrote:
> } Subject: When can we make a compromise in Git completion?
> }
> } Actually I saw that mail by looking at the archives, but I didn't
> } notice the patch. I have tried the patch, it's still *dead slow* for
> } me. Again, I don't think this can be solved without writing new git
> } plumbing. You need to avoid 'git ls-files'.
>
> With the patch, however, it's possible for you to plug in your own
> different plumbing using zstyle.
>
> zstyle ':completion::complete:git:*:files' command ...
>
> where you put your alternate plumbing in where I have "...".
I don't think it would be that easy.
> Then when you have something that works as fast/accurately as you care
> about, you can let us know.
>
> If that's not good enough you can rewrite __git_files (or any of the
> other functions in the _git file) from scratch; there's a reason that
> the source file tests (( $+functions[__git_files] )) || ... before
> each function is defined: so that you can override them simply by
> defining your own flavor before _git is autoloaded.
I believe every __git_.*_files has to be changed. So again, not that easy.
Why would I even try if the result of this work is going to the trash?
First you tell me you would consider it for merging, then I will try
it, no point otherwise.
> } So. At which point are you going to be willing to accept the fact that
> } it's not possible to fix the performance without making a compromise?
>
> Roughly at the time you stop taking such an antagonistic stance about
> it, I suspect. Really, you're not doing your efforts any favors by
> framing the discussion the way you do.
This has nothing to do with feelings, it's a technical issue. Either
you are willing to make a compromise or not.
You pointed to other mailing list customs earlier, well, on the linux
kernel mailing list politeness is not a requisite, code is: "talk is
cheap, show me the code". But what I hear you saying is; "we don't
want that code".
It is a simple question, why can't you give a straight answer?
--
Felipe Contreras
next prev parent reply other threads:[~2011-05-05 23:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-05 22:07 Felipe Contreras
2011-05-05 22:37 ` Bart Schaefer
2011-05-05 23:01 ` Felipe Contreras [this message]
2011-05-05 23:38 ` Clint Adams
2011-05-06 0:05 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTikwkoxA=2bug4VY_4nPdZnRJnmopQ@mail.gmail.com' \
--to=felipe.contreras@gmail.com \
--cc=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).