From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-29330-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 6934 invoked by alias); 19 May 2011 18:49:12 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 29330
Received: (qmail 11953 invoked from network); 19 May 2011 18:48:58 -0000
X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1
Received-SPF: none (ns1.primenet.com.au: domain at thedavisons.net does not designate permitted sender hosts)
DomainKey-Signature: a=rsa-sha1; c=nofws; d=thedavisons.net; h=mime-version
	:in-reply-to:references:date:message-id:subject:from:to:cc:
	content-type; q=dns; s=thedavisons.net; b=twdV2S2IKVrnEJy353QKzo
	r75RzhZTDOTrnJ1FWKzFBQUdQm8Ji5fpwG80FZlALAfeKZp1qk94j08T2aKmx/Ic
	6i//nW6GHULMSGB7cq/9UA0SiQwYT78hpzQWlxVEr3GDhlK2dZc43vDgjEmH21bM
	XHHqKzx5srxnBniLu3emM=
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=thedavisons.net; h=
	mime-version:in-reply-to:references:date:message-id:subject:from
	:to:cc:content-type; s=thedavisons.net; bh=cxGSpLNGWzwQpD48lTRR/
	iBofPA=; b=w2/M0nTfOF20o+GimAx+fE3RXyrikcS2Pl7LNNayIOg3rBzek5Qq0
	hGkAxGGL4B6gC9Q6btKslKlRt9jYkeVSQ+QMiOQg1HCNp1QF7rioWm4fuBX9Pkf+
	aPGX3N4Ilr9jKog/qg8qy6UKBj/tzYdwHIbKwxFATol6QtWW3XqhYE=
MIME-Version: 1.0
In-Reply-To: <BANLkTimYMvT66AxwxsEudskNO5zEzk=gSg@mail.gmail.com>
References: <20110519140215.2879aeeb@pwslap01u.europe.root.pri>
	<BANLkTimMFRvw6a6wxPxA656KJ+_oommMLA@mail.gmail.com>
	<BANLkTinen5KwzxSoPtVd9=TG9AATvZFYkw@mail.gmail.com>
	<BANLkTimYMvT66AxwxsEudskNO5zEzk=gSg@mail.gmail.com>
Date: Thu, 19 May 2011 11:17:21 -0700
Message-ID: <BANLkTikyyCFP0muGMZ5NzkThJrWDPqSsPA@mail.gmail.com>
Subject: Re: Next zsh release
From: Wayne Davison <wayne@thedavisons.net>
To: Mikael Magnusson <mikachu@gmail.com>
Cc: Bart Schaefer <schaefer@brasslantern.com>,
	Peter Stephenson <Peter.Stephenson@csr.com>,
	"Zsh Hackers' List" <zsh-workers@zsh.org>
Content-Type: text/plain; charset=UTF-8

On Thu, May 19, 2011 at 10:53 AM, Mikael Magnusson <mikachu@gmail.com> wrote:
> Hm, in this line,
> push(setmathvar(mvp,c), mvp->lval, 0);
> isn't it undefined whether setmathvar runs first or mvp->lval is evaluated?

Yeah, it is.  That should probably be changed to this, just for safety's sake:

            c = setmathvar(mvp, c);
            push(c, mvp->lval, 0);

..wayne..