Failure in A01grammar.ztst and C02cond.ztst

Failure in A01grammar.ztst and C02cond.ztst

[İsmail Dönmez]

[-- Attachment #1: Type: text/plain, Size: 1736 bytes --]

I am testing 4.3.10-dev-2 release on a wide range of openSUSE & SUSE
releases (https://build.opensuse.org/package/show?package=zsh&project=shells)
and some machines seem to have problems with these two tests. Here is the
error outputs, any ideas appreciated.



./A01grammar.ztst: starting.
*** /tmp/zsh.ztst.err.13556     Wed Apr 20 14:47:09 2011
--- /tmp/zsh.ztst.terr.13556   Wed Apr 20 14:47:09 2011
***************
*** 1,2 ****
- 1) one     2) two     3) three
  input> input>
--- 1 ----
Test ./A01grammar.ztst failed: error output differs from expected as shown
above for:
  (COLUMNS=80
  PS3="input> "
  select name in one two three; do
    print $name
  done)
Was testing: `select' loop
./A01grammar.ztst: test failed.


Test ./C02cond.ztst failed: bad status 1, expected 0 from:
  print -u $ZTST_fd 'This test takes two seconds...'
  sleep 2
  cat unmodified
  touch newnewnew
  if [[ $OSTYPE == "cygwin" ]]; then
    print -u$ZTST_fd "Warning: not testing [[ -N file ]] (not supported on
Cygwin)"
    true
  elif [[ "$(find . -prune -fstype nfs 2>/dev/null)" == "." ]]; then
    print -u$ZTST_fd "Warning: not testing [[ -N file ]] (not supported with
NFS)"
    true
  else
    [[ -N newnewnew && ! -N unmodified ]]
  fi
Was testing: -N cond
./C02cond.ztst: test failed.
The following may (or may not) help identifying the cause:
  This test can fail on NFS-mounted filesystems as the access and
  modification times are not updated separately.  The test will fail
  on HFS+ (Apple Mac OS X default) filesystems because access times
  are not recorded.  Also, Linux ext3 filesystems may be mounted
  with the noatime option which does not update access times.
  Failures in these cases do not indicate a problem in the shell.

Re: Failure in A01grammar.ztst and C02cond.ztst

[İsmail Dönmez]

Hi again;

On Wed, Apr 20, 2011 at 4:55 PM, İsmail Dönmez <ismail@namtrac.org> wrote:
>
> I am testing 4.3.10-dev-2 release on a wide range of openSUSE & SUSE releases (https://build.opensuse.org/package/show?package=zsh&project=shells) and some machines seem to have problems with these two tests. Here is the error outputs, any ideas appreciated.
>
>
>
> ./A01grammar.ztst: starting.
> *** /tmp/zsh.ztst.err.13556     Wed Apr 20 14:47:09 2011
> --- /tmp/zsh.ztst.terr.13556   Wed Apr 20 14:47:09 2011
> ***************
> *** 1,2 ****
> - 1) one     2) two     3) three
>   input> input>
> --- 1 ----
> Test ./A01grammar.ztst failed: error output differs from expected as shown above for:
>   (COLUMNS=80
>   PS3="input> "
>   select name in one two three; do
>     print $name
>   done)
> Was testing: `select' loop
> ./A01grammar.ztst: test failed.

This test only fails only on 32bit machines it seems and works on all
64bit machines I tested.

Regards.

Re: Failure in A01grammar.ztst and C02cond.ztst

[İsmail Dönmez]

[-- Attachment #1: Type: text/plain, Size: 1385 bytes --]

Hi again;

On Thu, Apr 21, 2011 at 9:44 AM, İsmail Dönmez <ismail@namtrac.org> wrote:

> Hi again;
>
> On Wed, Apr 20, 2011 at 4:55 PM, İsmail Dönmez <ismail@namtrac.org> wrote:
> >
> > I am testing 4.3.10-dev-2 release on a wide range of openSUSE & SUSE
> releases (
> https://build.opensuse.org/package/show?package=zsh&project=shells) and
> some machines seem to have problems with these two tests. Here is the error
> outputs, any ideas appreciated.
> >
> >
> >
> > ./A01grammar.ztst: starting.
> > *** /tmp/zsh.ztst.err.13556     Wed Apr 20 14:47:09 2011
> > --- /tmp/zsh.ztst.terr.13556   Wed Apr 20 14:47:09 2011
> > ***************
> > *** 1,2 ****
> > - 1) one     2) two     3) three
> >   input> input>
> > --- 1 ----
> > Test ./A01grammar.ztst failed: error output differs from expected as
> shown above for:
> >   (COLUMNS=80
> >   PS3="input> "
> >   select name in one two three; do
> >     print $name
> >   done)
> > Was testing: `select' loop
> > ./A01grammar.ztst: test failed.
>
> This test only fails only on 32bit machines it seems and works on all
> 64bit machines I tested.
>

Also note that Fedora disables this part of the test:

http://pkgs.fedoraproject.org/gitweb/?p=zsh.git;a=blob_plain;f=zsh-4.3.6-hack-a01grammar-test-select-off.patch;hb=HEAD

So there is possibly some race somewhere?

Regards,
ismail

Re: Failure in A01grammar.ztst and C02cond.ztst

[Bart Schaefer]

On Thu, Apr 21, 2011 at 5:21 AM, İsmail Dönmez <ismail@namtrac.org> wrote:
>
> Also note that Fedora disables this part of the test:
>
> http://pkgs.fedoraproject.org/gitweb/?p=zsh.git;a=blob_plain;f=zsh-4.3.6-hack-a01grammar-test-select-off.patch;hb=HEAD
>
> So there is possibly some race somewhere?

It seems unlikely.  Both the selection list and the prompt are
fprintf'd to stderr.

The only thing I can come up with is that during the test if LINES=0
then the list might not be printed.  The test explicitly assigns
COLUMNS=80 but doesn't change LINES ... try adding LINES=3 ...?

Re: Failure in A01grammar.ztst and C02cond.ztst

[İsmail Dönmez]

[-- Attachment #1: Type: text/plain, Size: 851 bytes --]

Hi;

On Thu, Apr 21, 2011 at 7:09 PM, Bart Schaefer <schaefer@brasslantern.com>wrote:

> On Thu, Apr 21, 2011 at 5:21 AM, İsmail Dönmez <ismail@namtrac.org> wrote:
> >
> > Also note that Fedora disables this part of the test:
> >
> >
> http://pkgs.fedoraproject.org/gitweb/?p=zsh.git;a=blob_plain;f=zsh-4.3.6-hack-a01grammar-test-select-off.patch;hb=HEAD
> >
> > So there is possibly some race somewhere?
>
> It seems unlikely.  Both the selection list and the prompt are
> fprintf'd to stderr.
>
> The only thing I can come up with is that during the test if LINES=0
> then the list might not be printed.  The test explicitly assigns
> COLUMNS=80 but doesn't change LINES ... try adding LINES=3 ...?
>

Yes, adding LINES=3 fixes the problem. Thanks! :) No idea why C02cond.ztst
fails but it looks random.

Regards,
ismail