From: Mikael Magnusson <mikachu@gmail.com>
To: Jon Mayo <jon.mayo@gmail.com>
Cc: zsh workers <zsh-workers@zsh.org>
Subject: Re: SIGFPE crash
Date: Sun, 8 May 2011 00:17:23 +0200 [thread overview]
Message-ID: <BANLkTimCMEy1_EPe00dX7yhi-9EqDzKaMA@mail.gmail.com> (raw)
In-Reply-To: <BANLkTi=x2Cn3dZFGaEdVUm9+4mAse+dQsQ@mail.gmail.com>
On 7 May 2011 23:56, Jon Mayo <jon.mayo@gmail.com> wrote:
> echo $[-9223372036854775808/-1]
>
> this causes zsh to exit immediately with an FPE. Does anyone have a
> patch to fix this?
diff --git a/Src/math.c b/Src/math.c
index 35b362d..3c08052 100644
--- a/Src/math.c
+++ b/Src/math.c
@@ -1053,8 +1053,12 @@ op(int what)
return;
if (c.type == MN_FLOAT)
c.u.d = a.u.d / b.u.d;
- else
- c.u.l = a.u.l / b.u.l;
+ else {
+ if (a.u.l == LONG_MIN && b.u.l == -1)
+ c.u.l = 0;
+ else
+ c.u.l = a.u.l / b.u.l;
+ }
break;
case MOD:
case MODEQ:
Do we want to print a warning and/or use another value than 0 in this case?
--
Mikael Magnusson
next prev parent reply other threads:[~2011-05-07 22:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-07 21:56 Jon Mayo
2011-05-07 22:17 ` Mikael Magnusson [this message]
2011-05-07 22:19 ` Jon Mayo
2011-05-07 22:27 ` Mikael Magnusson
2011-05-07 23:48 ` Phil Pennock
2011-05-08 0:05 ` Jon Mayo
2011-05-08 0:10 ` Mikael Magnusson
2011-05-08 2:46 ` Bart Schaefer
2011-05-08 7:03 ` Jon Mayo
2011-05-08 17:33 ` Peter Stephenson
2011-05-09 10:21 ` Vincent Lefevre
2011-05-09 10:35 ` Vincent Lefevre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTimCMEy1_EPe00dX7yhi-9EqDzKaMA@mail.gmail.com \
--to=mikachu@gmail.com \
--cc=jon.mayo@gmail.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).