From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20309 invoked by alias); 27 May 2011 04:57:55 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 29392 Received: (qmail 15605 invoked from network); 27 May 2011 04:57:52 -0000 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 Received-SPF: pass (ns1.primenet.com.au: SPF record at _spf.google.com designates 209.85.212.43 as permitted sender) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=bPU0Lcn6EoPlYTruswfqhelftImNVCZwR7ghTWWMU18=; b=xoguzqxcJEh3z5eto7rielbnsvTs8YHD4IQwwmSad+J503kC1JXsxhH4amWipYtRJf LUJ6S6Zxnw/OyAQHUJK8w8nXovgcLgB/pnh5hsd1XJhwTzEskus/9TnysxaZ/7pNq1u9 5g6ySvLMcsS5+U4vkL1UjE4iiRC3SL/hwxXZI= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=tzMG/H/XCIbXibGK9S5woyHCW+QhRoJq63AmEsZkvnjia8WcAeG24/ccVVcIJZ0R/o UbJ0UB0r0JUHcAICOD5Mpjj1+H1NSFonUlstJKLEy9So60pxxspZ9ik/d1si3r4a7Mer zjGXzcFY3xz3eMNkPPPdXXJBJp+hWHeYlu2Wc= MIME-Version: 1.0 In-Reply-To: <110526214110.ZM518@torch.brasslantern.com> References: <237967ef0902140622s7389d2c8h5a0c786dcf207422@mail.gmail.com> <200902141801.n1EI1E2l003603@pws-pc.ntlworld.com> <237967ef0902141019t30118690m30116c9413015d96@mail.gmail.com> <090214111316.ZM15188@torch.brasslantern.com> <237967ef0902141141y609b61d3i154546f6f6886c65@mail.gmail.com> <090214133904.ZM15383@torch.brasslantern.com> <20090216094632.30502fe9@news01> <237967ef0902160155m583e714fqe9bbd344420f1ce0@mail.gmail.com> <110526214110.ZM518@torch.brasslantern.com> Date: Fri, 27 May 2011 06:57:45 +0200 Message-ID: Subject: Re: Problem with fake-files style and cd From: Mikael Magnusson To: Bart Schaefer Cc: zsh-workers Content-Type: text/plain; charset=UTF-8 On 27 May 2011 06:41, Bart Schaefer wrote: > On May 27, 3:25am, Mikael Magnusson wrote: > } > } Been sitting on this patch for a while, is it okay to commit? > > I feel a little silly mentioning these nits, but stylistically, > > for names of directories DASH()- when the cdpath array is set, > > would fit the context better. There are no full-stops in any of > the other items in that list. Also, you have "is used" in one > entry and "will be used" in the other. (Prefer "is used".) How's this? item(tt(directories))( for names of directories DASH()- when the tt(cdpath) array is set, tt(local-directories) is used instead item(tt(local-directories))( for names of directories that are subdirectories of the current working directory when completing arguments of tt(cd) and related builtin commands (compare tt(path-directories)) DASH()- when the tt(cdpath) array is unset, tt(directories) is used instead > More substantively, remind me what "used instead" means here? The > word "used" is not specific enough, I guess. I'm not sure how this is unclear, but when cdpath is set, local-directories is looked up, when it is unset directories is looked up. So when cdpath is set, directories is used instead [of local-directories] and vice versa. "used instead" is used in a couple of other places in this file already too. That reminds me, one of the places that uses it is the entry for use-perl, which says that _make uses this style, but since the rewrite it does not. It is currently completely unused, should we remove this paragraph? Currently this is only used in completions for `make', but it may be extended depending on authorial frustration. -- Mikael Magnusson