Re: FW: Zsh 4.3.12 failure on OpenBSD

[Mikael Magnusson <mikachu@gmail.com>]

On 1 June 2011 12:04, Peter Stephenson <Peter.Stephenson@csr.com> wrote:
>
> ________________________________________
> From: Pierre-Emmanuel André [pea@raveland.org]
> Sent: 01 June 2011 10:46
> To: Peter Stephenson
> Subject: Zsh 4.3.12 failure on OpenBSD
>
> Hi Peter,
>
> Sorry for the late feedback.
> I tried zsh-4.3.11-dev-3 on OpenBSD and there was no pbs.
> I didn't try dev-4 (no time).
> I wanted to update the OpenBSD port but i have a pb with
> regress tests on OpenBSD @amd64.
>
> ./D04parameter.ztst: starting.
> *** /usr/ports/pobj/zsh-4.3.12/zsh-4.3.12/tmp.ztst.out.24079    Wed Jun  1 11:40:42 2011
> --- /usr/ports/pobj/zsh-4.3.12/zsh-4.3.12/tmp.ztst.tout.24079   Wed Jun  1 11:40:42 2011
> ***************
> *** 1,6 ****
>  eS
>  eS
>  e^X
> ! e^X\M-a
>  eS^X
> ! e S ^X\M-a
> --- 1,6 ----
>  eS
>  eS
>  e^X
> ! e^X�
>  eS^X
> ! e S ^X�
> Test ./D04parameter.ztst failed: output differs from expected as shown above for:
>  foo='\u65\123'
>  print -r ${(g:o:)foo}
>  foo='\u65\0123'
>  print -r ${(g::)foo}
>  foo='\u65^X'
>  print -r ${(V)${(g:c:)foo}}
>  foo='\u65\C-x\M-a'
>  print -r ${(V)${(g:e:)foo}}
>  foo='\u65\123\C-x'
>  print -r ${(V)${(g:eo:)foo}}
>  foo=('\u65' '\0123' '^X\M-a')
>  print -r ${(V)${(g:e:)foo}}
> Was testing: ${(g)...}
> ./D04parameter.ztst: test failed.

Okay, so in a latin1 locale, \M-a is á which is printable, so it isn't
converted back to \M-a by (V). I also noticed that in one of the
tests, the input has "^X" but not the c flag, but does use V, so the
test can't tell if it was converted or not, because it'll always come
out as ascii "^X". I guess there's not really much point in testing
\M-a, since I already test \C-x and it's handled by the same code. The
test is just for calling the function that does that properly, not
that that function actually works ;). I hope I can at least rely on
\C-x not being printable anywhere? Or is it okay to include a literal
^X in the expected test output? I'm not sure how else I can test that
^X is parsed properly.

-- 
Mikael Magnusson