From: Mikael Magnusson <mikachu@gmail.com>
To: Bart Schaefer <schaefer@brasslantern.com>
Cc: "Zsh Hackers' List" <zsh-workers@zsh.org>
Subject: Re: Test failure with negative substring offsets
Date: Mon, 23 May 2011 18:19:04 +0200 [thread overview]
Message-ID: <BANLkTimYGyg5Cf2v3yyvM_1iorRa53e6eQ@mail.gmail.com> (raw)
In-Reply-To: <110523091052.ZM10054@torch.brasslantern.com>
On 23 May 2011 18:10, Bart Schaefer <schaefer@brasslantern.com> wrote:
> On May 23, 4:56pm, Peter Stephenson wrote:
> }
> } stdarg doesn't know the arguments need to be converted to integers to
> } fit the size being claimed in the printf prototype.
This is a much better conclusion than mine.
> Er, wouldn't it therefore have been better to change the prototype to
> expect a long?
It doesn't expect a long, it expects a zlong, which can be a long or a
long long.
#ifdef ZSH_64_BIT_TYPE
typedef ZSH_64_BIT_TYPE zlong;
#ifdef ZSH_64_BIT_UTYPE
typedef ZSH_64_BIT_UTYPE zulong;
#else
typedef unsigned zlong zulong;
#endif
#else
typedef long zlong;
typedef unsigned long zulong;
#endif
But why does this code use zlong at all? 2^31 characters should be
long enough for everyone. (And things will probably fall over for
other reasons before that point, no?) But maybe the autoconf macro
could define a ZSH_PRINTF_SPECIFIER to %ld or %lld depending on what
zlong is?
--
Mikael Magnusson
next prev parent reply other threads:[~2011-05-23 16:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-23 15:10 Peter Stephenson
2011-05-23 15:24 ` Mikael Magnusson
2011-05-23 15:41 ` İsmail Dönmez
2011-05-23 15:52 ` Mikael Magnusson
2011-05-23 15:58 ` Bart Schaefer
2011-05-23 16:00 ` Mikael Magnusson
2011-05-23 15:56 ` Peter Stephenson
2011-05-23 16:08 ` Peter Stephenson
2011-05-23 16:10 ` Bart Schaefer
2011-05-23 16:16 ` Peter Stephenson
2011-05-23 16:19 ` Mikael Magnusson [this message]
2011-05-23 16:27 ` Peter Stephenson
2011-05-23 16:34 ` Mikael Magnusson
2011-05-23 16:40 ` Peter Stephenson
2011-05-23 16:52 ` Peter Stephenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTimYGyg5Cf2v3yyvM_1iorRa53e6eQ@mail.gmail.com \
--to=mikachu@gmail.com \
--cc=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).