From: Mikael Magnusson <mikachu@gmail.com>
To: Wayne Davison <wayned@users.sourceforge.net>
Cc: zsh workers <zsh-workers@zsh.org>
Subject: Re: PATCH: (rfc) HIST_FIND_DUPS option
Date: Tue, 10 May 2011 02:03:00 +0200 [thread overview]
Message-ID: <BANLkTimsaZNtZ_uqr+S-QzV2B8v7nGGanA@mail.gmail.com> (raw)
In-Reply-To: <BANLkTi=EypRYYfDn9JjBxhB5aHZWkf8VsA@mail.gmail.com>
On 10 May 2011 01:51, Wayne Davison <wayned@users.sourceforge.net> wrote:
> On Mon, May 9, 2011 at 3:09 PM, Mikael Magnusson <mikachu@gmail.com> wrote:
>>
>> I am currently unsure why unsetting HIST_FIND_NO_DUPS doesn't have this
>> behaviour already. Possibly it only finds the same line after finding
>> another line in between that also matches the search
>
> Exactly. Under normal circumstance, if the user has rejected a particular
> line as not being one that they want to run, showing them the same line
> isn't usually very useful to them (and may indeed be confusing).
Yeah, but why show it again if there was an intervening other line,
but not otherwise?
Ie with this history
: barfoo
: foobar
: ninja
: foobar
: barfoo
: foobar
searching for foo will give you line 6, 5 and 4, but not 2, then 1. I
just don't see the point of this distinction.
> I don't particularly like the HIST_FIND_DUPS option. If you named it
> HIST_FIND_ALL_DUPS I'd like it a bit better.
Yeah, the name is not set in stone :).
> But I do wonder if there isn't
> a better solution to help you solve this particular search idiom (one where
> you're really searching not just for a line, but for a set of lines). For
> instance, it would be interesting to be able to ask zsh to show a line or
> two of context following the line as you visit each matching line. In such
> a search, it would make a lot of sense to show the user another identical
> line that has differing context, so that would be the default.
This is already possible, and indeed how I have been using this feature.
http://www.zsh.org/mla/workers/2010/msg00720.html
Unfortunately I don't think I can do anything from this hook to affect
the dupness of results.
--
Mikael Magnusson
next prev parent reply other threads:[~2011-05-10 0:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-09 22:09 Mikael Magnusson
2011-05-09 23:51 ` Wayne Davison
2011-05-10 0:03 ` Mikael Magnusson [this message]
2011-05-10 5:08 ` Wayne Davison
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTimsaZNtZ_uqr+S-QzV2B8v7nGGanA@mail.gmail.com \
--to=mikachu@gmail.com \
--cc=wayned@users.sourceforge.net \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).