From: Jun T <takimoto-j@kba.biglobe.ne.jp>
To: zsh-workers@zsh.org
Subject: Re: [PATCH] completion libvirt: edit action is always allowed
Date: Tue, 22 Aug 2023 15:54:27 +0900 [thread overview]
Message-ID: <BC765FE2-FC3A-408D-98C2-B813F45CD5A9@kba.biglobe.ne.jp> (raw)
In-Reply-To: <d157bd27-fc7b-4edc-880b-fd7ebc20a708@outerface.net>
> 2023/08/21 19:13, sergio <sergio@outerface.net> wrote:
>
> Why this still has not been merged?
Sorry, I guess everyone here has thought that someone else
would take care of it.
> 2023/06/09 17:5, sergio <sergio@outerface.net> wrote:
>
> libvirt allows to edit virtrual host in any state
> - edit " "
> + edit --all
I'm not familiar with virsh, but if --all is the correct option
to use then we can just remove dom_opts[edit] since the array
is used as ${dom_opts[$cmd]:-"--all"}.
diff --git a/Completion/Unix/Command/_libvirt b/Completion/Unix/Command/_libvirt
index a3ab5a68a..bd605b9c9 100644
--- a/Completion/Unix/Command/_libvirt
+++ b/Completion/Unix/Command/_libvirt
@@ -20,7 +20,6 @@ typeset -A dom_opts
dom_opts=(
console " "
destroy " "
- edit " "
managedsave " "
reboot " "
reset " "
next prev parent reply other threads:[~2023-08-22 6:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-09 8:59 sergio
2023-08-21 10:13 ` sergio
2023-08-22 6:54 ` Jun T [this message]
2023-08-23 21:01 ` sergio
2023-08-24 1:56 ` Jun. T
2023-08-24 11:10 ` sergio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BC765FE2-FC3A-408D-98C2-B813F45CD5A9@kba.biglobe.ne.jp \
--to=takimoto-j@kba.biglobe.ne.jp \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).