From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-33829-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 27874 invoked by alias); 1 Dec 2014 10:58:49 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 33829
Received: (qmail 2471 invoked from network); 1 Dec 2014 10:58:47 -0000
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE
	autolearn=ham version=3.3.2
X-Biglobe-Sender: <takimoto-j@kba.biglobe.ne.jp>
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 6.6 \(1510\))
Subject: Re: Confirming X02zlevi test failures
From: "Jun T." <takimoto-j@kba.biglobe.ne.jp>
In-Reply-To: <1339.1417097466@thecus.kiddle.eu>
Date: Mon, 1 Dec 2014 19:58:42 +0900
Content-Transfer-Encoding: 7bit
Message-Id: <BE3892EC-3CDD-4CE2-A4D6-30023376DDD0@kba.biglobe.ne.jp>
References: <141119085006.ZM18951@torch.brasslantern.com> <11014.1416438322@quattro> <141119222019.ZM2717@torch.brasslantern.com> <5A1A98B7-42E0-4EE1-9468-32E2D6434246@kba.biglobe.ne.jp> <141120091803.ZM3693@torch.brasslantern.com> <E7064DEC-9EF9-43DB-9B9B-3C9CDD7A93A9@kba.biglobe.ne.jp> <900E2DDB-B03E-4E1F-9F22-869D5A645E52@kba.biglobe.ne.jp> <CAH+w=7Z-oSfHsPK4DJjbTpk-kOid-YA76uWwYMsZLN1fqb1Y=w@mail.gmail.com> <C097A9C2-C61C-482C-BEDA-94736DE7C5DB@kba.biglobe.ne.jp> <30162.1417013479@thecus.kiddle.eu> <20141126154544.58ed6010@pwslap01u.europe.root.pri> <141126083746.ZM23932@torch.brasslantern.com> <1339.1417097466@thecus.kiddle.eu>
To: "zsh-workers@zsh.org" <zsh-workers@zsh.org>
X-Mailer: Apple Mail (2.1510)
X-Biglobe-Spnum: 58183

It seems fixing the zpty problem in BSD/Darwin is not easy.

If we must resort to a (hopefully temporary) workaround, 
I think 'bindkey -r "\e~"' is better than zpty_flush()
because the latter seems to be not 100% reliable.

In the patch below, instead of putting 'bindkey -r "\e~"'
in comptest, it is called just before the failing test in
X02zlevi, in order to minimize the interference with other
tests which are also using comptest.

Jun


diff --git a/Test/X02zlevi.ztst b/Test/X02zlevi.ztst
index 8f93902..0c346a4 100644
--- a/Test/X02zlevi.ztst
+++ b/Test/X02zlevi.ztst
@@ -37,6 +37,7 @@
 >3
 >CURSOR: 5
 
+  zpty_run 'bindkey -r "\e~"'
   zletest $'\e' $'~aI\e' $'~o\e' \~
 0:swap case on a blank line
 >BUFFER: i
diff --git a/Test/comptest b/Test/comptest
index 1f4dac6..9c92f96 100644
--- a/Test/comptest
+++ b/Test/comptest
@@ -162,7 +162,7 @@ comptest () {
 zletest () {
   local first=0
   for input; do
-    zpty_flush Before zletest
+    # zpty_flush Before zletest
     # sleep for $KEYTIMEOUT
     (( first++ )) && read -t 0.011 -k 1 < /dev/null
     zpty -n -w zsh "$input"