From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 13071 invoked from network); 11 Sep 2023 07:28:52 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 11 Sep 2023 07:28:52 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1694417332; b=men0uUXkwtigF0nni4EPxHa1pDY0WgBOKQMWy+iUVkKqsG8LfWGwSGxVqNWyb40DDOVwP4f7KW TakiaKsVrD+url42NgqfPmEpUDOqMGXAVqAFoXK1DxfcozxrrLUniFRGv3QhoWnsvH5dT2G/Y6 4X6N2yon9opJxyhNsoJddRyg/mHmaWR93iy11qTNCedDpgBRVgdDfdGsV1f7WQFD70WX7iSpBo jUKbxYPiQeVi6KBW142NBeOJmzih97o96V96xtOepTQfMBX3x4NqOyQ+mxu50ImCWZAqZ0x6sJ rOnPW60ELFF9w//6nmC/qun/MMDPbBoYTJHZFgO+z7sZVg==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (snd00013-bg.im.kddi.ne.jp) smtp.remote-ip=27.86.113.13; dmarc=none header.from=kba.biglobe.ne.jp; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1694417332; bh=OWJ1avpuQ3/Yyr83GizUFsnSISt75pv0iDT+iRzxO/4=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Message-ID:In-Reply-To:To:References:Date:Subject: MIME-Version:Content-Transfer-Encoding:Content-Type:From:DKIM-Signature; b=hwf4jsD8mvv80cTuwEQARbeQMNWyqBjRmslgrRkeGr/hpCV9jJBms4GhK5KnDrOM2YRfkvIu0t gMD0GfPluU3hOp4dOz+9R5jSQiO3kQIiwRmJRl8DB+M/NaHFJy8gcWvtJO04NpjaKCOZu85vC3 B00KDt6Zjdm5jA1VjwPN9GyhacHxHRydusG3UGC/C5ELSsNn0GZn9z2QX5etU9mINvCilvQAr1 py/ZMvhJKPoWF7EqVDNB6OycX3bMzGYdWaEFDyisO47pTdshFewaZl02BRWfLRI/HIisQuycLs hKTACDC5S64eHxo4eLoJYqwY8kaubR0KsiUxTLWoszcC+A==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Message-Id:In-Reply-To:To:References: Date:Subject:Mime-Version:Content-Transfer-Encoding:Content-Type:From: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=87JadYqPgloASCH7df2vc6Nm2wP5g5BOnioWkw7VQ8o=; b=jiDDfyLqz5BRREVobW8hM2WTkL Rn1cNabkTgiGmcRfQXX3CvppEBZ4xMiSCctoXcK0+QANWHQdrSKlvM7apYc7d54bNc5Zvn3j+81J6 xI+ysbLfMp9wCwnMkN5E0AsE/RnQr3nonlyeR3PbGkjoEH1i1SCgQvtQyFENQFTstK1jtmyAfDnR3 GhzjWnowHX9xPfqmw2IdDbRnlOB0yPlKTER7iLdtTeCSTINsXE9zij4XJAV9MO8zog2P9nfysypFa ov0p2Xekh/L0WkUd4JZ8lTFfzSz71JvSRK8R5nu98VV7ncJOYaTFffeIQmOCM97G78LOP6o91Uf2U HGLxPGgQ==; Received: by zero.zsh.org with local id 1qfbLl-000DxO-Mg; Mon, 11 Sep 2023 07:28:49 +0000 Authentication-Results: zsh.org; iprev=pass (snd00013-bg.im.kddi.ne.jp) smtp.remote-ip=27.86.113.13; dmarc=none header.from=kba.biglobe.ne.jp; arc=none Received: from snd00013-bg.im.kddi.ne.jp ([27.86.113.13]:61025 helo=dfmta0003.biglobe.ne.jp) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_256_GCM_SHA384:256) id 1qfbLB-000DfO-58; Mon, 11 Sep 2023 07:28:16 +0000 Received: from mail.biglobe.ne.jp by omta0003.biglobe.ne.jp with ESMTP id <20230911072807161.VJYI.20034.mail.biglobe.ne.jp@biglobe.ne.jp> for ; Mon, 11 Sep 2023 16:28:07 +0900 From: Jun T Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.21\)) Subject: Re: Should we "fix" this declaration? Date: Mon, 11 Sep 2023 16:28:06 +0900 References: To: zsh-workers@zsh.org In-Reply-To: Message-Id: X-Mailer: Apple Mail (2.3445.104.21) X-Biglobe-Sender: takimoto-j@kba.biglobe.ne.jp X-Seq: 52127 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: , List-Subscribe: , List-Unsubscribe: , List-Post: List-Owner: List-Archive: > 2023/09/11 7:00, Bart Schaefer wrote: > > have_edits = 0; > Histent he; > > That's from users/29175, but we've previously followed the old C > format that declarations have to be at the start of a block. I personally think we don't need to "fix" this. The current zsh source already uses 'inline' function (new in C99, I think) in hashtable.c. This is added by commit 6f6363d (Jul. 28, 2020). If I try to build zsh on macOS (Apple clang 10.0) with CFLAGS='-std=c89' then it first fails due to this inline function (may also fail on other files). On Ubuntu 22.04 (gcc-11.4) CFLAGS='-std=c89' seems to give lots more errors. I have no idea what kind of old compilers are still in use, but even if they are not 100% compatible with C99 (especially some library functions), I think they support '// comment' and 'mixed declarations and code'.