From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,FORGED_HOTMAIL_RCVD2, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=3.4.4 Received: from zero.zsh.org (zero.zsh.org [IPv6:2a02:898:31:0:48:4558:7a:7368]) by inbox.vuxu.org (Postfix) with ESMTP id CA40D22508 for ; Sat, 20 Jul 2024 09:56:34 +0200 (CEST) ARC-Seal: i=2; cv=pass; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1721462194; b=GBgavBTmUWC/4bNWUJBy61bJmYzNgCfvqhj7QXmo5TaefgFVPOO0sEXFeL/GCta8Y9qYOSQj+h WeneQ8uCtuUsSkklq9Rmd+d2Ng/MnBPAdzPY+yxSh3u31odZAROPhDKDZKd+rsAa7V89+Uxbus Cb7+nRyB6AaW5pOqUiInwhQA+Oxz3uTRab4TYkbBDQrydWbI1lIKb0raeiuixBX+kAOHwbUkh5 harYCZutCLSYIwjtxYHG5e8qU9haB9vYImQatZnuXZFwahaX1mEgcTahrFIhZG6bNt0pLQSwEr AEBNsHbbKx701h2YcH8Pi4fwBXJaoJrXVGLzN+UT3VRTlw==; ARC-Authentication-Results: i=2; zsh.org; iprev=pass (mail-sn1nam02olkn2020.outbound.protection.outlook.com) smtp.remote-ip=40.92.44.20; dkim=pass header.d=hotmail.com header.s=selector1 header.a=rsa-sha256; dmarc=pass header.from=hotmail.com; arc=pass (i=1) header.s=arcselector10001 arc.oldest-pass=1 smtp.remote-ip=40.92.44.20 ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1721462194; bh=Mm8fBs8fIVK535YRupaBwzVEPpMlncBUwpIDEaciHQ8=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:MIME-Version:Content-Transfer-Encoding:Content-Type: In-Reply-To:References:Message-ID:Date:Subject:Cc:To:From:DKIM-Signature: DKIM-Signature; b=ZGMVkTbqB0O4WKTBuWUI/o6fEtqCbUIGBhug0RoLkkvbt5TsgL8FVU18DX6uY4gwcHEiGmI9K4 BC6S+2qrRkMDNq8PPeB8Q6XB73slmejdXc3JU9OgFY46AvrObRZzInDuUFJztZSJnnUeSGnFaP TtdME6OKoQiDYS6OGcqtRNN15UgYwzWhMR8ydC+5D/qVFDaVPt6M/qvgrZ32zmg6ykBfHPPbly zUn5wSi+feNx+WRo/3dQFsngla5WG090IX23Ph31D2X/15fvztoCWhLCfrfZ/DiWjY/JG2Dkyx RhItMSUhScJl/bMYu1apeptZiYSQ0G2lln1NxuLGvIy6Zw==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:MIME-Version: Content-Transfer-Encoding:Content-Type:In-Reply-To:References:Message-ID:Date :Subject:CC:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=JMQ6mlzM8a71JI+5DyC9h2RXgjXoszebbYUf4omueho=; b=H6yC73K6DWLJBdoDohqiE00Ack QUWj2H4HIYBwtnMt+UyS6dHEpE+5dP0EQt25+z3xX8d6nKwFPXrA7wbeprtDpirdV8mlq2IzpiyoD Hl4SG2m9U5mPGmSEeWHJykXNKd0PaCt4Tj0hLU2UzYT9hstqWwR5dXjSgH06IydvgSJOnEHT+ph+y pj64JMgQ7Tj3/AKIhuiy7AZjBO7tijqHRBG3AFvLRXJsiM7k9QLF8wbvMkkeYXTCrJh8Xei35e6Da LbMDJ5FUMeZ58s/ABVQ+yQmafIpwOtrFCzlo3ub0qetJc732Ht6n0fImxm+n15V880PBZWgGMUE4r hUQXG+eg==; Received: by zero.zsh.org with local id 1sV4xF-000LOv-1W; Sat, 20 Jul 2024 07:56:33 +0000 Authentication-Results: zsh.org; iprev=pass (mail-sn1nam02olkn2020.outbound.protection.outlook.com) smtp.remote-ip=40.92.44.20; dkim=pass header.d=hotmail.com header.s=selector1 header.a=rsa-sha256; dmarc=pass header.from=hotmail.com; arc=pass (i=1) header.s=arcselector10001 arc.oldest-pass=1 smtp.remote-ip=40.92.44.20 Received: from mail-sn1nam02olkn2020.outbound.protection.outlook.com ([40.92.44.20]:43926 helo=NAM02-SN1-obe.outbound.protection.outlook.com) by zero.zsh.org with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) id 1sV4wp-000L5s-9T; Sat, 20 Jul 2024 07:56:09 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=MQfe2v2ExWxnzOJzcHk59Zal3n8HeFCzfny78ruVeFyfR+HI6ymPg3BhEIcDSSecBkP1VBgjfksu1/P/HCCpkJOyeKwdWhNEZxoxPuSvM0ha+6H92vGEDk9w7Dyn3NfcQ6sTDzdha4kX9gxIRQXRlQSofcRa2ErpSDSfx6U80ZM2YioRvuLnYX1I4PgQG2KQXoTznqCDWPgKlOYi7saR7eb26v9vx+nJde1FUe7qR4PPpSD4ceSP8ZNAdv2M5yYLGtfUkJXuRqDZ2+ygbdJ/BNWRZJpgXtuXFqvb9TIjzPJA+sFqvJxdkdRKE8eUKLXl0UAEt7UkDShB+0ClZ2dZ5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JMQ6mlzM8a71JI+5DyC9h2RXgjXoszebbYUf4omueho=; b=jDMdQ2YRLIB+4EQJzu6YmwSOqBiM13dUSHu2n0modU+5EKkpGxman50juYp711vG8ZAriqXoQ8DS2FGPJ33gNmYB8zNgjRyVCqvtJiSOMyIHslibJXvoZMMurxvaeqhXntDUEJUjRhSV/3lseQXtBbjmOYsJiDhpItBnHi861DMrxYjyUa8VIDqXgicHK/SFyZpk7v6q5I3LHGKfnbxpXGFJQJDXe3deOmBR59JMZIVnvKxGpNV3j+t6CPSb1Lw9nSC+NVmGyfM0YzLlYx5IeDKfu9eeXqWeRF5Eqt3PqkNvy7iNMHyiR7934HL8GY9Ey0Zv9ttv42NlmqQlNmlMJw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JMQ6mlzM8a71JI+5DyC9h2RXgjXoszebbYUf4omueho=; b=kGIjB4409cY1QZIn0e6rG1YR6agoXQ4ZNI3XqJ2kIg5OZaQnxMAOCU/V5v+DZUfZ+G37dlZO3VbbITbTMO9OFDv/ngo/uHDqinXi9xuUMAjrbShjP0jHmuNAMzLqZSOgjEHMjF74uSsWUPPjyWG+vLhY/lEPAntfEtIip7U4JhlMhsiUyGH1R0mIFjA0Hfty7B/JupeQVEKsC2i1Tg5LEwu50QWOSSX+nm7t6hOAG7aaRulVfZEV4yjKanSKwReSTPY86LTHIL4v1HN8MpELEyJ3GPJEYZkm8Fqtht9Xix4Ts9kIRBJOadd7boIdMZ4LtCXUdhg8+j5YOMATF8Aa0A== Received: from BL1PR14MB5121.namprd14.prod.outlook.com (2603:10b6:208:31f::9) by SA6PR14MB7624.namprd14.prod.outlook.com (2603:10b6:806:40f::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7807.9; Sat, 20 Jul 2024 07:56:01 +0000 Received: from BL1PR14MB5121.namprd14.prod.outlook.com ([fe80::349b:6986:8fa4:33da]) by BL1PR14MB5121.namprd14.prod.outlook.com ([fe80::349b:6986:8fa4:33da%6]) with mapi id 15.20.7807.005; Sat, 20 Jul 2024 07:56:01 +0000 From: Franklin Yu To: =?iso-8859-1?Q?Lawrence_Vel=E1zquez?= CC: "zsh-workers@zsh.org" Subject: Re: inherit OLDPWD from environment variable Thread-Topic: inherit OLDPWD from environment variable Thread-Index: AQHa2kejRg1Yzk5ZfEiPp35Ujj+CLbH+6YsAgABLFHc= Date: Sat, 20 Jul 2024 07:56:01 +0000 Message-ID: References: <910a3a7e-ea58-4f2f-b26e-a2fff7d5c0c3@app.fastmail.com> In-Reply-To: <910a3a7e-ea58-4f2f-b26e-a2fff7d5c0c3@app.fastmail.com> Accept-Language: en-GB, zh-TW, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: x-ms-exchange-messagesentrepresentingtype: 1 x-tmn: [psrgikgrCyxs8mIS7MdLCHeC7r+DHDj6JdhFORS5jDwravPumZYLkpffXQyeK5OR] x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BL1PR14MB5121:EE_|SA6PR14MB7624:EE_ x-ms-office365-filtering-correlation-id: a696cb71-a6cf-4108-b9d3-08dca89165c9 x-microsoft-antispam: BCL:0;ARA:14566002|19110799003|8060799006|461199028|3412199025|440099028|102099032; x-microsoft-antispam-message-info: Mb3ymol8owl2enb0dCg6eweQqCAQYsVhP9nkqsnZnGr7xbwGzfkDNt+cNZK/00PP24CRu62SgqSl5Vsa25yf/EuEeeA1Kte6Kd+cN4zxk4qWnH+oI2CW6Bm+QRdsOUCKZ6Q7ZYSvxfQ9mJjL9HHquB3ToMOmOvE5jahq2+pnvDy2TxzJ6TIw8fS+ypFMNkGJKpm8IIy49Vb7OwtQ9HntcV4mMNdnKqIRh5lvB+uiV8pWYvZaIDMBxdzXrC/cK6g2qDHdvHy8L2t/YNeTl0nePCk26neZ5+Bs2ydjXaKdhdwTDLNR6Aw9nfCVHhClTlGEobgLu7/bmJfkywwhJb5Ffz5pCLiRxeW+A5e4lqjsT5a7JWUxfXEgQlV1FIzYYzKByIpo+kQncTGgFCFteZZ3Q8ZZj9TiITXwr18L/xVDJLefxnHhrnyDxQMJVyNsp1+O1hhA46OAxaOaKWqrEsSoa5Rz7JMXiTnAFZZHX7YyLGnV0SxdNBNUFGBELS+MiUb0o4fRGRDsH6MmO9A3yOHGsUBAYD67qo8ncvD6p0hfDWm92yVue9akn8xQYBD5wG5ZUojzWQQY1tlGSSYaTb3a1fBGrhNNNaSyDdyYQDsOZxUCQXw3TQ7eP+DdkRYW89LCWh+fvPWSgr7vERTJRrFMXQ== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?nZ6uaH45ywY28DfJsq8nYNETwtaFv/WCUuZfNNB4Vl5s52hMU94zqTqOIh?= =?iso-8859-1?Q?Q4OD9qUwWPTobKGbYlfb1IYV5QKpmLjN84eFUnv9LBTshCBTYlEmmcIgYS?= =?iso-8859-1?Q?vJR9SGl+aKSQRrHlzZ8OO+8nM84+9PSaFmaNm1r6E7w8qNrccaMGpY04Fs?= =?iso-8859-1?Q?CP0ruqAzMvUFPpb/xHWBHThb9XTvv3sE0BNYYUeHQcWIeQWcowVrlgZGae?= =?iso-8859-1?Q?Gs/zuNy/YGkzWbkQrYQmLghvYcY0V3DBjV1IuXEJZlQ3/vG4rRPhHiImdu?= =?iso-8859-1?Q?xwNrkFyKM2T+k5osEyjycMmEgsTCRUcb58k9GMGh3BvfZR1XGCmDOYoAic?= =?iso-8859-1?Q?x/uGmyKwf6z9fWpOd1+tPIUv7+DFbvW+6bskaqhbJacvHdlh9YAzHKeS3m?= =?iso-8859-1?Q?dMpCBVuriYtHMBlpISUvdwYNnSNgZzs+LTpdxM3RgZYEoiWQjDIxDIT7RI?= =?iso-8859-1?Q?jJ2EIkqtL4NlaFG6hvqkBD2uaXMRYD4JAxMSrTL+Oy88DILeXrkOfTPygU?= =?iso-8859-1?Q?mQzj6HyNMyebhzVUHi+S7C12KGVLSnBvQ4P7TTZAzSvM6HnRaKhfgZ4r5V?= =?iso-8859-1?Q?ER0r9DKGf9IE/HokZ/yV1Gn1+kOA9U184kwwZHmMpngk4QFXAnqJO4emyQ?= =?iso-8859-1?Q?LVRkt/2YAv1LZlRrTHBcFVBpRO2wEBdhoAklVygsUotjSCYW6yemo9Z2xC?= =?iso-8859-1?Q?gEnyucK/6EHfceumJlDnxSvbuhUBIpbkE33w8GrOvUOUFlFmw2bERZzLLW?= =?iso-8859-1?Q?pIEvnVxf6fhPPsO6/xj+ZXiw/pIjQTvPzevHk0yYHrfjguR5uz8iJbN6oC?= =?iso-8859-1?Q?1XuwcQCE2TVgPOA3wP2CNR0w9QKYfmo4U8FYyzAEGvp4bE4Qgb5bL0+WUQ?= =?iso-8859-1?Q?UE7V2EWkYD4gdFtYSy1vv02NRD1rJ3n5UySAymjWNY4XBJlH3dGKek3mwW?= =?iso-8859-1?Q?7zoIK9MX5xzMphoHS1kH27ny2sZ/FrEX35waH4jVzY0UdHT9wDm3OIaNXR?= =?iso-8859-1?Q?+dyTYpz6qSzzX98OMkq5OLv8oJzpCizA9OIUy7yWNtUP6R6iqSKp1HlxvT?= =?iso-8859-1?Q?9JisX+OsTk4iCtTMJcoKc7NILaP81UN2Gave3gf5SGmzQ7F47Y3IT7HKGt?= =?iso-8859-1?Q?241QEaIvWiN+fX7Ey52eeonIcITI0yJD6MAv/pRw0TOUBYIpT3tmDvYX5g?= =?iso-8859-1?Q?ZDHG7MLIuztrYhxREV593QBZkDQHMHPGaMipwyYSNwUEgf85dV4BrckzAz?= =?iso-8859-1?Q?vVCBLXh90MpoaSjYnDDyRRXFLRoEJK+/Eu0jBv9mPGhHPwobCXk7EZpvcq?= =?iso-8859-1?Q?8Mq2e5C9/w22amrw2TRVCnhgF9aTo9ZnXA1CjJaswStiZ2w=3D?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-7719-19-msonline-outlook-e4812.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BL1PR14MB5121.namprd14.prod.outlook.com X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: a696cb71-a6cf-4108-b9d3-08dca89165c9 X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Jul 2024 07:56:01.0694 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA6PR14MB7624 X-Seq: 52997 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: , List-Subscribe: , List-Unsubscribe: , List-Post: List-Owner: List-Archive: Good catch. Indeed Bash accepts empty value. Then it becomes=0A= =0A= diff --git a/Src/init.c b/Src/init.c=0A= index ec21521b1..092273228 100644=0A= --- a/Src/init.c=0A= +++ b/Src/init.c=0A= @@ -1245,7 +1245,9 @@ setupvals(char *cmd, char *runscript, char *zsh_name)= =0A= pwd =3D metafy(zgetcwd(), -1, META_DUP);=0A= }=0A= =0A= - oldpwd =3D ztrdup(pwd); /* initialize `OLDPWD' =3D `PWD' */=0A= + oldpwd =3D zgetenv("OLDPWD");=0A= + if (oldpwd =3D=3D NULL)=0A= + oldpwd =3D ztrdup(pwd); /* initialize `OLDPWD' =3D `PWD' */=0A= =0A= inittyptab(); /* initialize the ztypes table */=0A= initlextabs(); /* initialize lexing tables */=0A= =0A= ________________________________________=0A= From:=A0Lawrence Vel=E1zquez =0A= Sent:=A019 July 2024 19:46=0A= To:=A0Franklin Yu =0A= Cc:=A0zsh-workers@zsh.org =0A= Subject:=A0Re: inherit OLDPWD from environment variable=0A= =A0=0A= On Fri, Jul 19, 2024, at 9:55 PM, Franklin Yu wrote:=0A= > -=A0=A0=A0 oldpwd =3D ztrdup(pwd);=A0 /* initialize `OLDPWD' =3D `PWD' */= =0A= > +=A0=A0=A0 oldpwd =3D zgetenv("OLDPWD");=0A= > +=A0=A0=A0 if (oldpwd =3D=3D NULL || oldpwd[0] =3D=3D '\0')=0A= > +=A0=A0=A0=A0=A0=A0=A0 oldpwd =3D ztrdup(pwd);=A0 /* initialize `OLDPWD' = =3D `PWD' */=0A= =0A= If we're going to begin importing OLDPWD from the environment, we=0A= might as well align with other shells for consistency, which means=0A= accepting a zero-length value as is.=A0 This is how bash 5.2.26, dash=0A= 0.5.12, ksh93u+ 2012-08-01, mksh R59, and yash 2.56.1 all behave.=0A= =0A= --=0A= vq=