From: Jun T <takimoto-j@kba.biglobe.ne.jp>
To: zsh-workers@zsh.org
Subject: Re: [PATCH] find RLIM_NLIMITS correctly on Cygwin
Date: Mon, 23 Mar 2020 14:41:02 +0900 [thread overview]
Message-ID: <C2095B48-B142-4D70-98FF-CE9CB0953E10@kba.biglobe.ne.jp> (raw)
In-Reply-To: <20200320191846.3a4f5682@tarpaulin.shahaf.local2>
reply 2/2 to workers/45590
> 2020/03/21 4:18, Daniel Shahaf <d.s@daniel.shahaf.name> wrote:
>
> Jun T wrote on Tue, 25 Feb 2020 18:38 +0900:
>
>> +++ b/Src/Builtins/rlimits.c
>> @@ -53,11 +40,214 @@ enum {
>> +/* table of known resources */
>> +static resinfo_t known_resources[] = {
>> + {RLIMIT_CPU, "cputime", ZLIMTYPE_TIME, 1,
>> + 't', "cpu time (seconds)"},
>> + {RLIMIT_FSIZE, "filesize", ZLIMTYPE_MEMORY, 512,
>> + 'f', "file size (blocks)"},
>> ⋮
>
> What will happen if two different elements of this array have the same
> option letter?
(snip)
> Currently, each of the letters [mrvx] is used by two different elements.
> I haven't checked whether both elements of any of these pairs can be
> present on a single system, but in any case, more collisions may be
> added in the future.
I believe *currently* there is no conflict. I was just hoping that
if someone add a new resource (with a new option letter) in the future
they will be sure to test it (by running 'ulimit-a') and notice the
conflict if any. But I agree this is too optimistic.
> Therefore, I was wondering if we should have a test for this situation,
> or possibly a runtime check; see the attached series for example.
Thank you for the patches.
Personally I feel only adding a test (B12limit.zsh) is enough for now, but
have no objection to adding a runtime check in rlimits.c.
Do we really need resinfo_mutable?
Changes to the data in known_resouces is done via the pointer current_letter:
char *current_letter = &known_resources[i].opt;
Constness of resinfo does not interfere with this.
# and the data for unknown resource (if any) is setup using the pointer
# resinfo_T *info = (resinfo_T *)zshcalloc(sizeof(resinfo_T));
# and the assignment "resinfo[i] = info" does not conflict with the
# constness of resinfo.
Using resinfo instead of resinfo_mutable gives no warning for me
(gcc on Linux and clang on macOS).
next prev parent reply other threads:[~2020-03-23 5:41 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-08 10:39 Jun T
2020-01-08 21:33 ` Daniel Shahaf
2020-01-09 10:32 ` Jun T
2020-01-09 13:15 ` Daniel Shahaf
2020-01-10 10:24 ` Jun T
2020-01-11 20:15 ` Daniel Shahaf
2020-01-13 11:00 ` Jun T
2020-01-13 16:42 ` Daniel Shahaf
2020-01-14 4:44 ` Jun T
2020-01-14 16:25 ` Daniel Shahaf
2020-02-25 9:38 ` Jun T
2020-02-27 13:22 ` Daniel Shahaf
2020-02-27 18:46 ` Mikael Magnusson
2020-02-28 8:42 ` Jun T
2020-02-28 14:19 ` Daniel Shahaf
2020-02-28 14:31 ` Daniel Shahaf
2020-03-03 9:23 ` Jun T
2020-03-04 19:29 ` Daniel Shahaf
2020-03-05 10:26 ` Jun T
2020-03-05 14:58 ` Daniel Shahaf
2020-03-20 17:02 ` Daniel Shahaf
2020-03-20 17:20 ` Bart Schaefer
2020-03-20 17:39 ` Daniel Shahaf
2020-03-20 18:28 ` Daniel Shahaf
2020-03-20 18:36 ` Bart Schaefer
2020-03-20 19:38 ` Daniel Shahaf
2020-03-20 18:39 ` Bart Schaefer
2020-03-20 19:32 ` Daniel Shahaf
2020-03-20 19:18 ` Daniel Shahaf
2020-03-23 5:31 ` Jun T
2020-03-24 2:08 ` Daniel Shahaf
2020-03-23 5:41 ` Jun T [this message]
2020-03-24 1:33 ` Jun T
2020-03-24 2:43 ` Daniel Shahaf
2020-03-25 0:16 ` Jun T
2020-03-25 22:04 ` Daniel Shahaf
2020-03-25 23:42 ` [PATCH] find RLIM_NLIMITS correctly on CygwinjL Daniel Shahaf
2020-03-24 2:34 ` [PATCH] find RLIM_NLIMITS correctly on Cygwin Daniel Shahaf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C2095B48-B142-4D70-98FF-CE9CB0953E10@kba.biglobe.ne.jp \
--to=takimoto-j@kba.biglobe.ne.jp \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).