help / color / Atom feed
From: dana <dana@dana.is>
To: Peter Stephenson <p.stephenson@samsung.com>
Cc: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: sudo autocompletion
Date: Mon, 10 Feb 2020 12:57:27 -0600
Message-ID: <C49D8E7D-9C98-41E7-B2C4-45293B07B6C0@dana.is> (raw)
In-Reply-To: <1581356458.19604.3.camel@samsung.com>

On 10 Feb 2020, at 11:40, Peter Stephenson <p.stephenson@samsung.com> wrote:
> I think it ought at least to check if the /sbin directories exist.

Won't they just be ignored if they don't? It might be a little nicer to return
like ${(u)^reply}(/N), though

On 10 Feb 2020, at 11:40, Peter Stephenson <p.stephenson@samsung.com> wrote:
> Possibly they should also go in front of the path --- that's one of the
> points about "secure".

Not sure about that. We only want to use this for completion, not actually
resolving commands, especially if we're doing it this way where we just
blindly replace */bin by */sbin (as opposed to white-listing a few known
directories like bash does). I don't think any external commands are called
after this anyway, but...

On 10 Feb 2020, at 11:40, Peter Stephenson <p.stephenson@samsung.com> wrote:
> On the issue of setting the style at this point --- the usual behaviour
> is only to change the default locally rather than also set the style, but
> that's probably difficult here, so I don't think it's a particularly big
> deal.

I was initially going to have it update path locally, and again it'd probably
be fine here, but i figured it'd be preferable to keep that logic in


  reply index

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <912d22db-8a8f-90f2-6738-f9f395994dcb@gmail.com>
     [not found] ` <CAN=4vMqvzUTZ7bBLcbTzi-pKAVEP1xDbq=f5pLAxmffxUjTszQ@mail.gmail.com>
     [not found]   ` <1770be62-54d8-70a6-8b05-cfc98faa9b9f@gmail.com>
     [not found]     ` <20200210030219.527a3ccf@tarpaulin.shahaf.local2>
     [not found]       ` <ADE72275-1311-44BE-9B1D-5E617E3D9F94@gmail.com>
2020-02-10 17:13         ` dana
2020-02-10 17:40           ` Peter Stephenson
2020-02-10 18:57             ` dana [this message]
2020-02-10 19:20           ` Daniel Shahaf
2020-02-11 10:12             ` Oliver Kiddle
2020-02-11 10:28               ` Setting/Querying cache-policy (was: Re: sudo autocompletion) Daniel Shahaf
2020-02-12 16:51                 ` dana
2020-02-13  1:21               ` sudo autocompletion dana
2020-02-13  1:29                 ` Bart Schaefer
2020-02-15 22:22                 ` Andrey Butirsky
2020-02-15 22:48                   ` dana
2020-03-11 21:57                     ` dana
2020-03-12 21:51                       ` Andrey Butirsky
2020-02-10 22:05           ` Andrey Butirsky
2020-02-10 23:02             ` dana

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=C49D8E7D-9C98-41E7-B2C4-45293B07B6C0@dana.is \
    --to=dana@dana.is \
    --cc=p.stephenson@samsung.com \
    --cc=zsh-workers@zsh.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link


Archives are clonable: git clone --mirror http://inbox.vuxu.org/zsh-workers

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git