From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19521 invoked by alias); 27 Jun 2018 09:28:14 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 43101 Received: (qmail 20712 invoked by uid 1010); 27 Jun 2018 09:28:14 -0000 X-Qmail-Scanner-Diagnostics: from mail-lf0-f42.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(209.85.215.42):SA:0(-1.9/5.0):. Processed in 1.281209 secs); 27 Jun 2018 09:28:14 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_PASS, T_DKIM_INVALID autolearn=ham autolearn_force=no version=3.4.1 X-Envelope-From: franciscodezuviria@gmail.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:reply-to:in-reply-to:references:from:date:message-id :subject:to:cc:content-transfer-encoding; bh=+/DJ6lOnCN/Qu05wR3ed8htoTRyE0qn6CzYJ0WMOvUs=; b=C8CPFK8cvPM3hT0JHdbUWP+gm4IWQWRQH7hKjigV8ICnriLxY+didB1VJDYqITOuzP pV8OioV1ZTylJRs/DXrtTV2pCB7lOObkLsndDoUDDCPMnZxea51sUHACFW6cSzQf78Ld zk3tU/jX0/E5G7N6rlkhWnw1aKHd8wL+KPfBkpiw8qqNbg6hGGeP2I/W9LkHljVby1B2 Lw74aZvV3QzkK9xI1WYHUH14E9tilCyb6UwX2kbXVFqVAmyaqOi6SIz6yE33b+839oTd J0D/hOCW7LA+LL6ddpcFqf+M51o18kvqNhOp3rcJiwxWZSOtwArtevxqiZZYmhpQprGq G06g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:reply-to:in-reply-to:references :from:date:message-id:subject:to:cc:content-transfer-encoding; bh=+/DJ6lOnCN/Qu05wR3ed8htoTRyE0qn6CzYJ0WMOvUs=; b=bZ068lpM+XbSCdwEqg1ri/Q5L5FCDBhwxxVu3Z7osjXmc7J1/tcnPQmZvnQVWNQ43o vuO7ozWVuJ5BHyHhzSFmaeULgJu/X0RSPq5X/EPWikaCex+SeWygcA2UcwuyYq8MTlK6 90Fyb0ZK8s7bGRejMzMAU03NqXLX6V88jPtxp03iq9WPm1wIidpGgRVK9QC3wlQlmvD8 AyZ70nijRkRxx4vkR6GDEOlEXBEPJisdbPorIVKgRPCYbJUQqUA/Sz1jrnHObFMcn5VI tUWF+joy68TKC5BffKqot+JYuPydR22uXaplKemz70uWrsfmQX7oPzvsLR0/4azNnQuf P8Tw== X-Gm-Message-State: APt69E0fxDiETCEvsxqGab7OZAJSRLHATwc2hbVLxox08L+AKv6PmApt ZRJG/0vREwdVhcA47v20+14A6ykh+4X/IlYDTjE= X-Google-Smtp-Source: AAOMgpcetgJHoae2gD1FYlQCOJeqb5TKKoKj1oHHXj2qk/H1JITuprDw0knBjOSnZmYf0v/fNV4252rvBRkdJXqsREs= X-Received: by 2002:a19:385a:: with SMTP id d26-v6mr3863464lfj.47.1530091689341; Wed, 27 Jun 2018 02:28:09 -0700 (PDT) MIME-Version: 1.0 Reply-To: franciscodezuviria@gmail.com In-Reply-To: <8C5DCD3D-0429-4AFF-BE29-1D0E416AE7D9@dana.is> References: <8C5DCD3D-0429-4AFF-BE29-1D0E416AE7D9@dana.is> From: =?UTF-8?Q?Francisco_de_Zuvir=C3=ADa_Allende?= Date: Wed, 27 Jun 2018 06:28:08 -0300 Message-ID: Subject: Re: [BUG] parameter Module - functions_source associative array not working To: dana Cc: zsh-workers@zsh.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Thank you a lot dana, Sometime next year (when I am not overworked and overassigned) I would like to host some infrastructure for the zsh project (ticketing, C.I., stuff like that), so I might as well start getting some insight on the dev process now. How does the patch you just submitted get integrated in the mainline? Did you also make a pull request? On Sun, Jun 17, 2018 at 4:33 PM, dana wrote: > On 16 Jun 2018, at 22:12, Francisco de Zuvir=C3=ADa Allende wrote: >>Versions 5.3 and 5.5 >> >>Can't get functions_source to work. > > AFAIK it wasn't introduced until 5.4, so that's probably expected in the = former > case. > > I can confirm that it behaves strangely in 5.4.2 and 5.5.1 =E2=80=94 that= seems to be > because it's not marked for auto-loading. The included patch fixes it (al= ong > with dis_functions_source and usergroups); in the mean time you can kick = it into > existence by running `zmodload -F zsh/parameter +p:functions_source` (or = just > reloading the module entirely). > > dana > > > diff --git a/Src/Modules/parameter.c b/Src/Modules/parameter.c > index 10c47d214..783c36df3 100644 > --- a/Src/Modules/parameter.c > +++ b/Src/Modules/parameter.c > @@ -2190,6 +2190,7 @@ static const struct gsu_array dirs_gsu =3D > static const struct gsu_array historywords_gsu =3D > { histwgetfn, arrsetfn, stdunsetfn }; > > +/* Make sure to update autofeatures in parameter.mdd if necessary */ > static struct paramdef partab[] =3D { > SPECIALPMDEF("aliases", 0, > &pmraliases_gsu, getpmralias, scanpmraliases), > diff --git a/Src/Modules/parameter.mdd b/Src/Modules/parameter.mdd > index a91a5dc09..f71c17a72 100644 > --- a/Src/Modules/parameter.mdd > +++ b/Src/Modules/parameter.mdd > @@ -2,6 +2,6 @@ name=3Dzsh/parameter > link=3Deither > load=3Dyes > > -autofeatures=3D"p:parameters p:commands p:functions p:dis_functions p:fu= ncfiletrace p:funcsourcetrace p:funcstack p:functrace p:builtins p:dis_buil= tins p:reswords p:dis_reswords p:patchars p:dis_patchars p:options p:module= s p:dirstack p:history p:historywords p:jobtexts p:jobdirs p:jobstates p:na= meddirs p:userdirs p:aliases p:dis_aliases p:galiases p:dis_galiases p:sali= ases p:dis_saliases" > +autofeatures=3D"p:parameters p:commands p:functions p:dis_functions p:fu= nctions_source p:dis_functions_source p:funcfiletrace p:funcsourcetrace p:f= uncstack p:functrace p:builtins p:dis_builtins p:reswords p:dis_reswords p:= patchars p:dis_patchars p:options p:modules p:dirstack p:history p:historyw= ords p:jobtexts p:jobdirs p:jobstates p:nameddirs p:userdirs p:usergroups p= :aliases p:dis_aliases p:galiases p:dis_galiases p:saliases p:dis_saliases" > > objects=3D"parameter.o" >