From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13698 invoked by alias); 11 Aug 2015 15:23:02 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 36105 Received: (qmail 18895 invoked from network); 11 Aug 2015 15:22:59 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL autolearn=ham autolearn_force=no version=3.4.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :content-type; bh=AxLI2itHq5NVx1w9MTOcEwK1gVEZ79+4Vk4fjH1FmyI=; b=KazsryBU5YNtKEvmO8IjCJs/T96FP4hMmT3xvNnodV2b5grtO9ZqsQgA9EFhXbbmL4 JOgE53ksiQ49xoV8K4L8hOoObnhub1h+kBbA/C7lEd6+cL9OubVJ4nFb1Sj0AmuaHy45 ARhiVOR0Sou/YcjFgxOitzFet2h0qV9pYE7U8CgSAOYIfcYCF4PTfzoS2m+2Y1gMqBk5 mabioKzvFmZnaRYYEqE74MaLgnQMeABvpIgCc+0btsQi3+gm5LOrKFjI0kPJGQcfvFF9 j5Nf4XymIJJo4+uTs0S6I7jHG/SnM+XIyeoGehS1apR6antFNm5GymbKU8a3cuXaJA0v E9mw== X-Received: by 10.60.142.170 with SMTP id rx10mr24789178oeb.28.1439306578536; Tue, 11 Aug 2015 08:22:58 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <150811080742.ZM27810@torch.brasslantern.com> References: <150803085228.ZM24837@torch.brasslantern.com> <150803135818.ZM24977@torch.brasslantern.com> <150804235400.ZM9958@torch.brasslantern.com> <150805085258.ZM17673@torch.brasslantern.com> <150805115249.ZM7158@torch.brasslantern.com> <150805132014.ZM7746@torch.brasslantern.com> <150805220656.ZM18545@torch.brasslantern.com> <150806085451.ZM402@torch.brasslantern.com> <150806223906.ZM17762@torch.brasslantern.com> <150810123445.ZM1612@torch.brasslantern.com> <150810175343.ZM24452@torch.brasslantern.com> <150811080742.ZM27810@torch.brasslantern.com> From: Mathias Fredriksson Date: Tue, 11 Aug 2015 18:22:18 +0300 Message-ID: Subject: Re: Deadlock when receiving kill-signal from child process To: zsh-workers@zsh.org Content-Type: text/plain; charset=UTF-8 On Tue, Aug 11, 2015 at 6:07 PM, Bart Schaefer wrote: > > This looks like we're waiting for a non-existent job again. Last time > it was the strace output that pointed to the culprit, because here the > call stack has most likely grown and shrunk several times before the > blocking waitjobs() is finally called. > > execpline() already does queue_signals() around its only waitjobs(), > and zwaitjob() runs the signal queue before checking the status of > jobs, so the following is a bit of a shot in the dark, rearranging > the order in which SIGCHILD and the queues are managed. I think it's > probably better to do it in this order anyway, I was undecided about > it when I initially made the patches. That seems to have done it, can't reproduce anymore!