From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-36086-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 20190 invoked by alias); 10 Aug 2015 21:18:36 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 36086
Received: (qmail 7983 invoked from network); 10 Aug 2015 21:18:34 -0000
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H3,
	RCVD_IN_MSPIKE_WL autolearn=ham autolearn_force=no version=3.4.0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:in-reply-to:references:from:date:message-id:subject:to
         :content-type;
        bh=08O67zRuLs/4rzl7NLO9VBfQA9Fg1NlwMC4BJ+nQTqg=;
        b=Yixgx8+quI2RLg+obKlhViAJPVHfZ12p6R7IMwoSlB8vu1BxKolQbmGZukbmEgSlo0
         S5AGvsJJRFAWLp0s0wWS4WdkLX1KSgDWwLdi/1BXmi8oDugqDiTz+zoNQ3HKpWiAC1ek
         YtKYkOYdWT8vgMW5nn0gbyAm4H8qEHUc0B+9tAPEmEZxrIgcNUD4RyGicBA8ezcBYFHV
         pllnYVKmL7CUDo+sp5ZlFmU/jbxtmZk56AR47PDm4ScEurmVFzkHJ/EiAiqTvBXogJQj
         S6fUxVktmlOvTq7q+gTx1Jkz9Kv88yjRA7NQrXcefxQftrtYSUE4+WTe++V0QklPATf3
         Lf6Q==
X-Received: by 10.202.204.66 with SMTP id c63mr95380oig.12.1439241512202; Mon,
 10 Aug 2015 14:18:32 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <150810123445.ZM1612@torch.brasslantern.com>
References: <CA+=GgY7mHkyK4NJQ6m7y-HpVPKOuKx3-bkJqRHriKzZ662_iwA@mail.gmail.com>
 <150803085228.ZM24837@torch.brasslantern.com> <CA+=GgY5iZfgUag_V1jqmCv4=PUGBmaV2cNWTDjSO4DAZ+zm-iQ@mail.gmail.com>
 <150803135818.ZM24977@torch.brasslantern.com> <CA+=GgY7uGzCYEKLBzqrt=ct6q72WFC5w1jMB5RDNe60J-wUz=Q@mail.gmail.com>
 <150804235400.ZM9958@torch.brasslantern.com> <CA+=GgY5826pmKzn=WHUKCVWOEfRbP=sCN873arRsYHvGgEUb7A@mail.gmail.com>
 <150805085258.ZM17673@torch.brasslantern.com> <CA+=GgY5F-ZD7us6C6-N+3NevKPmVvcJ+Zm7MYp4yDQTZhxY6kg@mail.gmail.com>
 <150805115249.ZM7158@torch.brasslantern.com> <CA+=GgY73SZ9NkSS74sOyF_VtaCU=Np8fixq1PbG4QmcgbcfVjQ@mail.gmail.com>
 <150805132014.ZM7746@torch.brasslantern.com> <CA+=GgY7cg9aDJxN--wcX=+MSD9dd2To3fSm9ecsd=tF1zg=zbQ@mail.gmail.com>
 <150805220656.ZM18545@torch.brasslantern.com> <CA+=GgY5xEojBVRpKKZp-svZStp-s4=N10Xz2n0=s8SKjUpbNwg@mail.gmail.com>
 <150806085451.ZM402@torch.brasslantern.com> <CA+=GgY5BAkLceSV_Hav_mhna7M7aTLHH-WqV2EHmDRrMdqi16A@mail.gmail.com>
 <150806223906.ZM17762@torch.brasslantern.com> <CA+=GgY4+utmAzyYyBn1wQy1BhFcrzk+DiN+FcqYOpUdrSHhbGg@mail.gmail.com>
 <150810123445.ZM1612@torch.brasslantern.com>
From: Mathias Fredriksson <mafredri@gmail.com>
Date: Tue, 11 Aug 2015 00:17:52 +0300
Message-ID: <CA+=GgY6LVcYBJehR_9=Q08kkvJy-9rxpLnQ-wGF+brPQFf1oiQ@mail.gmail.com>
Subject: Re: Deadlock when receiving kill-signal from child process
To: zsh-workers@zsh.org
Content-Type: text/plain; charset=UTF-8

On Mon, Aug 10, 2015 at 10:34 PM, Bart Schaefer wrote:
}
} A quick grep indicates 34 realloc() and 224 free() scattered around
} the code.  Probably many of them are already within queue_signals().
} The patch below fixes four of them that your stack traces seem to
} point to as particular culprits.  It's probably not worth it to try
} to pre-emptively change all the others.

That sounds reasonable to me.

}
} If you are still able to create deadlocks after the below, I'd also
} ask you to try configuring with --enable-zsh-mem and see if that gets
} rid of any remaining deadlocks.

I had one skill, Bart, to produce deadlocks. And now you've taken that
away from me! On a more serious note, I have not been able to produce
any deadlocks after 36084! I also did not get around to test with
--enable-zsh-mem since it is working just fine. I also tested building
zsh without debugging, no problems there either.

Thanks for sticking through with this, and good job on finding
(hopefully) all the edge cases :)!