From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3320 invoked by alias); 12 Oct 2016 03:36:08 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 39617 Received: (qmail 20134 invoked from network); 12 Oct 2016 03:36:08 -0000 X-Qmail-Scanner-Diagnostics: from mail-ua0-f175.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(209.85.217.175):SA:0(0.0/5.0):. Processed in 0.301398 secs); 12 Oct 2016 03:36:08 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=FREEMAIL_FROM,SPF_PASS, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.1 X-Envelope-From: gmesalazar@gmail.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at _netblocks.google.com designates 209.85.217.175 as permitted sender) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=cYpL6NIKUg0zi6m7TJe8P9/ZtLPMEn7/l6KoDF1nUTI=; b=zcJ/hcci8uTZOwTq83YkXgvlcNQmoqPkpRp495chDF9m/yOCOyTh86oL9KJ5xfjoEc dR60DGoHVGLi2pxk5jNgrhnC0u4Ye98co3ljE+Qzbz9ZZnlUZY22+2NDJMrc0A1DDxgD SqBHTGX1GX6G2uwwAxWEbu/Ai1Ik5gYxpg3kOZwKYF7ymabkJ0C+4Oz3HFpfqGU2YVc3 /M6rAbaX6n2EJ/E3nZiwHLTC+02+/o5oRFCCNfbJJtfbIb0ii0ET3LZufj6pB1TQkfrJ fEwcy2U8Cz3DDynOXeHfRsH7BeokIGkcpbJtDrqE48/RYnXIIkNaZ7KB2WIBUT21gLzt vENg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=cYpL6NIKUg0zi6m7TJe8P9/ZtLPMEn7/l6KoDF1nUTI=; b=SqPkp3zvQgSewAk1pMeNP/qksq9CRHtyoJaOospQyIaDDcGoIIJKp4IE/7V8Ru2O/B 4B3HKoDkVal6eAffYdbg+1vUDOM8DgZOSLz97Z2jSe+8EOtIwUhd2VuwIq0mPvepDqKN 5N4YoaJfa5GrVRrh8iP6AGiTwEHDKFym3LyF5shp11Lc9r6N/UqNWP3qgozivTyLvWBz XQ1Suqc+Qmtf8vn9nmlOpEfcUdMfgLZHSOfnPVnPRyArRz+P36Wn4IZOllHpWHisWZfx 51XefkcKnR4FBJ0zNM9n6vVQObqfTjSa2dC3tnFki72C3PuYE+F1pA53UHHre/v2858q 3x0g== X-Gm-Message-State: AA6/9RmRuVl2T9wPfhklpgjWc4bqVok2/9r1m6IMUfMnE0mPtJVhASFIjPL2FpfqbgyFbikawc3RdR4s9gjWDA== X-Received: by 10.176.0.184 with SMTP id 53mr216658uaj.5.1476242879027; Tue, 11 Oct 2016 20:27:59 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <20161011212150.GA24484@fujitsu.shahaf.local2> <20161012000249.GA32367@fujitsu.shahaf.local2> <20161012003606.GB32367@fujitsu.shahaf.local2> From: Guilherme Salazar Date: Wed, 12 Oct 2016 00:27:38 -0300 Message-ID: Subject: Re: zsh make(1) completion on FreeBSD To: Daniel Shahaf Cc: zsh-workers@zsh.org, Baptiste Daroussin Content-Type: text/plain; charset=UTF-8 By the way, completely unrelated question: I noticed some inconsistencies in the use of tabs/spaces for indentation; are there conventions for that in the project? If so, are patches fixing it welcome? On Tue, Oct 11, 2016 at 10:14 PM, Guilherme Salazar wrote: >> That's precisely what the _pick_variant call at the top of the function >> does, so you can just test $is_gnu instead. Note that the enclosing if >> already inspects that variable. > > $is_gnu will still give unix (on FreeBSD) in case `which make` is just > a symlink to /usr/local/bin/gmake. > >> In current master (before your patch), the 'call-command' style is >> consulted only for GNU make but not for FreeBSD. Do you know if that's >> intentional, perhaps (going by the style's docs) because the GNU make >> invocation has side-effects while the BSD make invocation has none? > > I'd expect the -n option to avoid side effects. Perhaps the reason is > that the BSD make infrastructure is a lot different than GNU's and a > single Makefile may not carry enough information by itself to generate > good completion?