From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14151 invoked by alias); 7 Oct 2017 07:44:57 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 41826 Received: (qmail 20937 invoked by uid 1010); 7 Oct 2017 07:44:57 -0000 X-Qmail-Scanner-Diagnostics: from mail-io0-f195.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(209.85.223.195):SA:0(-4.2/5.0):. Processed in 2.039227 secs); 07 Oct 2017 07:44:57 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,HTML_MESSAGE, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,RCVD_IN_SORBS_SPAM,SPF_PASS, T_DKIM_INVALID autolearn=ham autolearn_force=no version=3.4.1 X-Envelope-From: dana@dana.is X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dana-is.20150623.gappssmtp.com; s=20150623; h=mime-version:from:date:message-id:subject:to; bh=fSEH+5uKL/zapIFl2f4gz6O8B2qFyTy4giqdwgrjDyg=; b=BEu1a3T7icPJvvxCzCfT0dct/QzakrM8PtLUAol3Db9hdYf6WsrZXriN0HmNFPtalB CQ1eRVEWSYolHpVJp605ohFb5RkDgIJwGDaFUXeGmAm/Qu1PV+LstzCt0WsZZtKHjkzA dyR3q11iNIP9RmnPseMjBKOMuBcyJJXGZz0WptNYlUGF+xxYSpqnaQT6+RYubk2/Ea3O xvHnZENDq4UDUmL6p4VR4tITw/KE7WpSIvrBfJFp5mOTcUAvs4zJpYQHi/+e6QaTtZfE lA02hGIUoFR1puNSYuggYD4DgIUDh4Ml2caweRomJ1CR08qymK6Oh3CkaQdCILX8d6VY Ry8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=fSEH+5uKL/zapIFl2f4gz6O8B2qFyTy4giqdwgrjDyg=; b=F6ueT0/DGKM96ZoFOshfadN0dskD9gmxOl4GWjNcibbhtnFdaVhZb5rN0Aw38t+SIL ZqEk2u2MFxCplaY+NPdyDand6ZIkgDHfXakhRWWqgUqnNIPdFMc7/YtoGU3f+PeVDQ2t wiy6r6gBqn1K2m+KFNymzsZ9hVpQg5f9zEMkZWldKsSwetX7nQ2VtVbU0jyYmVgG/Nh6 RpHp7BPEUeyJiQMlNVQlIPTQxqXUlRC5OyAGvSHOmBm5DnFvaxhHbtvor1HUYtcl0yhX /BK4IcGkBvnfvw/qO7QcrSo69aBjNKUBBFZ2o+pCVYgZJR7LUHq5JTfNzfrMXdbZ3/hl 2pjg== X-Gm-Message-State: AMCzsaVoLDpU0joDM7B5Jf6xF4Wx7C5vD1ARZJCAkBqDevBjZlaC5u12 2ZRfdU4J/1pI1U2wsGi9iiHxACI5SdQs+P6lqMN1nlUN7M4= X-Google-Smtp-Source: AOwi7QCug95Ox1GieO99uvsEWU4gFRnwDzHAjQvrzkXMPUgLSxOK0FERWqSB7mb6d1uCBUxqOUeT2BuX4l7+KtTAIqs= X-Received: by 10.107.47.69 with SMTP id j66mr6078386ioo.225.1507362290366; Sat, 07 Oct 2017 00:44:50 -0700 (PDT) MIME-Version: 1.0 X-Originating-IP: [173.20.63.226] From: dana Date: Sat, 7 Oct 2017 02:44:09 -0500 Message-ID: Subject: [PATCH] Fix inaccuracies in _brace_parameter completion wording To: zsh-workers@zsh.org Content-Type: multipart/alternative; boundary="001a11355752dd9711055af0211a" --001a11355752dd9711055af0211a Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable The _brace_parameter completion function indicates that the expansion flags B, E, M, and R can be used with the ${foo/bar/baz} syntax. According to the documentation (zshexpn), this is not so: The following flags are meaningful with the ${...#...} or ${...%...} forms. > The S and I flags may also be used with the ${.../...} forms. > Testing and a brief glance at the source seem to confirm this, though my C is not great =E2=80=94 please let me know if i'm mistaken. Credit to psprint in #zsh for discovering the wording problem. dana diff --git a/Completion/Zsh/Context/_brace_parameter b/Completion/Zsh/Context/_brace_parameter index f22db8895..b119ccd11 100644 --- a/Completion/Zsh/Context/_brace_parameter +++ b/Completion/Zsh/Context/_brace_parameter @@ -178,11 +178,11 @@ if [[ $PREFIX =3D *'${('[^\)]# ]]; then # "_:extended flags, for future expansion" "S:search substrings in #, %, / expressions" "I:search th match in #, %, / expressions" - "B:include index of beginning of match in #, %, / expressions" - "E:include index of one past end of match in #, %, / expressions" - "M:include matched portion in #, %, / expressions" + "B:include index of beginning of match in #, % expressions" + "E:include index of one past end of match in #, % expressions" + "M:include matched portion in #, % expressions" "N:include length of match in #, % expressions" - "R:include rest (unmatched portion) in #, %, / expressions" + "R:include rest (unmatched portion) in #, % expressions" ) _describe -t flags "parameter flag" flags -Q -S '' return --001a11355752dd9711055af0211a--