zsh-workers
 help / color / mirror / code / Atom feed
From: Julien Nicoulaud <julien.nicoulaud@gmail.com>
To: Mailing-list zsh-workers <zsh-workers@zsh.org>
Subject: PATCH: Fix little chown completion annoyance
Date: Sat, 27 Aug 2011 19:29:36 +0200	[thread overview]
Message-ID: <CA+mcLN4eomSzHzHQSQeYVV1aGfmX0eE6tmL3mHBKL=Rv35TDmg@mail.gmail.com> (raw)


[-- Attachment #1.1: Type: text/plain, Size: 129 bytes --]

Hi all,

'chown user: path' is valid syntax, so the colon after "user" should not be
automatically removed.

Regards,
 -- Julien

[-- Attachment #1.2: Type: text/html, Size: 206 bytes --]

[-- Attachment #2: 0001-chown-user-path-is-valid-syntax-so-the-colon-should-.patch --]
[-- Type: text/x-patch, Size: 801 bytes --]

From e612e24db18c291a4aa2bf853437f3ff0883f3f6 Mon Sep 17 00:00:00 2001
From: Julien Nicoulaud <julien.nicoulaud@gmail.com>
Date: Sun, 28 Aug 2011 07:08:31 +0300
Subject: [PATCH] 'chown user: path' is valid syntax, so the colon should not be removed.

---
 Completion/Unix/Command/_chown |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/Completion/Unix/Command/_chown b/Completion/Unix/Command/_chown
index b453931..ab1cbe6 100644
--- a/Completion/Unix/Command/_chown
+++ b/Completion/Unix/Command/_chown
@@ -40,9 +40,9 @@ case $state in
       if compset -S '[.:]*'; then
         suf=()
       elif [[ $OSTYPE = irix* ]]; then
-	suf=( -qS '.' )
+	suf=( -S '.' )
       else
-	suf=( -qS ':' )
+	suf=( -S ':' )
       fi
       _users "$suf[@]" && ret=0
     fi
-- 
1.7.4.1


             reply	other threads:[~2011-08-27 17:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-27 17:29 Julien Nicoulaud [this message]
2011-08-27 17:36 ` Mikael Magnusson
2011-08-27 17:45   ` Julien Nicoulaud
2011-08-27 17:52     ` Mikael Magnusson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CA+mcLN4eomSzHzHQSQeYVV1aGfmX0eE6tmL3mHBKL=Rv35TDmg@mail.gmail.com' \
    --to=julien.nicoulaud@gmail.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).