PATCH: Fix little chown completion annoyance

PATCH: Fix little chown completion annoyance

[Julien Nicoulaud]

[-- Attachment #1.1: Type: text/plain, Size: 129 bytes --]

Hi all,

'chown user: path' is valid syntax, so the colon after "user" should not be
automatically removed.

Regards,
 -- Julien

[-- Attachment #1.2: Type: text/html, Size: 206 bytes --]

[-- Attachment #2: 0001-chown-user-path-is-valid-syntax-so-the-colon-should-.patch --]
[-- Type: text/x-patch, Size: 801 bytes --]

From e612e24db18c291a4aa2bf853437f3ff0883f3f6 Mon Sep 17 00:00:00 2001
From: Julien Nicoulaud <julien.nicoulaud@gmail.com>
Date: Sun, 28 Aug 2011 07:08:31 +0300
Subject: [PATCH] 'chown user: path' is valid syntax, so the colon should not be removed.

---
 Completion/Unix/Command/_chown |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/Completion/Unix/Command/_chown b/Completion/Unix/Command/_chown
index b453931..ab1cbe6 100644
--- a/Completion/Unix/Command/_chown
+++ b/Completion/Unix/Command/_chown
@@ -40,9 +40,9 @@ case $state in
       if compset -S '[.:]*'; then
         suf=()
       elif [[ $OSTYPE = irix* ]]; then
-	suf=( -qS '.' )
+	suf=( -S '.' )
       else
-	suf=( -qS ':' )
+	suf=( -S ':' )
       fi
       _users "$suf[@]" && ret=0
     fi
-- 
1.7.4.1

Re: PATCH: Fix little chown completion annoyance

[Mikael Magnusson]

On 27 August 2011 19:29, Julien Nicoulaud <julien.nicoulaud@gmail.com> wrote:
> Hi all,
> 'chown user: path' is valid syntax, so the colon after "user" should not be
> automatically removed.

This appears to be a GNU extension, and does the much more annoying
thing of changing the group of the files to the main group of the
specified user, so with the proposed change, everyone would need to
backspace away the colon to not change the group. Plus it breaks on
systems that don't use GNU chown.

-- 
Mikael Magnusson

Re: PATCH: Fix little chown completion annoyance

[Julien Nicoulaud]

[-- Attachment #1: Type: text/plain, Size: 775 bytes --]

Hum, yes, I guess I'm feeling annoyed by this because I always specify the
group (explicitly or with the colon suffix), but most others don't. Let's
forget about this.

-- Julien

2011/8/27 Mikael Magnusson <mikachu@gmail.com>

> On 27 August 2011 19:29, Julien Nicoulaud <julien.nicoulaud@gmail.com>
> wrote:
> > Hi all,
> > 'chown user: path' is valid syntax, so the colon after "user" should not
> be
> > automatically removed.
>
> This appears to be a GNU extension, and does the much more annoying
> thing of changing the group of the files to the main group of the
> specified user, so with the proposed change, everyone would need to
> backspace away the colon to not change the group. Plus it breaks on
> systems that don't use GNU chown.
>
> --
> Mikael Magnusson
>

Re: PATCH: Fix little chown completion annoyance

[Mikael Magnusson]

On 27 August 2011 19:45, Julien Nicoulaud <julien.nicoulaud@gmail.com> wrote:
> Hum, yes, I guess I'm feeling annoyed by this because I always specify the
> group (explicitly or with the colon suffix), but most others don't. Let's
> forget about this.

You can just type the name of the group while the colon suffix is
there, and it will remain, that's sort of the point; it's only removed
if you type a whitespace character.

-- 
Mikael Magnusson