From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23388 invoked by alias); 21 Feb 2017 17:34:01 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 40608 Received: (qmail 3870 invoked from network); 21 Feb 2017 17:34:01 -0000 X-Qmail-Scanner-Diagnostics: from park01.gkg.net by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(205.235.26.22):SA:0(0.7/5.0):. Processed in 1.929951 secs); 21 Feb 2017 17:34:01 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=0.7 required=5.0 tests=FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,RCVD_IN_SORBS_SPAM, RP_MATCHES_RCVD,T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.1 X-Envelope-From: SRS0=EyLR=2C=gmail.com=julien.nicoulaud@bounces.park01.gkg.net X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: none (ns1.primenet.com.au: domain at bounces.park01.gkg.net does not designate permitted sender hosts) X-Virus-Scanned: by amavisd-new at gkg.net Authentication-Results: amavisd4.gkg.net (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=IxIv4usLPGKb9dZGR+BSHzXh8smXq8aqOLCw2zELu84=; b=Yc0JLv4MwqxMzZvv+SC+16kTtTG9glBGZLTydwjtrZ/d5qRQ0KCLxh1HjzdvBL6fAc RQkbVzSnkgfV8KXGSmLL2f/ir06elmLcAeJFfGCNENTqyPAHt/gEdGtSVX8kEF6qeU8u 24U8S/Hv0x3a6Ujm20QbBl19JiWgHHIW1h9PNakF8TK7+E/0XS7KteAj92U02YjkZaXi /WEIsTODSrIQUGCsLSD5dQjgPkVZoW/0M8WO1H6jl0QuO5TLSNtgLnLMhacA8Wb+Z0ar LMuVO5jT76d5X1D8hqvMlnIVPCCvhJlodTt4huCT6tzp3YtvAhX2OUMKvn4mcWBcDOi6 4odQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=IxIv4usLPGKb9dZGR+BSHzXh8smXq8aqOLCw2zELu84=; b=oFvu22hw+4sxnJvXjDyBOTKrrRgeJ47geDih1dkU4pyKFMgSZw+lNnFnb31KEj322u 1RfXXedv2oHWwEwo9ECJWzEBE5SvV8AgK98uJZrjV/FsUTlTWPntD3syb2/dBkWkPyDk HQ6XJh2UGq/PvcLrwNk5dmgDkemSXGMDC9VVJCBxUeJkh8RB3oYYd9U4FVBKfionTjH0 mWybM+9bJAgPzEptUAM1yhnPOrP0Hzm3mgrKdWpzqBMpBf7LcuLNOPQxgijREUppB8gl 05Gqb+ZDRBpb9c+ifTND3UQq9qlUYTEeZVFv3rTFRphKb7xzqVhXYnAEQk00fEiK48Zd UUzQ== X-Gm-Message-State: AMke39lhDOjGuXy5FzEiumUC/A+WTdGw8/85/EfZaM72CH0wmBdaeMRrmF8ayts/xFdMunQML0gvO4bub3jh0g== X-Received: by 10.55.42.1 with SMTP id q1mr28621330qkh.239.1487698414052; Tue, 21 Feb 2017 09:33:34 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <26668.1487697790@thecus.kiddle.eu> References: <26668.1487697790@thecus.kiddle.eu> From: Julien Nicoulaud Date: Tue, 21 Feb 2017 18:32:53 +0100 Message-ID: Subject: Re: Fwd: adb pull and push remote completion To: Oliver Kiddle Cc: Mailing-list zsh-workers , "zsh-workers@closedmail.org" Content-Type: multipart/alternative; boundary=001a11473db080ccaf05490dc7de --001a11473db080ccaf05490dc7de Content-Type: text/plain; charset=UTF-8 Hi Oliver, 2017-02-21 18:23 GMT+01:00 Oliver Kiddle : > Julien Nicoulaud wrote: > > > > A while ago there was a compdef for adb in https://github.com/zsh- > > users/zsh-completions, but we deleted it as there was one in zsh: > > https://github.com/zsh-users/zsh-completions/blob/ > > e70e7f8941d7437a161e3e4bb93f06e9c712c4a4/src/_adb > > > > I'm not sure which one is the better one, they probably need merging, but > > anyway the one in zsh-completions could complete adb push/pull. > > I hope this can be useful. > > A cursory glance at the adb completion in zsh would indicate that, while > there is plenty of scope for improvement, it is at least attempting to > complete files on the remote device for push/pull. Without the requisite > hardware, I can't test it and last time I touched that function I managed > to accidentally break it so I'm reluctant to change it. Does it not work > for you? > I can't test either, I don't have an Android device anymore. > > More generally, whether or not the function in zsh is better or worse, > it is the one that was contributed to zsh. Personally I'm wary of ever > picking up functions from github projects and merging their features, > especially where they have an explicit licence other than the zsh > licence. In this case it appears that you are the author of the old > function on github so you'd not have to worry. It might be possible to > use the _remote_files helper when completing the files. > Agreed, I just wanted to give a pointer in case it can be useful. If anyone wants to work on merging the compdefs the license is not a problem. > > Oliver > Julien --001a11473db080ccaf05490dc7de--