From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13559 invoked by alias); 2 Feb 2017 17:39:47 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 40487 Received: (qmail 11283 invoked from network); 2 Feb 2017 17:39:47 -0000 X-Qmail-Scanner-Diagnostics: from park01.gkg.net by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(205.235.26.22):SA:0(0.5/5.0):. Processed in 0.730595 secs); 02 Feb 2017 17:39:47 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=0.5 required=5.0 tests=FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,RCVD_IN_SORBS_SPAM, RP_MATCHES_RCVD,T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.1 X-Envelope-From: SRS0=8llx=ZP=gmail.com=ericdfreese@bounces.park01.gkg.net X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: none (ns1.primenet.com.au: domain at bounces.park01.gkg.net does not designate permitted sender hosts) X-Virus-Scanned: by amavisd-new at gkg.net Authentication-Results: amavisd4.gkg.net (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=ICfByCo72e4uHxNpGMz2jeN1/vGRPDm9N3oM+tM/0Rg=; b=NpL62FdMBV92huuU2bKA0UOpqlIOw5pCnmNz3k9MD+kGtzc6EPVnpXWiKcNPdIZbSd sjZt2qD+kyWY0OhyqUVHWZBk28VO9fvFmlsPmbr9quHtNVCiNBldPC/Y/RdpkGyweJB+ NUzbq/ENSXxYw8iTk1GE2IreUtEj1+Y38N/VFe/HPP9b0VGTXzZrWCms+O+Cg5krb3q9 ibXTMpEfdU9P9S+w8ZPiCWbG6GlYf4ngbfQ4sYLYGZLDfOLeDo2nyjO5UQCr0q6azqKw QdC9nfcRZTqVs2DLLjQt5ZGcG9bdVSL96c+ofbJP7cjgt1nq+ocaIVD5JP8/CeyQveXk ZkzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=ICfByCo72e4uHxNpGMz2jeN1/vGRPDm9N3oM+tM/0Rg=; b=FESjxt0ullUPlTkgey8qvu0vsAqyUU/eoA5x5wMjj1DA2+QDlZWsi5tJNT9OFeKehI 6jMXgPbJjZBXltEQ1WuefwqWYIs+xPUua/DFU88x8NOuP9picb3xMmUb46yToYKp78bW kXoSogbfM272UGY9uDRXcPEzSqZrknnKEcPEcSaOfxvkBrokNcH3nnuewGHMtvPZSL6R PciYsD6L2T3+kMQYbqr7qFzebJ/A0T6sXW2ZbfTr1pLwAoreCZXUsXQKzgisR9SZewU2 UUE+2VbceKtBbIx90exzQ1tWNAdEZQF8D4xoszwC7+pGWS9fpo/e0NH6qUury20NuNZy 1V8Q== X-Gm-Message-State: AIkVDXLckW1e+W7GPev65GeOcci485otAo4Z1FoCT7YHcWkKJRuxRfJJTRhMCYzhIISOT36xdwsQDV5kbnMvGw== X-Received: by 10.200.51.6 with SMTP id t6mr8884225qta.75.1486057156407; Thu, 02 Feb 2017 09:39:16 -0800 (PST) MIME-Version: 1.0 In-Reply-To: References: <20170201204114.53246-1-ericdfreese@gmail.com> <170201165613.ZM2163@torch.brasslantern.com> From: Eric Freese Date: Thu, 2 Feb 2017 10:38:55 -0700 Message-ID: Subject: Re: [PATCH] Remove zpty exit hook from forked processes To: Bart Schaefer Cc: zsh-workers@zsh.org Content-Type: multipart/alternative; boundary=001a1145bf90ec7a1405478fa47c --001a1145bf90ec7a1405478fa47c Content-Type: text/plain; charset=UTF-8 Hey Bart, First, thanks very much for setting up the workaround email addresses. I was having a hell of a time sending this patch. > If the only meaningful diff is this one ... > > } + deletehookfunc("exit", ptyhook); > } clearjobtab(0); > > ... then there is no reason to move around all those static functions. > Just mark the one to be declared in the autogenerated header file. I wasn't aware of the significance of the `/**/` comment above certain functions but it makes perfect sense now. I'm not familiar with the etiquette around making changes to a patch since I've mostly worked with GitHub and their pull requests for submitting changes to open source projects. Would it be most helpful for me to re-submit a modified patch, or do you have everything you need from me to make the requested change? Cheers, Eric --001a1145bf90ec7a1405478fa47c--