From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FROM,HTML_MESSAGE,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 19470 invoked from network); 28 Jan 2021 09:41:17 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 28 Jan 2021 09:41:17 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20200801; t=1611826877; b=pz/ip+6T/qfzu9ygYdrq5KAIJsBV0m4Z0HTuQYiYDJWXG8p5AXQBJAgfYdyGj/1CV3izVbITHo rmID6R061esnn/gssWZK8kdnDTxBMLynem5/RvZ5P5ZUXHf3KcuZV/s+GTmCfncpcyg9QRnDKn O+spDRfwiAVhSbD5Efz1gI8akfjJH6wl8rL9fSx+x7uGrIEqLKTXEsNqqAZVba1WdZiXtz/NV4 n09AjAi8K4fZg5MN/Hip8ZwOKPesmMMWVDNx0KAgzHs9dRTVsIab8wGWHUEZyYOyjgHlHzBDpQ uK2JOGWvykhfm0OkxhqdHw0vnnnJM2n+OiByO2+gj2AvNw==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (mail-il1-f179.google.com) smtp.remote-ip=209.85.166.179; dkim=pass header.d=gmail.com header.s=20161025 header.a=rsa-sha256; dmarc=pass header.from=gmail.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20200801; t=1611826877; bh=o0fPyNfK8pkoIaj5plKnvjTZQJLoK7RBAFVHMr25Ovc=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:DKIM-Signature:DKIM-Signature; b=s7RxEIoisCKwPna2sOqk72anvNPjo+nHSKrSnWOFRO2j5/DdpESE/Z0S3yjnz5wRx5GsQn+8vl ySK7w6/uHO+u87AJb/Dxz6MaD02gTXAlCO3BU5UEfGf84nblVTvK6Rzpk0gcob+DWezxzUD6yb ZNxm3rjgWjovPhaZaClAJGjAMWR5PMMRlwL+SkEEO6sguqCA+/6QD3hR9BqPVB4olAr8K4+Or5 Ptf7jDE+SKeDBCtGhkXiAkpYrjFqL/FCBgtnpXs+OvlvrSw/GTRMXWtXeiW0mSpDMCfbYKOxms Mv0IsOJWNcJNrieLApLShtNEVvKZXLq+BAfAyfruh+eYEA==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20200801; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Type:Cc:To:Subject:Message-ID :Date:From:In-Reply-To:References:MIME-Version:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=Hv21MK55gWh/YhU9m4MSxyttZ6b0TJfuAh2G9T+WciE=; b=YsMH97BT3Gi4HteTF8+bBRD/yy IJJUSdKlpMDOY1S6zyeEOe02C9IqLiui/lhIwDrBFu7PZDdDBwFe6KPrz5YWXUMaoB1IFKolKqiDW dUF83Xjhg8rF08QqJrDbkrw/fYoc3EmGYSrZZnM0RQndqZj/0sgagBcxNLpDINS9yNPWUi+PT+9Oz gIyFvj+dM+Kbz6Fl6hjV+iXvC/rtxlyA6bSQtUlSu26nvt2WjBga3nlaX7mLGVeuLFmLTCZ8Io1tL OUYrYGn+Py/OtEmo9hm6ZR27X4YQOVxEO+b4VCfAkWm9dwkWL/MPqXTUOHG1QXMpSF6xky0MCqPCQ Z3mVIWsQ==; Received: from authenticated user by zero.zsh.org with local id 1l53nf-0003yt-Q8; Thu, 28 Jan 2021 09:41:15 +0000 Authentication-Results: zsh.org; iprev=pass (mail-il1-f179.google.com) smtp.remote-ip=209.85.166.179; dkim=pass header.d=gmail.com header.s=20161025 header.a=rsa-sha256; dmarc=pass header.from=gmail.com; arc=none Received: from mail-il1-f179.google.com ([209.85.166.179]:39835) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) id 1l53nO-0003q9-Tw; Thu, 28 Jan 2021 09:41:00 +0000 Received: by mail-il1-f179.google.com with SMTP id d6so4637577ilo.6 for ; Thu, 28 Jan 2021 01:40:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Hv21MK55gWh/YhU9m4MSxyttZ6b0TJfuAh2G9T+WciE=; b=FfdN9CX73+ovkoGU8y45tYfi/52rlhwDlQhIsIU8268DsHrtvWeF5KuMH1n9rRdvxx 1yxnoC5/TDlC9j53uMRVA0n2CccZcO/obJn4ONjh0lgSzGOISDa8Rk3cmqGPYG1L4BIb 9fu/zQxUv7G+wlmWw7SUV3cM5oDMJjacv3z2ePh1vKLfXxRbAh/4ROn911rtkbtnbYlC X/9TFbPCEajnwJSWuDBsjXpYUGDhHCgYzKy0Y7ScmfLVDCiuSdzDk5emqc3HHv7/6zIx pGZ2VIxRzWQe+Q1pcPdgC0kQAfyP4pQFBtXLrXiu+g/fPHJzjXaumkTjnkaFHHnKHWER vrdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Hv21MK55gWh/YhU9m4MSxyttZ6b0TJfuAh2G9T+WciE=; b=BvoyiB1PgcsklTi/6GOj0VzUJF6TtMAX3Z3xsCocWetV+GVeNp7tdlufDTbLTxPTnW mC/3WBKX039lL55S1aSohLtsp88EYJUNtUsrUGaqRX7nCgRftj0vbTrlCmaKVXnS28u0 hw5fp0zeHiZddJS+Wab/d+hQFdpYQ9PqCGoX5AngLuhLiLamYYce2ARLB4gVoC48e4GG bdBZ9z6K+BIwVC01/Z4DwBZ8YZVU2/XdurJN8spYRVFMl5v8N6XSGNQizS1U1j4c/Sft 19QHkcGESJJdzTT9XZdwt/vitxwgjDR9lBCTX7xMd6K+3i7DzMe8kd6gibpybawQz2Y9 mZUQ== X-Gm-Message-State: AOAM532w10Z4P2Zoxw5g9orH/fbZHvFwSE1tt/5usvpADwYS5Btl5r7k NRvUn3k9aGcFGSTwDHi83rITl7jJJ4qcyO/EFaw+P/rDqFI= X-Google-Smtp-Source: ABdhPJye8kO8gP6tiTMyd09qytH4cr6NtLV7D7u23tqEyaD98a63PtfLAUds7PolzEMGC2CG/OMoDtqNg0F2WR+HK3E= X-Received: by 2002:a92:c7b0:: with SMTP id f16mr5146523ilk.162.1611826857643; Thu, 28 Jan 2021 01:40:57 -0800 (PST) MIME-Version: 1.0 References: <20210126233738.GB25751@tarpaulin.shahaf.local2> In-Reply-To: <20210126233738.GB25751@tarpaulin.shahaf.local2> From: Jacob Menke Date: Thu, 28 Jan 2021 04:40:46 -0500 Message-ID: Subject: Re: Possible issue with Completion/Unix/Type/_date_formats return value To: Daniel Shahaf Cc: zsh-workers@zsh.org Content-Type: multipart/mixed; boundary="0000000000004a2faf05b9f2afa3" X-Seq: 47884 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: Archived-At: --0000000000004a2faf05b9f2afa3 Content-Type: multipart/alternative; boundary="0000000000004a2fac05b9f2afa1" --0000000000004a2fac05b9f2afa1 Content-Type: text/plain; charset="UTF-8" Sure, Patch is attached and here: diff --git a/Completion/Unix/Type/_date_formats b/Completion/Unix/Type/_date_formats index 889a9577..226e1ef7 100644 --- a/Completion/Unix/Type/_date_formats +++ b/Completion/Unix/Type/_date_formats @@ -1,6 +1,6 @@ #autoload -local flag +local flag ret=1 local -aU specs local -A exclusion @@ -106,5 +106,6 @@ for flag in ${(s..)PREFIX#%}; do done _describe -t date-format-specifier 'date format specifier' specs \ - -p "${(Q)PREFIX:-%}" -S '' + -p "${(Q)PREFIX:-%}" -S '' && ret=0 [[ $1 == zsh ]] && _message -e date-format-precision 'precision for %%. (1-9)' +return ret On Tue, 26 Jan 2021 at 18:37, Daniel Shahaf wrote: > Jacob Menke wrote on Wed, Jan 20, 2021 at 17:43:31 -0500: > > Hello, > > > > I was wondering if _date_formats has an improper return value. > > > > When called from _date (when $1 is unset, thus $1 == zsh is > > false) _date_formats always returns 1 even when matches are generated > from > > _describe. This causes completion to continue erroneously. > > > > Last two lines are shown: > > _describe -t date-format-specifier 'date format specifier' specs > > -p "${(Q)PREFIX:-%}" -S '' > > [[ $1 == zsh ]] && _message -e date-format-precision 'precision for > %%.(1-9)' > > > > I believe the return value of _describe should be returned either by > making > > _describe last statement or storing its value in local var ret and then > > returning ret. > > Thanks for the report and sorry for the late answer. I agree that it's > wrong > as it stands. Anyone wants to take it from here? > --0000000000004a2fac05b9f2afa1 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Sure,

Patch is attached and here:
= 
diff --git a/Comp=
letion/Unix/Type/_date_formats b/Completion/Unix/Type/_date_formats
index 889a9577..226e1ef7 100644
--- a/Completion/Unix/Type/_date_formats
+++ b/Completion/Unix/Type/_date_formats
@@ -1,6 +1,6 @@
 #autoload
=20
-local flag
+local flag ret=3D1
 local -aU specs
 local -A exclusion
=20
@@ -106,5 +106,6 @@ for flag in ${(s..)PREFIX#%}; do
 done
=20
 _describe -t date-format-specifier 'date format specifier' specs \
-    -p "${(Q)PREFIX:-%}" -S ''
+    -p "${(Q)PREFIX:-%}" -S '' && ret=3D0
 [[ $1 =3D=3D zsh ]] && _message -e date-format-precision 'prec=
ision for %%. (1-9)'
+return ret

On Tue, 26 Jan 2021 at 18:37, Daniel Shahaf <d.s@daniel.shahaf.name> wrote:=
Jacob Menke wro= te on Wed, Jan 20, 2021 at 17:43:31 -0500:
> Hello,
>
> I was wondering if _date_formats has an improper return value.
>
> When called from _date (when $1 is unset, thus $1 =3D=3D zsh is
> false) _date_formats always returns 1 even when matches are generated = from
> _describe.=C2=A0 This causes completion to continue erroneously.
>
> Last two lines are shown:
> _describe -t date-format-specifier 'date format specifier' spe= cs
>=C2=A0 =C2=A0 =C2=A0-p "${(Q)PREFIX:-%}" -S ''
> [[ $1 =3D=3D zsh ]] && _message -e date-format-precision '= precision for %%.(1-9)'
>
> I believe the return value of _describe should be returned either by m= aking
> _describe last statement or storing its value in local var ret and the= n
> returning ret.

Thanks for the report and sorry for the late answer.=C2=A0 I agree that it&= #39;s wrong
as it stands.=C2=A0 Anyone wants to take it from here?
--0000000000004a2fac05b9f2afa1-- --0000000000004a2faf05b9f2afa3 Content-Type: application/octet-stream; name="_date_format-ret.patch" Content-Disposition: attachment; filename="_date_format-ret.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kkgo0i0f0 ZGlmZiAtLWdpdCBhL0NvbXBsZXRpb24vVW5peC9UeXBlL19kYXRlX2Zvcm1hdHMgYi9Db21wbGV0 aW9uL1VuaXgvVHlwZS9fZGF0ZV9mb3JtYXRzCmluZGV4IDg4OWE5NTc3Li4yMjZlMWVmNyAxMDA2 NDQKLS0tIGEvQ29tcGxldGlvbi9Vbml4L1R5cGUvX2RhdGVfZm9ybWF0cworKysgYi9Db21wbGV0 aW9uL1VuaXgvVHlwZS9fZGF0ZV9mb3JtYXRzCkBAIC0xLDYgKzEsNiBAQAogI2F1dG9sb2FkCiAK LWxvY2FsIGZsYWcKK2xvY2FsIGZsYWcgcmV0PTEKIGxvY2FsIC1hVSBzcGVjcwogbG9jYWwgLUEg ZXhjbHVzaW9uCiAKQEAgLTEwNiw1ICsxMDYsNiBAQCBmb3IgZmxhZyBpbiAkeyhzLi4pUFJFRklY IyV9OyBkbwogZG9uZQogCiBfZGVzY3JpYmUgLXQgZGF0ZS1mb3JtYXQtc3BlY2lmaWVyICdkYXRl IGZvcm1hdCBzcGVjaWZpZXInIHNwZWNzIFwKLSAgICAtcCAiJHsoUSlQUkVGSVg6LSV9IiAtUyAn JworICAgIC1wICIkeyhRKVBSRUZJWDotJX0iIC1TICcnICYmIHJldD0wCiBbWyAkMSA9PSB6c2gg XV0gJiYgX21lc3NhZ2UgLWUgZGF0ZS1mb3JtYXQtcHJlY2lzaW9uICdwcmVjaXNpb24gZm9yICUl LiAoMS05KScKK3JldHVybiByZXQK --0000000000004a2faf05b9f2afa3--