From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2]) by inbox.vuxu.org (OpenSMTPD) with ESMTP id 10cdab2a for ; Tue, 12 Feb 2019 17:48:07 +0000 (UTC) Received: (qmail 13908 invoked by alias); 12 Feb 2019 17:47:50 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 44062 Received: (qmail 12768 invoked by uid 1010); 12 Feb 2019 17:47:50 -0000 X-Qmail-Scanner-Diagnostics: from mail-lf1-f41.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.100.2/25112. spamassassin: 3.4.2. Clear:RC:0(209.85.167.41):SA:0(-2.0/5.0):. Processed in 0.851313 secs); 12 Feb 2019 17:47:50 -0000 X-Envelope-From: debohman@gmail.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at _netblocks.google.com designates 209.85.167.41 as permitted sender) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=ewwGDcKq/vYFz0nJHU072nGO5y6kA+cc6mVB/X3o2Ks=; b=AksfBawK9Xgojm1iUKV8kBREfwvTEj+QfNLdS6EUwgt6eN+DEiglL3SgcaaalXnsvq fBIsPobrMZ9+C6Lw5I07WkXeSqq9PU8oodHQ3EZ50tR0POmzl5JpneNqsMTx7wwI2URU j8v3IX22Au1Zcwv7WaDVGaJipy/P+IMXGfwdeAEynsRNH/0yUGqJLcPihaVHwoOHtGZ5 3JNXq14gQNQrdDIBwHF3t0hkq2HZitlN+7GGanXaeZcaqMB0DWbIwpY2eGz6KDXtKLQm ltIpSPbe1oAWT4qPum46zSjZA2AnETHzwFoHlhU7K/YpIN+oIJq4hDTcKiZcfJxcC5cD HVIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=ewwGDcKq/vYFz0nJHU072nGO5y6kA+cc6mVB/X3o2Ks=; b=BozTZBLEDSqgFzd4qhx7/TZWclKXAifKzLBRCgOoAL+Kz8na6eGIVnkMgHPkF+3lYk tllqjipMZmi6eAEBd3gBOJu6L2me4TyWWzZnDysYPNzPXo1t6ub9HXfk29qCiA4/xT2e gaw9Xx2qq+v+lwPVBneWKVVfuJZz75CwzNQzJ/ZaM7zIrSXB5DA9iavCnDezge1zdT4V lYnK9PeLbkpqmiUMQU8KvvxYrkNZpkhJY7b9lHDTNf54w4Y3OJwFbqpxtdf9THh5u+mb GxjDCSo7xbmObdZwX/vd68ym9R/4ozlIXPrDKMrnCvc6wO1lB4poIPPzZK0C5eOQVyS9 UTOg== X-Gm-Message-State: AHQUAuYfmnOs6rltcbnYAa1ZUUgJdO8ZkKwjReDbLVzKd0SxENRbgYtB GFgurT3/mmpm+d9SeqwO1lApF3IJdRP/bMeRF4BVlHn9 X-Google-Smtp-Source: AHgI3IYsAmrqNVeFhDuf2y/OAcybLYxB9Zf4O2feMcHkcpaQg+OxmrLeEH9bjDvS4R+KJWnjUH75kzdDUpXUWXM4brQ= X-Received: by 2002:ac2:5611:: with SMTP id v17mr3175653lfd.134.1549993634607; Tue, 12 Feb 2019 09:47:14 -0800 (PST) MIME-Version: 1.0 From: David Bohman Date: Tue, 12 Feb 2019 09:47:03 -0800 Message-ID: Subject: Ignoreeof warning message regression To: zsh-workers@zsh.org Content-Type: multipart/alternative; boundary="000000000000febc920581b60353" --000000000000febc920581b60353 Content-Type: text/plain; charset="UTF-8" This is an old regression, which apparently occurred between release 5.3.1 and 5.4 of zsh. If you have the ignoreeof option set, and type a CTL-D to the shell, you are supposed to get a warning message: zsh: use 'exit' to exit. Instead, a blank line is emitted. This was introduced by commit 34656ec2f00d6669cef56afdbffdd90639d7b465, specifically the change to Src/Zle/zle_main.c. The problem occurs both on Ubuntu 18.04.1 running zsh 5.4.2 and macOS 10.12.6 running 5.4 forwards to 5.7.1. Stock macOS 10.12.6 contains zsh 5.2 and does not manifest the bug. The problem disappears when the change to Src/Zle/zle_main.c is backed out. index 3487b5d9f..71930f76b 100644 --- a/Src/Zle/zle_main.c +++ b/Src/Zle/zle_main.c @@ -1256,7 +1256,6 @@ zleread(char **lp, char **rp, int flags, int context, char *init, char *finish) resetneeded = 0; fetchttyinfo = 0; trashedzle = 0; - clearflag = 0; raw_lp = lp; lpromptbuf = promptexpand(lp ? *lp : NULL, 1, NULL, NULL, &pmpt_attr); raw_rp = rp; I am aware that backing this out may break other things, but perhaps it might give a hint to someone who is familiar with this area of the code. Thanks. --000000000000febc920581b60353--