Re: Fwd: 5.8: LTO exposes some new issues

["Tomasz Kłoczko" <kloczko.tomasz@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1645 bytes --]

On Mon, 27 Jul 2020 at 13:20, Roman Perepelitsa <roman.perepelitsa@gmail.com>
wrote:

> On Mon, Jul 27, 2020 at 1:09 PM Roman Perepelitsa
> <roman.perepelitsa@gmail.com> wrote:
> > A patch is attached.
>
> Here's a cleaned up patch (HASHTABLE_DEBUG_MEMBERS is inlined).
>

Thank you very much for the patch.
All warnings about mismatching declarations gone however still one other
warning remains.
Here is whole list of compile and linking warnings:

exec.c: In function 'execcmd_fork':
exec.c:2774:2: warning: ignoring return value of 'nice' declared with
attribute 'warn_unused_result' [-Wunused-result]
 2774 |  nice(5);
      |  ^~~~~~~
utils.c: In function 'getkeystring':
lto1: warning: function may return address of local variable
[-Wreturn-local-addr]
utils.c:6644:16: note: declared here
 6644 |     char *buf, tmp[1];
      |                ^
/usr/bin/ld: zsh.lto.o: in function `gettempname':
/home/tkloczko/rpmbuild/BUILD/zsh-5.8/Src/utils.c:2226: warning: the use of
`mktemp' is dangerous, better use `mkstemp' or `mkdtemp'
utils.c: In function 'getkeystring':
lto1: warning: function may return address of local variable
[-Wreturn-local-addr]
utils.c:6644:16: note: declared here
 6644 |     char *buf, tmp[1];
      |                ^
/usr/bin/ld: zsh.lto.o: in function `gettempname':
/home/tkloczko/rpmbuild/BUILD/zsh-5.8/Src/utils.c:2226: warning: the use of
`mktemp' is dangerous, better use `mkstemp' or `mkdtemp'


Other topic: do you have any plans to move to pcre2? :P

One more time: thank you for you time :)

kloczek
-- 
Tomasz Kłoczko | LinkedIn: http://lnkd.in/FXPWxH