From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=DKIM_ADSP_CUSTOM_MED, FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 23327 invoked from network); 27 Jul 2020 12:47:59 -0000 Received: from ns1.primenet.com.au (HELO primenet.com.au) (203.24.36.2) by inbox.vuxu.org with ESMTPUTF8; 27 Jul 2020 12:47:59 -0000 Received: (qmail 1818 invoked by alias); 27 Jul 2020 12:47:53 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: Sender: zsh-workers@zsh.org X-Seq: 46267 Received: (qmail 4474 invoked by uid 1010); 27 Jul 2020 12:47:53 -0000 X-Qmail-Scanner-Diagnostics: from mail-vk1-f172.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.102.3/25884. spamassassin: 3.4.4. Clear:RC:0(209.85.221.172):SA:0(-2.0/5.0):. Processed in 0.74589 secs); 27 Jul 2020 12:47:53 -0000 X-Envelope-From: kloczko.tomasz@gmail.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at _netblocks.google.com designates 209.85.221.172 as permitted sender) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TzcwVQ5iFNkvPwFL+2YBKpbA4LTe1hvjvmuAe19Ys2c=; b=QvEPHmlDwOadTxl6p+ZQttXkb7PY8SOAM+mfxl6ujZu95TnxG3dlyJkqVO4VzO2ONM xdg7d52SND+Js2XFm/U8qEowiRp7g7aNzESwH1xJXQZ2eCSHEtp2qHdTT3LtozFQXLJM lPhLvkilTZY5h6QAnF7i5ZRYpS+jx+sh8GXEqgucUKwWYQq1rM8e2mvVygTlA4XT+NGT bq335fP718iQ/EQsvWTuqU84h4wfSuJhsCVBkckz+qzn4GVtFmjKKtn4o8LrDKylTPcB So/2t7qMNGsRZXTcodlvIuGh2uizWkXtKj2BRoennZ3WhrU7LXj8lETX8vAxhyhbvB+L vuLQ== X-Gm-Message-State: AOAM5312P5MpeVBHuhR6Zy9zPfJMzbO2A81HY0Ui3hdUMYgsxhKe9pSf hUGpEvby2sV6B4XkwcW/58v6aCn7L3I/fuCeTto= X-Google-Smtp-Source: ABdhPJyGX9qMHt02c99xY3IhxBWaIoYnp078efN6t3NpvyH32tHHKJwX0Bd0OfyfN9HbQCtSlYa8VrK1XWUFLsTiXws= X-Received: by 2002:a05:6122:1dc:: with SMTP id h28mr16085698vko.67.1595854038996; Mon, 27 Jul 2020 05:47:18 -0700 (PDT) MIME-Version: 1.0 References: <35bf1c7b-163f-4baf-9d5a-c1d7e72459ec@www.fastmail.com> In-Reply-To: From: =?UTF-8?Q?Tomasz_K=C5=82oczko?= Date: Mon, 27 Jul 2020 13:46:53 +0100 Message-ID: Subject: Re: Fwd: 5.8: LTO exposes some new issues To: Roman Perepelitsa Cc: Daniel Shahaf , Zsh hackers list Content-Type: multipart/alternative; boundary="0000000000001b98b505ab6bb9a0" --0000000000001b98b505ab6bb9a0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, 27 Jul 2020 at 13:20, Roman Perepelitsa wrote: > On Mon, Jul 27, 2020 at 1:09 PM Roman Perepelitsa > wrote: > > A patch is attached. > > Here's a cleaned up patch (HASHTABLE_DEBUG_MEMBERS is inlined). > Thank you very much for the patch. All warnings about mismatching declarations gone however still one other warning remains. Here is whole list of compile and linking warnings: exec.c: In function 'execcmd_fork': exec.c:2774:2: warning: ignoring return value of 'nice' declared with attribute 'warn_unused_result' [-Wunused-result] 2774 | nice(5); | ^~~~~~~ utils.c: In function 'getkeystring': lto1: warning: function may return address of local variable [-Wreturn-local-addr] utils.c:6644:16: note: declared here 6644 | char *buf, tmp[1]; | ^ /usr/bin/ld: zsh.lto.o: in function `gettempname': /home/tkloczko/rpmbuild/BUILD/zsh-5.8/Src/utils.c:2226: warning: the use of `mktemp' is dangerous, better use `mkstemp' or `mkdtemp' utils.c: In function 'getkeystring': lto1: warning: function may return address of local variable [-Wreturn-local-addr] utils.c:6644:16: note: declared here 6644 | char *buf, tmp[1]; | ^ /usr/bin/ld: zsh.lto.o: in function `gettempname': /home/tkloczko/rpmbuild/BUILD/zsh-5.8/Src/utils.c:2226: warning: the use of `mktemp' is dangerous, better use `mkstemp' or `mkdtemp' Other topic: do you have any plans to move to pcre2? :P One more time: thank you for you time :) kloczek --=20 Tomasz K=C5=82oczko | LinkedIn: http://lnkd.in/FXPWxH --0000000000001b98b505ab6bb9a0--