From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-30375-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 4307 invoked by alias); 24 Mar 2012 22:09:56 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 30375
Received: (qmail 27188 invoked from network); 24 Mar 2012 22:09:44 -0000
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-1.6 required=5.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED,
	DKIM_SIGNED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED,RCVD_IN_DNSWL_LOW,
	T_DKIM_INVALID,T_TO_NO_BRKTS_FREEMAIL autolearn=no version=3.3.2
Received-SPF: pass (ns1.primenet.com.au: SPF record at _spf.google.com designates 209.85.213.43 as permitted sender)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type;
        bh=4zACRzirG0WuYvuCVUGFzgNJj+vjXji19zGlzcK4erE=;
        b=Ff0oGQR49eqGxnbRH5B9OyZTUQunxZY6r2jAVkaKxkbLri3hfxIyeOU8rHukeSeRJ2
         B0jg1Y+OGJ0O9R+/GCEgbl3q8xcfI8gefZtYqHraAamc5dUZMKdqxYTmg9HU/ahH/c+B
         ccybmN9rD/KV+RCwCxWh2i1qVAVP4Pag5K24Fb8T6Uw6zub/VDFMusiIGq4uDggOSYDF
         +7RpDcPU8MyjQgBQ2XU8mwk17IIQlxGIXWJXePJ7lb39RW+eMdpkFPJFh70mOf5KOvPQ
         GYWhElF1xM02O9iDdWWzIVfTWuYYqaSNJC8LGkdfTBut49bW11Cl94rOirxGqaltXoan
         ZLQQ==
MIME-Version: 1.0
In-Reply-To: <CABZhJg9xgaM7mr4dy8GYKHopAofnVRCzZmxfOsEca1VNugv6Cw@mail.gmail.com>
References: <CABZhJg_V5objd2LHhvpGbukBsgNoau_2tTYcn+UOgWh3pAEmjg@mail.gmail.com>
	<CAHYJk3SbDQWZF2cNBhOzmqXeRLzNXFL05N-192kWuvy09HQG-g@mail.gmail.com>
	<CABZhJg__v4hN_9D+KCdwrBA0E06UB2C2w2grtdLw=c=zxkuhiw@mail.gmail.com>
	<CAHYJk3TL73yjCpJ7ArH81J9nN3r=TVCXknX9prtcaRrzAXA2og@mail.gmail.com>
	<CABZhJg9xgaM7mr4dy8GYKHopAofnVRCzZmxfOsEca1VNugv6Cw@mail.gmail.com>
Date: Sat, 24 Mar 2012 23:04:34 +0100
Message-ID: <CABZhJg84WXDBPC61Z8e8aZUCHS7ixyYexkwwSXwHjN6i0Luvfw@mail.gmail.com>
Subject: Re: [PATCH] Add _gradle for gradle and gradlew completion.
From: =?ISO-8859-1?Q?Jesper_Nyg=E5rds?= <jesper.nygards@gmail.com>
To: zsh-workers@zsh.org
Content-Type: text/plain; charset=ISO-8859-1

2012/3/24 Mikael Magnusson <mikachu@gmail.com>:
> You're defining a single function with the same name as the autoloaded
> function, and then calling it, that serves no purpose so you can just
> remove that indirection.

Good call. I'll just remove it.

> You could move the _gradle_caching_policy to
> the toplevel and then this pattern would make sense. (There's no
> namespaces for functions, so even though you define it inside _gradle
> now, it stays around after _gradle returns.)

I did know that functions are global, but I must define the function
where I do, because I can only set it once I know what build file is
to be parsed, i.e. the $build_file is a local variable, but the
_gradle_caching_policy needs to know its value. In some other
languages, I would call this a closure.

> zstyle -T ":completion:*:*:$service:*" gradle-inspect || gradle_inspect=no
> can probably be
> zstyle -b ":completion:*:*:$service:*" gradle-inspect gradle_inspect
> but I didn't test. :)

Unless I misunderstand something, this doesn't seem to work as I'd
like it to. It works if the style is set, but I want the
gradle_inspect variable to default to be true if the gradle-inspect
style is unset, and this doesn't seem to happen with your suggestion.

> You need to quote the ? in -?,-h,--help. (The completion system sets
> the nullglob option, so the whole argument just disappears without
> errors).

Thanks, I had overlooked that one.

> Other than that it looks pretty good to me.

Great. I'll submit a new patch tomorrow, unless I have any other
errors pointed out by you or someone else.