From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=FREEMAIL_FROM, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 13258 invoked from network); 8 Jul 2020 18:25:04 -0000 Received: from ns1.primenet.com.au (HELO primenet.com.au) (203.24.36.2) by inbox.vuxu.org with ESMTPUTF8; 8 Jul 2020 18:25:04 -0000 Received: (qmail 25440 invoked by alias); 8 Jul 2020 18:24:53 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: Sender: zsh-workers@zsh.org X-Seq: 46219 Received: (qmail 20835 invoked by uid 1010); 8 Jul 2020 18:24:53 -0000 X-Qmail-Scanner-Diagnostics: from mail-ot1-f54.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.102.3/25863. spamassassin: 3.4.4. Clear:RC:0(209.85.210.54):SA:0(-1.6/5.0):. Processed in 3.362383 secs); 08 Jul 2020 18:24:53 -0000 X-Envelope-From: ethersoft@gmail.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at _netblocks.google.com designates 209.85.210.54 as permitted sender) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=iZf8SwhL0qtf57oSMXmWuahCytO3LfpbLybzg49kQ/A=; b=ReY3ME1i8kZ7EgGYSrnxrM7d82/j5Gh38GgTlDh5pjvhH4jH6b6evoTwaqlgF5gFaS LSfSUfJUHxFqaHsK7+cv6jl+Y/dndVF8sbtoAh23Pt4FMGKqCo0QLpFtb8tIOaxHuzyz 9dSaYSSXm6MXUZ/gLXmJOZ9AwcDeockwN6IysvBGSmMDKj68hVVlCxFvhgNlp5SmoWXG OPCluJ00AAylr8Mi6WoJqV+0aYWv+DiwRVWTe0BzDEFZKDBPZ65UfO7fMx8c5L2RhpK5 uaB80GYo/uSUQW9ZTKR7fQEsuB3PaJNfiXEUmrB0+PcvkrynTY6sTZzPHxM0tUkj3fwE lXXA== X-Gm-Message-State: AOAM533gujs8JjZP+Bo4FporaafxkVI7CHhwjqPs2C8Gz96jpUurPkB+ 8nU8CdUIO2AqFo07hC62KPWWdWYmifLGBNMfI1I= X-Google-Smtp-Source: ABdhPJxL1yxs4WbLDUC5Zs+uyYOCDqNu80532kiiiCLeBQvBPZYUVvP+Jg5SyRzKPzxZbKPzH129T9aWdjoUI+J31zc= X-Received: by 2002:a9d:d57:: with SMTP id 81mr49882759oti.184.1594232654425; Wed, 08 Jul 2020 11:24:14 -0700 (PDT) MIME-Version: 1.0 References: <00445BFC-A800-49B6-A4FD-B1F294764245@kba.biglobe.ne.jp> In-Reply-To: From: Vin Shelton Date: Wed, 8 Jul 2020 14:23:38 -0400 Message-ID: Subject: Re: Five New Test Failures To: Jun T Cc: "Zsh Hackers' List" Content-Type: multipart/alternative; boundary="0000000000000e748905a9f23750" --0000000000000e748905a9f23750 Content-Type: text/plain; charset="UTF-8" Yes, that worked. BTW, I have no idea how my PS1 gets set to %m (I checked), but this compares OK. Thanks, Vin On Wed, Jul 8, 2020 at 6:50 AM Jun T wrote: > > Sorry, please forget the previous patch. > I noticed that we should better to start the subshell without zle, > i.e., with option +Z. Then the command 'rm *' is not echoed back. > > > 2020/07/08 9:25, I wrote: > > > > There is no prompt problem here, but the 'n' sent by the test is > > echoed back and causes the failure. > > But I still get this 'n' on Fedora32 (maybe also on Ubuntu20.04). > I don't know why. It doesn't happen on CentOS8. > It seems we need '(|n)' at the end of the pattern. > > In the patch below, I explicitly set PS1 and wait for the prompt. > > Do we need to set MODULE_PATH in the subshell? > I guess we don't since no module is used in this test? > > diff --git a/Test/E01options.ztst b/Test/E01options.ztst > index c59509f2e..5a1c8ebcf 100644 > --- a/Test/E01options.ztst > +++ b/Test/E01options.ztst > @@ -1432,12 +1432,13 @@ F:If this test fails at the first unsetopt, refer > to P01privileged.ztst. > '/' '/*' > do > before=`ls -a -- $target_dir` > - zpty subshell $ZTST_testdir/../Src/zsh -f > + zpty subshell $ZTST_testdir/../Src/zsh -f +Z > [[ $PWD == */options.tmp ]] || return 1 # Sanity check before > calling rm(1). > + zpty -w subshell 'PS1=PROMPT' > + zpty -r -m subshell REPLY $'*PROMPT' > zpty -w subshell "rm $target_pattern" > - zpty -w subshell 'n' > + zpty -w -n subshell 'n' > sleep 1 > - zpty -rt subshell REPLY # "${PS1} rm *" > zpty -rt subshell REPLY && print -r -- ${REPLY%%$'\r\n'} > zpty -d subshell > after=`ls -a -- $target_dir` > @@ -1448,5 +1449,5 @@ F:If this test fails at the first unsetopt, refer to > P01privileged.ztst. > fi > BEL=$'\a' > 0q:RM_STAR_SILENT > -*>zsh: sure you want to delete all 15 files in ${PWD:h}/options.tmp > \[yn\]\? ${BEL} > -*>zsh: sure you want to delete all <-> files in / \[yn\]\? ${BEL} > +*>zsh: sure you want to delete all 15 files in ${PWD:h}/options.tmp > \[yn\]\? ${BEL}(|n) > +*>zsh: sure you want to delete all <-> files in / \[yn\]\? ${BEL}(|n) > > > > --0000000000000e748905a9f23750--