From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=0.3 required=5.0 tests=FREEMAIL_FROM, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RDNS_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.2 Received: (qmail 15144 invoked from network); 26 Mar 2020 12:24:58 -0000 Received-SPF: pass (primenet.com.au: domain of zsh.org designates 203.24.36.2 as permitted sender) receiver=inbox.vuxu.org; client-ip=203.24.36.2 envelope-from= Received: from unknown (HELO primenet.com.au) (203.24.36.2) by inbox.vuxu.org with ESMTP; 26 Mar 2020 12:24:58 -0000 Received: (qmail 15609 invoked by alias); 26 Mar 2020 12:24:46 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 45633 Received: (qmail 23712 invoked by uid 1010); 26 Mar 2020 12:24:46 -0000 X-Qmail-Scanner-Diagnostics: from mail-oi1-f175.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.102.2/25758. spamassassin: 3.4.2. Clear:RC:0(209.85.167.175):SA:0(-1.6/5.0):. Processed in 1.84202 secs); 26 Mar 2020 12:24:46 -0000 X-Envelope-From: ethersoft@gmail.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at _netblocks.google.com designates 209.85.167.175 as permitted sender) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=8SGD2iOpKoDcp3ykwO8qQKN9eH5hjp3sw8zt4036ba0=; b=ZyKsMMJ2WFsQzxEIzwQp/r2DRy6DNu0dGrAGJlaD3iYxWbO4PWNstdS8Gg0FLBQcmm R3WhlS1/Ke8NahTkwiu2rszK6dexQLyJ2yJr/3aY8osQiJgjsMpy2ZzSq0U306LrMXqR Kumi8t+m8BQyvof34YgSS6qfQCNVUxg7MtnedBrQPDYTcmR2awzN60phmGg4mFIE1ftM CkBwvYFepyiySZf8jWLtVPkWqfTuKwLjGjaSWOoQMvcTIyIJ3JEi2nhZMzCOgfM2Tk8c 30/KwOvBKfLqn+8UigHrRsb5kPNIVCrLr3HQriO6TwAGaIXrf17nrzPPM2zzVOimbNfX NY4A== X-Gm-Message-State: ANhLgQ0JIE5urt63JmdopTT2ksr2ikdo5aqr/XVKr6JAjiVbCqDbSs9w OX0PGBG6jWOyjC1ngaNFxeSx056v+lOg8iIIj06aTfBbGHM= X-Google-Smtp-Source: ADFU+vvVqXWN6h3gG6WfCXKkF0VxzGA0V7POF4+Vzs9rfnewvbu4pjhngdwah/nunzE1b7bvcQjexOTRj2aiYe3t6tY= X-Received: by 2002:aca:bd46:: with SMTP id n67mr1465905oif.120.1585225450865; Thu, 26 Mar 2020 05:24:10 -0700 (PDT) MIME-Version: 1.0 From: Vin Shelton Date: Thu, 26 Mar 2020 08:22:23 -0400 Message-ID: Subject: pwd -r vs. pwd test failure To: "Zsh Hackers' List" Content-Type: multipart/alternative; boundary="000000000000e3463605a1c10fbb" --000000000000e3463605a1c10fbb Content-Type: text/plain; charset="UTF-8" I got a test failure in B13 today: Running test: whence symlink resolution ZTST_test: expecting status: 0 Input: /tmp/zsh.ztst.360386/ztst.in, output: /tmp/zsh.ztst.360386/ztst.out, error: /tmp/zsh.ztst.360386/ztst.terr ZTST_execchunk: status 0 ZTST_test: test produced standard output: /opt/build/zsh-2020-03-26/Test/whence.tmp/step1 -> /SSD-2/opt/build/zsh-2020-03-26/Test/whence.tmp/step1 -> /SSD-2/opt/ build/zsh-2020-03-26/Test/whence.tmp/step2 -> /SSD-2/opt/build/zsh-2020-03-26/Test/whence.tmp/step3 -> /SSD-2/opt/build /zsh-2020-03-26/Test/whence.tmp/real /opt/build/zsh-2020-03-26/Test/whence.tmp/step1 -> /SSD-2/opt/build/zsh-2020-03-26/Test/whence.tmp/real ZTST_test: and standard error: --- /tmp/zsh.ztst.360386/ztst.out 2020-03-26 08:04:38.543366746 -0400 +++ /tmp/zsh.ztst.360386/ztst.tout 2020-03-26 08:04:38.543366746 -0400 @@ -1,2 +1,2 @@ -/opt/build/zsh-2020-03-26/Test/whence.tmp/step1 -> /opt/build/zsh-2020-03-26/Test/whence.tmp/step2 -> /opt/build/zsh-2020-03-26/Test/whence.tmp/step3 -> /opt/build/zsh-2020-03-26/Test/whence.tmp/real -/opt/build/zsh-2020-03-26/Test/whence.tmp/step1 -> /opt/build/zsh-2020-03-26/Test/whence.tmp/real +/opt/build/zsh-2020-03-26/Test/whence.tmp/step1 -> /SSD-2/opt/build/zsh-2020-03-26/Test/whence.tmp/step1 -> /SSD-2/opt/build/zsh-2020-03-26/Test/whence.tmp/step2 -> /SSD-2/opt/build/zsh-2020-03-26/Test/whence.tmp/step3 -> /SSD-2/opt/build/zsh-2020-03-26/Test/whence.tmp/real +/opt/build/zsh-2020-03-26/Test/whence.tmp/step1 -> /SSD-2/opt/build/zsh-2020-03-26/Test/whence.tmp/real Test ../../../src/zsh-2020-03-26/Test/B13whence.ztst failed: output differs from expected as shown above for: ( path=( $PWD/whence.tmp $path ) whence -S step1 whence -s step1 ) Was testing: whence symlink resolution ../../../src/zsh-2020-03-26/Test/B13whence.ztst: test failed. Looking at the diff, I realized that my build directory is under a symlink; /opt -> /SSD-2/opt. The test uses $PWD, which resolves to /opt/build/zsh-2020-03-26, but pwd -r correct identifies the path as /SSD-2/opt/build/zsh-2020-03-26; sure enough, if I run the test from /SSD-2/opt/build/zsh-2020-03-26, the test passes. Is the right thing to fix the test, or should $PWD track realpath? - Vin --000000000000e3463605a1c10fbb--