From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5763 invoked by alias); 19 Apr 2018 13:51:58 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 42688 Received: (qmail 17605 invoked by uid 1010); 19 Apr 2018 13:51:58 -0000 X-Qmail-Scanner-Diagnostics: from mail-ot0-f170.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(74.125.82.170):SA:0(-1.4/5.0):. Processed in 15.030836 secs); 19 Apr 2018 13:51:58 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, HTML_MESSAGE,T_DKIM_INVALID,T_SPF_TEMPERROR autolearn=no autolearn_force=no version=3.4.1 X-Envelope-From: ethersoft@gmail.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=VT+2+svFSIGzOs49Z4JZ7WbNt+1V02qYdtazDLXXrG8=; b=PLrED00TEW9M7Nru/cH/5A3w9Ou5gJgINWp5foQwFTf/8cB9UZhAISy8JadWMcXjII 5aHwNxTozYy3pU5cckWom5OadxHI8bvl0xKiGpo9hVrgqpakX6lh1d6NMYg+j6qSIFgi laH3XOxkNmlyhq3tB+/JvG4PP2yJG3aG1Ip6hPttEW0CWyG3ZU3uladj37fgVARThGSQ 4T3LdodSVvttRHIEMhN+YEkvgjgqW4zv88AimSR5uQEEO4DqOCHUJVAK3U3uF040pXuL FeKK7Igt8FJi0fUcMDPMSL+gbvZRgDFhupegeXBqSm9XwAjn8KXbmZoC3WHG0Pa21O1I z4Ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=VT+2+svFSIGzOs49Z4JZ7WbNt+1V02qYdtazDLXXrG8=; b=RX+gdFDXCY1RrclESg1YSesdMsGKc7ZPUle9P7Xswq3pAPm82OIfh98fYAA3xhwIne nPu4o6Yp8+YTaEORFHWwQqtiBhgylBWWD2JU+6w+QKnLhkf/cSawpvYg6jPjV2f3c14d IeAB9MMW22L87OdmInrCX3HFlJyAJOvMEFuO+MP+T6YF6GGfi+0PudBBxRTgEmyDe8M8 lc/6rhhIOrtE97YkbyK7nyzZGWUGn7XTbQm588y7zTDfa6Muond2LGymzCicef4xvTq2 IDyqXTWyg2q7aF6yoduQRoZ97Q9FcomaIq9fZjK5wEdNe0JVqAHshLWcweTjG5JrM4Sk N6rQ== X-Gm-Message-State: ALQs6tBFO1VQWQDhulzghD955aFihwRYRgSvLnPPW1zS0SC9eXEo6Zav X6YnoMw+IzFx0Wjf62DKygdOjNZ2HhWMO0kNiJ8= X-Google-Smtp-Source: AIpwx4+hWtMU62MJcQ1YXVVSquFmZGkuWRB5Mh/e5bWBkkeFjkoq6zNJRfKQrqvGeOhfiveRvrcUJI2aCJo88XhSVfg= X-Received: by 2002:a9d:5154:: with SMTP id u20-v6mr4198812oti.388.1524145900142; Thu, 19 Apr 2018 06:51:40 -0700 (PDT) MIME-Version: 1.0 Sender: ethersoft@gmail.com In-Reply-To: <20180419123339.3f897060@camnpupstephen.cam.scsc.local> References: <20180419123339.3f897060@camnpupstephen.cam.scsc.local> From: Vin Shelton Date: Thu, 19 Apr 2018 09:51:39 -0400 X-Google-Sender-Auth: v1C9CUBNm2-CN-bNGCJTHom9P_U Message-ID: Subject: Re: can't set tty pgrp To: Peter Stephenson Cc: "Zsh Hackers' List" Content-Type: multipart/alternative; boundary="000000000000f6c561056a33decc" --000000000000f6c561056a33decc Content-Type: text/plain; charset="UTF-8" Seems to work. Thanks. I think this is serious enough to merit a 5.5.2 release. Thoughts? - Vin On Thu, Apr 19, 2018 at 7:33 AM, Peter Stephenson wrote: > On Thu, 19 Apr 2018 06:57:40 -0400 > Vin Shelton wrote: > > The process group changes seem to have broken something: > > > > > > : ~ Thu 19 6:52; vi > > ^Z > > zsh: suspended vi > > : ~ Thu 19 6:52; fg > > [1] + continued vi > > zsh: can't set tty pgrp: no such process > > Yep, I remember thinking about this and forgetting to do anything... > > The following looks like it ought to be safe. > > diff --git a/Src/signals.c b/Src/signals.c > index 2a6aa3f..6e12158 100644 > --- a/Src/signals.c > +++ b/Src/signals.c > @@ -537,7 +537,8 @@ wait_for_processes(void) > #else > update_process(pn, status); > #endif > - if (pn->pid == jn->gleader) { > + if (WIFEXITED(status) && > + pn->pid == jn->gleader) { > jn->gleader = 0; > if (!(jn->stat & STAT_NOSTTY)) { > /* > > > pws > --000000000000f6c561056a33decc--