From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=FREEMAIL_FROM, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 28044 invoked from network); 8 Jul 2020 01:04:36 -0000 Received: from ns1.primenet.com.au (HELO primenet.com.au) (203.24.36.2) by inbox.vuxu.org with ESMTPUTF8; 8 Jul 2020 01:04:36 -0000 Received: (qmail 12120 invoked by alias); 8 Jul 2020 01:04:26 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: Sender: zsh-workers@zsh.org X-Seq: 46212 Received: (qmail 29925 invoked by uid 1010); 8 Jul 2020 01:04:26 -0000 X-Qmail-Scanner-Diagnostics: from mail-oi1-f175.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.102.3/25863. spamassassin: 3.4.4. Clear:RC:0(209.85.167.175):SA:0(-1.6/5.0):. Processed in 1.189256 secs); 08 Jul 2020 01:04:26 -0000 X-Envelope-From: ethersoft@gmail.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at _netblocks.google.com designates 209.85.167.175 as permitted sender) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=su3ppifPavCt0hplryPo34X1uKaqWfQ0iGzN/24aRX0=; b=iIGo2cNAc60Lnl0ejv3VttNK4oNICeZLP1hfEM03+kOIywsmPNMx7VlG50tRHW8PlC FsxV22X72GZ0xpa1MgtqQkzUywW2o+TwLJrx3a6QzjPnee4JIpQ8zprW8zUrA70tcsfJ Pd06anwb2zYq5CHLDneSkucRF+5YAQuNztw8r5x6wcWd2tHKH3uOQRn+4MW7PhHSDDzJ xAmstJBBRZb0yCJlKHLPiC2XMRvD3HD/s+jVZ7yJJIMO8u5pL+zOtBuI5+w5IeeuDN4R BxRV55aKOfnuHCEKW1hzVMQP6wwaGjoIVG8vNtC2Pj3ZAhWvLrNRXo8MAEQV2xfNCNm2 KKew== X-Gm-Message-State: AOAM531hu/Cqk9FS4ITWPOJa4wVC4K1Ch9/C3ud/myibuOtAwhJqMuQC mEYcRN2N852EW0zksCWCQhscetCM8OqRp01naHI= X-Google-Smtp-Source: ABdhPJxfGO0YK1bHIWp9jn2adX+36JuM4xJDWFWMpVHzQVPwPjyF66KJaRmC6VbQWFHLQNX8ff1IEYSJD0Lw0oFjUmo= X-Received: by 2002:aca:d5d0:: with SMTP id m199mr5679853oig.176.1594170231590; Tue, 07 Jul 2020 18:03:51 -0700 (PDT) MIME-Version: 1.0 References: <00445BFC-A800-49B6-A4FD-B1F294764245@kba.biglobe.ne.jp> In-Reply-To: <00445BFC-A800-49B6-A4FD-B1F294764245@kba.biglobe.ne.jp> From: Vin Shelton Date: Tue, 7 Jul 2020 21:03:15 -0400 Message-ID: Subject: Re: Five New Test Failures To: Jun T Cc: "Zsh Hackers' List" Content-Type: multipart/alternative; boundary="0000000000005d953a05a9e3ae46" --0000000000005d953a05a9e3ae46 Content-Type: text/plain; charset="UTF-8" Jun - Thanks for asking. "nuc2" is the hostname of a Manjaro (arch-based) system. I assumed that got consumed by the leading * in the response. I'll try out your patch. - Vin On Tue, Jul 7, 2020 at 8:25 PM Jun T wrote: > > > 2020/07/07 23:14, Vin Shelton wrote: > > > > - > /opt/build/zsh-2020-07-07/Test/options.tmp \[yn\]\? > > files in / \[yn\]\? > > +>nuc2% zsh: sure you want to delete all 15 files in > > /opt/build/zsh-2020-07-07/Test/options.tmp [yn]? > > It seems the prompt 'nuc2% ' is not consumed by the line > zpty -rt subshell REPLY # "${PS1} rm *" > in the test. Which operating system are you using? > > On Fedora32 and Ubuntu20.04 and I got a different diff: > Pattern match failed, line 1: > - /home/takimoto/src/zsh/Test/options.tmp \[yn\]\? > files in / \[yn\]\? > +>zsh: sure you want to delete all 15 files in > /home/takimoto/src/zsh/Test/options.tmp [yn]? n > >zsh: sure you want to delete all 20 files in / [yn]? n > > There is no prompt problem here, but the 'n' sent by the test is > echoed back and causes the failure. > > On macOS, the diff is: > Pattern match failed, line mismatch (2/1): > /Users/takimoto/dev/src/zsh/zsh/Test/options.tmp \[yn\]\? > files in / \[yn\]\? > > > > In this case virtually no response from the zpty. > > > The following patch seems to work on the above three systems, > but there is a possibility that it fails with very low probability. > I haven't tested on other OSs. > > > diff --git a/Test/E01options.ztst b/Test/E01options.ztst > index c59509f2e..d8b3d7d21 100644 > --- a/Test/E01options.ztst > +++ b/Test/E01options.ztst > @@ -1435,9 +1435,9 @@ F:If this test fails at the first unsetopt, refer to > P01privileged.ztst. > zpty subshell $ZTST_testdir/../Src/zsh -f > [[ $PWD == */options.tmp ]] || return 1 # Sanity check before > calling rm(1). > zpty -w subshell "rm $target_pattern" > - zpty -w subshell 'n' > + zpty -w -n subshell 'n' > + zpty -r -m subshell REPLY $'*rm *\n' > sleep 1 > - zpty -rt subshell REPLY # "${PS1} rm *" > zpty -rt subshell REPLY && print -r -- ${REPLY%%$'\r\n'} > zpty -d subshell > after=`ls -a -- $target_dir` > @@ -1448,5 +1448,5 @@ F:If this test fails at the first unsetopt, refer to > P01privileged.ztst. > fi > BEL=$'\a' > 0q:RM_STAR_SILENT > -*>zsh: sure you want to delete all 15 files in ${PWD:h}/options.tmp > \[yn\]\? ${BEL} > -*>zsh: sure you want to delete all <-> files in / \[yn\]\? ${BEL} > +*>zsh: sure you want to delete all 15 files in ${PWD:h}/options.tmp > \[yn\]\? ${BEL}(|n) > +*>zsh: sure you want to delete all <-> files in / \[yn\]\? ${BEL}(|n) > > > > --0000000000005d953a05a9e3ae46--