From: Vin Shelton <acs@alumni.princeton.edu>
To: Bart Schaefer <schaefer@brasslantern.com>
Cc: "Zsh Hackers' List" <zsh-workers@zsh.org>
Subject: Re: Five New Test Failures
Date: Tue, 7 Jul 2020 10:14:34 -0400 [thread overview]
Message-ID: <CACeGjnWkkXui2NJb8XiVe3Z91BkFTUexHkzfzWHh+6PNc73eZA@mail.gmail.com> (raw)
In-Reply-To: <CAH+w=7buVYy0OA3bXKqTH0xmtgWLN5qRm=AWHVcx52TgrHEqNQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1652 bytes --]
Thanks, Bart. That fixes four of the five failures. All except this one:
../../../src/zsh-2020-07-07/Test/E01options.ztst: starting.
This test hangs the shell when it fails...
Pattern match failed, line 1:
-<zsh: sure you want to delete all 15 files in
/opt/build/zsh-2020-07-07/Test/options.tmp \[yn\]\?
<zsh: sure you want to delete all <-> files in / \[yn\]\?
+>nuc2% zsh: sure you want to delete all 15 files in
/opt/build/zsh-2020-07-07/Test/options.tmp [yn]?
>nuc2% zsh: sure you want to delete all 28 files in / [yn]?
On Sun, Jul 5, 2020 at 1:23 PM Bart Schaefer <schaefer@brasslantern.com>
wrote:
> On Sun, Jul 5, 2020 at 9:57 AM Bart Schaefer <schaefer@brasslantern.com>
> wrote:
> >
> > On Sun, Jul 5, 2020 at 9:28 AM Bart Schaefer <schaefer@brasslantern.com>
> wrote:
> > >
> > > It's the change to supposedly subvert symlink attacks.
> >
> > Hmm, no, I'm getting random failures even after I revert. Sorry for
> > the red herring.
>
> Ahem. Those failures were something else in my environment.
>
> It does have to do with the "always" block. All the tests pass if I
> just put a "return 0" after the "always".
>
> A bit of further digging indicates that
> zpty_flush After comptesteval
> does not always succeed, but it doesn't need to. The "always" is now
> preserving that failure status.
>
> So perhaps this?
>
> diff --git a/Test/comptest b/Test/comptest
> index b14d4c9..a36e301 100644
> --- a/Test/comptest
> +++ b/Test/comptest
> @@ -128,6 +128,7 @@ comptesteval () {
> return 1
> }
> zpty_flush After comptesteval
> + : Suppress error from zpty_flush
> } always {
> rm $tmp
> }
>
next prev parent reply other threads:[~2020-07-07 14:15 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-05 15:28 Vin Shelton
2020-07-05 16:28 ` Bart Schaefer
2020-07-05 16:57 ` Bart Schaefer
2020-07-05 17:22 ` Bart Schaefer
2020-07-07 14:14 ` Vin Shelton [this message]
2020-07-07 16:03 ` Daniel Shahaf
2020-07-07 16:39 ` Bart Schaefer
2020-07-07 19:33 ` Vin Shelton
2020-07-08 0:25 ` Jun T
2020-07-08 1:03 ` Vin Shelton
2020-07-08 10:49 ` Jun T
2020-07-08 18:23 ` Vin Shelton
2020-07-08 20:30 ` Bart Schaefer
2020-07-08 20:55 ` Vin Shelton
2020-07-09 8:04 ` Jun T
2020-07-11 0:02 ` Daniel Shahaf
2020-07-09 10:17 ` Jun T
2020-07-11 0:03 ` Daniel Shahaf
2020-07-05 16:54 ` Message size limit? (was: Five New Test Failures) Daniel Shahaf
2020-07-05 17:13 ` Vin Shelton
2020-07-07 16:06 ` Daniel Shahaf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACeGjnWkkXui2NJb8XiVe3Z91BkFTUexHkzfzWHh+6PNc73eZA@mail.gmail.com \
--to=acs@alumni.princeton.edu \
--cc=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).