zsh-workers
 help / color / Atom feed
* Test Failure. 2020-03-08
@ 2020-03-08 12:38 Vin Shelton
  2020-03-08 15:27 ` Daniel Shahaf
  0 siblings, 1 reply; 5+ messages in thread
From: Vin Shelton @ 2020-03-08 12:38 UTC (permalink / raw)
  To: Zsh Hackers' List

[-- Attachment #1: Type: text/plain, Size: 822 bytes --]

Using the latest sources, I'm getting the following test error in the
modload test:

--- /tmp/zsh.ztst.7939/ztst.err 2020-03-08 08:33:41.076674463 -0400
+++ /tmp/zsh.ztst.7939/ztst.terr 2020-03-08 08:33:41.080007796 -0400
@@ -0,0 +1 @@
+zsh:2: failed to load module `zsh/parameter':
/opt/zsh-2020-03-08/lib/zsh/5.8.0.1-dev/zsh/parameter.so: cannot open
shared object file: No such file or directory
Test ../../../src/zsh-2020-03-08/Test/V01zmodload.ztst failed: error output
differs from expected as shown above for:
 $ZTST_testdir/../Src/zsh -fc '
   zmodload zsh/parameter
   unset options
   echo $+options
 '
Was testing: can unset a non-readonly autoloadable parameter after loading
the module
../../../src/zsh-2020-03-08/Test/V01zmodload.ztst: test failed.

Please let me know if you need more info.

Regards,
  Vin

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Test Failure. 2020-03-08
  2020-03-08 12:38 Test Failure. 2020-03-08 Vin Shelton
@ 2020-03-08 15:27 ` Daniel Shahaf
  2020-03-08 20:47   ` Vin Shelton
  0 siblings, 1 reply; 5+ messages in thread
From: Daniel Shahaf @ 2020-03-08 15:27 UTC (permalink / raw)
  To: Vin Shelton; +Cc: Zsh Hackers' List

Vin Shelton wrote on Sun, Mar 08, 2020 at 08:38:53 -0400:
> Using the latest sources, I'm getting the following test error in the
> modload test:
> 
> --- /tmp/zsh.ztst.7939/ztst.err 2020-03-08 08:33:41.076674463 -0400
> +++ /tmp/zsh.ztst.7939/ztst.terr 2020-03-08 08:33:41.080007796 -0400
> @@ -0,0 +1 @@
> +zsh:2: failed to load module `zsh/parameter':
> /opt/zsh-2020-03-08/lib/zsh/5.8.0.1-dev/zsh/parameter.so: cannot open shared object file: No such file or directory
> Test ../../../src/zsh-2020-03-08/Test/V01zmodload.ztst failed: error output differs from expected as shown above for:
>  $ZTST_testdir/../Src/zsh -fc '
>    zmodload zsh/parameter
>    unset options
>    echo $+options
>  '
> Was testing: can unset a non-readonly autoloadable parameter after loading
> the module
> ../../../src/zsh-2020-03-08/Test/V01zmodload.ztst: test failed.
> 
> Please let me know if you need more info.

Could you try the following, please?

diff --git a/Test/V01zmodload.ztst b/Test/V01zmodload.ztst
index c3c64a79d..4fddb0bcc 100644
--- a/Test/V01zmodload.ztst
+++ b/Test/V01zmodload.ztst
@@ -349,6 +349,7 @@
 ?(eval):9: file descriptor out of range
 
  $ZTST_testdir/../Src/zsh -fc '
+   MODULE_PATH=${(q)MODULE_PATH}
    if zmodload -e zsh/parameter; then zmodload -u zsh/parameter; fi
    unset options
    zmodload zsh/parameter
@@ -359,6 +360,7 @@
 # Currently prints '1'.
 
  $ZTST_testdir/../Src/zsh -fc '
+   MODULE_PATH=${(q)MODULE_PATH}
    zmodload zsh/parameter
    unset options
    echo $+options
@@ -367,6 +369,7 @@
 >0
 
  $ZTST_testdir/../Src/zsh -fc '
+   MODULE_PATH=${(q)MODULE_PATH}
    if zmodload -e zsh/parameter; then zmodload -u zsh/parameter; fi
    unset builtins
  '
@@ -375,13 +378,15 @@
 # Currently, the 'unset' succeeds.
 
  $ZTST_testdir/../Src/zsh -fc '
+   MODULE_PATH=${(q)MODULE_PATH}
    zmodload zsh/parameter
    unset builtins
  '
 1:can't unset a readonly autoloadable parameter after loading the module
-?zsh:3: read-only variable: builtins
+*?zsh:?: read-only variable: builtins
 
  $ZTST_testdir/../Src/zsh -fc '
+   MODULE_PATH=${(q)MODULE_PATH}
    zmodload zsh/parameter
    zmodload -u zsh/parameter
    echo $options

Cheers,

Daniel

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Test Failure. 2020-03-08
  2020-03-08 15:27 ` Daniel Shahaf
@ 2020-03-08 20:47   ` Vin Shelton
  2020-03-09  1:59     ` Daniel Shahaf
  0 siblings, 1 reply; 5+ messages in thread
From: Vin Shelton @ 2020-03-08 20:47 UTC (permalink / raw)
  To: Daniel Shahaf; +Cc: Zsh Hackers' List

[-- Attachment #1.1: Type: text/plain, Size: 2488 bytes --]

Sadly, nope:

ZTST_verbose=2 make TESTNUM=V01 -e check

yields the attached.

  - Vin

On Sun, Mar 8, 2020 at 11:28 AM Daniel Shahaf <d.s@daniel.shahaf.name>
wrote:

> Vin Shelton wrote on Sun, Mar 08, 2020 at 08:38:53 -0400:
> > Using the latest sources, I'm getting the following test error in the
> > modload test:
> >
> > --- /tmp/zsh.ztst.7939/ztst.err 2020-03-08 08:33:41.076674463 -0400
> > +++ /tmp/zsh.ztst.7939/ztst.terr 2020-03-08 08:33:41.080007796 -0400
> > @@ -0,0 +1 @@
> > +zsh:2: failed to load module `zsh/parameter':
> > /opt/zsh-2020-03-08/lib/zsh/5.8.0.1-dev/zsh/parameter.so: cannot open
> shared object file: No such file or directory
> > Test ../../../src/zsh-2020-03-08/Test/V01zmodload.ztst failed: error
> output differs from expected as shown above for:
> >  $ZTST_testdir/../Src/zsh -fc '
> >    zmodload zsh/parameter
> >    unset options
> >    echo $+options
> >  '
> > Was testing: can unset a non-readonly autoloadable parameter after
> loading
> > the module
> > ../../../src/zsh-2020-03-08/Test/V01zmodload.ztst: test failed.
> >
> > Please let me know if you need more info.
>
> Could you try the following, please?
>
> diff --git a/Test/V01zmodload.ztst b/Test/V01zmodload.ztst
> index c3c64a79d..4fddb0bcc 100644
> --- a/Test/V01zmodload.ztst
> +++ b/Test/V01zmodload.ztst
> @@ -349,6 +349,7 @@
>  ?(eval):9: file descriptor out of range
>
>   $ZTST_testdir/../Src/zsh -fc '
> +   MODULE_PATH=${(q)MODULE_PATH}
>     if zmodload -e zsh/parameter; then zmodload -u zsh/parameter; fi
>     unset options
>     zmodload zsh/parameter
> @@ -359,6 +360,7 @@
>  # Currently prints '1'.
>
>   $ZTST_testdir/../Src/zsh -fc '
> +   MODULE_PATH=${(q)MODULE_PATH}
>     zmodload zsh/parameter
>     unset options
>     echo $+options
> @@ -367,6 +369,7 @@
>  >0
>
>   $ZTST_testdir/../Src/zsh -fc '
> +   MODULE_PATH=${(q)MODULE_PATH}
>     if zmodload -e zsh/parameter; then zmodload -u zsh/parameter; fi
>     unset builtins
>   '
> @@ -375,13 +378,15 @@
>  # Currently, the 'unset' succeeds.
>
>   $ZTST_testdir/../Src/zsh -fc '
> +   MODULE_PATH=${(q)MODULE_PATH}
>     zmodload zsh/parameter
>     unset builtins
>   '
>  1:can't unset a readonly autoloadable parameter after loading the module
> -?zsh:3: read-only variable: builtins
> +*?zsh:?: read-only variable: builtins
>
>   $ZTST_testdir/../Src/zsh -fc '
> +   MODULE_PATH=${(q)MODULE_PATH}
>     zmodload zsh/parameter
>     zmodload -u zsh/parameter
>     echo $options
>
> Cheers,
>
> Daniel
>

[-- Attachment #1.2: Type: text/html, Size: 3817 bytes --]

[-- Attachment #2: err.out --]
[-- Type: application/octet-stream, Size: 31756 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Test Failure. 2020-03-08
  2020-03-08 20:47   ` Vin Shelton
@ 2020-03-09  1:59     ` Daniel Shahaf
  2020-03-09  2:08       ` Vin Shelton
  0 siblings, 1 reply; 5+ messages in thread
From: Daniel Shahaf @ 2020-03-09  1:59 UTC (permalink / raw)
  To: Vin Shelton; +Cc: Zsh Hackers' List

Vin Shelton wrote on Sun, 08 Mar 2020 16:47 -0400:
> Sadly, nope:
> 
> ZTST_verbose=2 make TESTNUM=V01 -e check
> 
> yields the attached.

Thanks for the debug info.  I've reproduced this now (didn't have time
for that yesterday) and pushed a fix to master.  Sorry for the breakage.

Daniel

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Test Failure. 2020-03-08
  2020-03-09  1:59     ` Daniel Shahaf
@ 2020-03-09  2:08       ` Vin Shelton
  0 siblings, 0 replies; 5+ messages in thread
From: Vin Shelton @ 2020-03-09  2:08 UTC (permalink / raw)
  To: Daniel Shahaf; +Cc: Zsh Hackers' List

[-- Attachment #1: Type: text/plain, Size: 456 bytes --]

NP.  I can confirm that the test failure is gone.

Thanks,
  Vin

On Sun, Mar 8, 2020 at 10:00 PM Daniel Shahaf <d.s@daniel.shahaf.name>
wrote:

> Vin Shelton wrote on Sun, 08 Mar 2020 16:47 -0400:
> > Sadly, nope:
> >
> > ZTST_verbose=2 make TESTNUM=V01 -e check
> >
> > yields the attached.
>
> Thanks for the debug info.  I've reproduced this now (didn't have time
> for that yesterday) and pushed a fix to master.  Sorry for the breakage.
>
> Daniel
>

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, back to index

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-08 12:38 Test Failure. 2020-03-08 Vin Shelton
2020-03-08 15:27 ` Daniel Shahaf
2020-03-08 20:47   ` Vin Shelton
2020-03-09  1:59     ` Daniel Shahaf
2020-03-09  2:08       ` Vin Shelton

zsh-workers

Archives are clonable: git clone --mirror http://inbox.vuxu.org/zsh-workers

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://inbox.vuxu.org/vuxu.archive.zsh.workers


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git