From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, HTML_MESSAGE,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 5884 invoked from network); 5 Apr 2021 00:40:12 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 5 Apr 2021 00:40:12 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20200801; t=1617583212; b=XWrwzOrpk7jVzsK0CEszI6JSsbBqgAyNfS2JJTklAFGMkWnHqxwmS2NG6aqDIDw60414pI1dD/ a09gFX4trmsuxMKks0PlvYine+Lf6Bzlp7MoTeP5Br9fxlazVcTr8g1ANBTCFpe0EPzf0R0xSw ZmjK6feWf2MSEQufzyZs3qUjhms7vlZiF6l0O7J7TcgxklFFEWLXKBcOPGn12NEq0V7dNNvbuD LysJNYDFRZhK7QIXIW5Smlj+Y2vJsbWGojzcTocaoIrS8E3tgaDpgDLew8g+KlLOVoV4EhbHip 9OFR1uz4eMrlG6vivgrCT7CcSKGoIjntgjXqGHLcVqg4kQ==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (mail-ed1-f45.google.com) smtp.remote-ip=209.85.208.45; dmarc=none header.from=alumni.princeton.edu; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20200801; t=1617583212; bh=BZge55MwhHztuC5dL0fNijIT9xXLpcsj6W0pNXHtzos=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:DKIM-Signature; b=iUZY4qS2XRDsS81YXhZj40KHEE8t+g8zFc0lz+ldOtm1esgLRCceJ44DyNabVYUBWO8pXKc+53 5O8SDHcdcAL8y4Q5vzFnLd0TxS3FuZq+cfpniU9rWAvgV1D+FiFfZMS6RQrvDzHqfYr9re85dp 43ybeSRZtEUrPk+k+VAdmKhcpkIMvYlGQc+3I62lohUtBMZmpHGV/SA8GGyA1XBmltOoqk+D6S AbCUE5LDFhK+7YSVPSjnev04NLGuiFu3Ayv0tSPn8FWrhUwyhAORbQ8lEvi4vMwKBFaIn1ae69 k4qhUNNaFLS1JPzZPmPsuyzbgSTs0+2vxLLBYPimcmeAmA==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20200801; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Type:Cc:To:Subject:Message-ID :Date:From:In-Reply-To:References:MIME-Version:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=pfOANceAiEmAnh/pC5v5RJe2+Ufn6r9+rP+kzCcx1rw=; b=hDc1tlswkOyVOmyPcLwIKQgXTK guiED+kmlrnX0szsw8AW+t/0/7hbBfKr7gEVplgeJG0aB326YognboZELS3qlhL7I0E0ZMEvJhB0j JBDjw88bjwyrvJIDBcRiXgdVmGFeofGdjP9BtZZpi7fZZaBvk/2IzN/WPr5fqgoqPLOwvaKfeqqR0 I033RKIOd6pFqUEqX7Tky0ONZvnoqOMPpx4XFt+fv3IAP0Nywg5FI9lkEWXDqEkNhjHwpVc2CjNI3 uj+PEYNRGZMOtdaHkjdwzsJ2yqRPB91D7AV72QpMW3qV5HfMmXIV9LYlUz9I2ksQ2p20Xl5m480a6 CRkzXTAQ==; Received: from authenticated user by zero.zsh.org with local id 1lTDHl-000OZC-Ce; Mon, 05 Apr 2021 00:40:09 +0000 Authentication-Results: zsh.org; iprev=pass (mail-ed1-f45.google.com) smtp.remote-ip=209.85.208.45; dmarc=none header.from=alumni.princeton.edu; arc=none Received: from mail-ed1-f45.google.com ([209.85.208.45]:46699) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) id 1lTDHT-000OPn-HY; Mon, 05 Apr 2021 00:39:52 +0000 Received: by mail-ed1-f45.google.com with SMTP id h10so10927278edt.13 for ; Sun, 04 Apr 2021 17:39:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pfOANceAiEmAnh/pC5v5RJe2+Ufn6r9+rP+kzCcx1rw=; b=XEi4OZlYnwqB0mguAxGEOo1d5jWEXsO1ESgo+Z1H6zCftO6dLYth26QdM7v9qnhY+j aoJ/EwsgGheNKwyounpYzMrHsZJv0Noq3i3gLygKCHUgXMIPNPcsAQk3Xi88nMYKD0mg E/hXAARvodT62Ysy2y1EaslhyQB/mP/Ed17DblEpy//8Bimcy6rZzEqgtNm+uTYCDeE5 uBzqfKi3axpscYQne/qZdlxqxy+uGq+1WHcqfSMNfgy1nkraj5hD+j7PY+9G17BfLR1p 0bWgtrFK/EZ/CHBq5emeeUolXG3Xw6f2qTexVoTDOX+c9zdmQf2MCyxhwOAKRE4LcpJi 51YA== X-Gm-Message-State: AOAM532ugDJ3UnWZ/m53xQaDU3MR59D10GntGqZvRdeik0h4CXT46FTu mMzWTyaejsjr1ydyY+MGwKz+c5AsR6md/2SBp/o= X-Google-Smtp-Source: ABdhPJx1Qa38P4RyY4ptpSdxfENmKZUv//BIQDWTYEj7JBBK0+MLigBnPjdwYOh+orkS8el6U9n0rB9Y8qbnTgaRdD8= X-Received: by 2002:aa7:c312:: with SMTP id l18mr14725811edq.190.1617583191054; Sun, 04 Apr 2021 17:39:51 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Vin Shelton Date: Sun, 4 Apr 2021 20:39:14 -0400 Message-ID: Subject: Re: Y01 Test Failure on Arch To: Bart Schaefer Cc: "Jun. T" , "Zsh Hackers' List" Content-Type: multipart/alternative; boundary="0000000000007f5c0005bf2eef34" X-Seq: 48398 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: Archived-At: --0000000000007f5c0005bf2eef34 Content-Type: text/plain; charset="UTF-8" So it sounds like Jun's fix is the right one? - Vin On Sun, Apr 4, 2021 at 2:27 PM Bart Schaefer wrote: > (I'm on "vacation" this week so won't have as much feedback as I have > lately.) > > On Sun, Apr 4, 2021 at 7:01 AM Vin Shelton > wrote: > > > > Also, why was the test change necessary in the first place? > > The test was not checking the correct thing. expand-or-complete first > invokes the built-in expand-word and then falls back on completion, > but the patch updated the _expand completer (which was never reached > after expand-word produced a result). > --0000000000007f5c0005bf2eef34 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
So it sounds like Jun's fix is the right= one?

=C2=A0 - Vin

On S= un, Apr 4, 2021 at 2:27 PM Bart Schaefer <schaefer@brasslantern.com> wrote:
(I'm on "vacation" th= is week so won't have as much feedback as I have lately.)

On Sun, Apr 4, 2021 at 7:01 AM Vin Shelton <acs@alumni.princeton.edu> wrote: >
> Also, why was the test change necessary in the first place?

The test was not checking the correct thing.=C2=A0 expand-or-complete first=
invokes the built-in expand-word and then falls back on completion,
but the patch updated the _expand completer (which was never reached
after expand-word produced a result).
--0000000000007f5c0005bf2eef34--