From: Vin Shelton <acs@alumni.princeton.edu>
To: Mikael Magnusson <mikachu@gmail.com>
Cc: "Zsh Hackers' List" <zsh-workers@zsh.org>
Subject: Re: Double free with latest updates
Date: Mon, 4 May 2015 11:49:46 -0400 [thread overview]
Message-ID: <CACeGjnXzPcibj_COfiZWBNa0+fd-XK6ncemvfHFM5wR28PUatw@mail.gmail.com> (raw)
In-Reply-To: <CAHYJk3SUQ3Q=6Xyiq7m7SrrFyKOq=EDhRWp1=jdkxZr48jWGBQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2255 bytes --]
Dear Mikael,
On Mon, May 4, 2015 at 10:38 AM, Mikael Magnusson <mikachu@gmail.com> wrote:
> On Mon, May 4, 2015 at 1:20 PM, Vin Shelton <acs@alumni.princeton.edu>
> wrote:
> > The most recent changes to builtin.c result in a double free in running
> the
> > test suite.
> >
> > I have more details if you need them.
> >
> > - Vin
> >
> > zsh
> > remote: Counting objects: 9, done.
> > remote: Compressing objects: 100% (5/5), done.
> > remote: Total 5 (delta 4), reused 0 (delta 0)
> > Unpacking objects: 100% (5/5), done.
> > From git://zsh.git.sf.net/gitroot/zsh/zsh
> > 5b00bfe..1e6fb1a master -> origin/master
> > Updating 5b00bfe..1e6fb1a
> > Fast-forward
> > ChangeLog | 4 ++++
> > Src/builtin.c | 7 ++++---
> > 2 files changed, 8 insertions(+), 3 deletions(-)
> >
> > Building zsh
> > /opt/src/zsh-2015-05-04
> > cd . && ./.preconfig
> > Configuring zsh-2015-05-04 for installation prefix /opt/zsh-2015-05-04.
> > Building zsh...done.
> > Running tests...%
> > print ten ten nine one print
> > print print one two three four five six seven eight nine ten one two
> > print mystery sequence
> > print one
> > print two
> > print mystery sequence
> > print metaphor\? shmetaphor!
> > print metaphor!
> > print -l metophor, Molochi,
> > echo $(echo foo bar) again
> > echo more $( echo $(echo foo bar) again )
> > done.
> > *** Error in `zsh': double free or corruption (out): 0x00007fff694af880
> ***
> >
>
> Doesn't happen here with or without --enable-zsh-{mem,debug}. Valgrind
> also didn't complain at all. Enable the MALLOC_CHECK_ flag that
> enables backtrace on double free and see if it says anything useful.
>
> "If MALLOC_CHECK_ is set to 0, any detected heap corruption is
> silently ignored; if set to 1, a diagnostic is printed on stderr; if
> set to 2, abort is called immediately."
>
Thanks for the suggestion, but I can no longer trigger a failure. I tried
running
make check
from the command line. I also tried running it from a
#!/usr/bin/env zsh
script (as my nightly build script does). In each case, all tests passed
and no double free was recorded.
I will run with this shell and will let you know if I observe any failures.
Sorry for any troubles this may have caused.
- Vin
prev parent reply other threads:[~2015-05-04 15:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-04 11:20 Vin Shelton
2015-05-04 14:38 ` Mikael Magnusson
2015-05-04 15:49 ` Vin Shelton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACeGjnXzPcibj_COfiZWBNa0+fd-XK6ncemvfHFM5wR28PUatw@mail.gmail.com \
--to=acs@alumni.princeton.edu \
--cc=mikachu@gmail.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).