From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9997 invoked by alias); 4 May 2015 15:50:04 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 35031 Received: (qmail 14088 invoked from network); 4 May 2015 15:49:51 -0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HTML_MESSAGE,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=6InFlW5ck8U64eyOuR6RU2GffkOBViPsAVekItTGlXE=; b=fUnAup6DjI6Lr/VbZ6sE3Fua9bdalQ6eDqCuC2qqwlsmHPm73BGpR8eiXqm4VbCF0f kQcle/Uw2UjSaTooIj0KfRam3zkcHzucwVVuCSMqJ4CF78V93wHUf9XCjBzKSt1D85KD U36H7n/STdSGU6ByY4i0UJjBUUPSgaThFkTCi0hYs/8gaMyFIYCh+2m0kpLSXIoSx1En OvcqBkRG6etpsrhtedBNSrnkQyWL/C11pftFNVGJlMAYF63CD9vBLaX2qsdO2Q+vcQBN VIiZ2/BHtXMWHisoyxPtGpmNg54joZBGrAHu92iPd0ADOaLoQg3CGniEA9Q8GKTZdYEK U83w== MIME-Version: 1.0 X-Received: by 10.52.100.103 with SMTP id ex7mr26248873vdb.71.1430754587030; Mon, 04 May 2015 08:49:47 -0700 (PDT) Sender: ethersoft@gmail.com In-Reply-To: References: Date: Mon, 4 May 2015 11:49:46 -0400 X-Google-Sender-Auth: JClN1wbjV7YDWJTf7x9xsEdboT4 Message-ID: Subject: Re: Double free with latest updates From: Vin Shelton To: Mikael Magnusson Cc: "Zsh Hackers' List" Content-Type: multipart/alternative; boundary=20cf307f3886ebb9f20515438296 --20cf307f3886ebb9f20515438296 Content-Type: text/plain; charset=UTF-8 Dear Mikael, On Mon, May 4, 2015 at 10:38 AM, Mikael Magnusson wrote: > On Mon, May 4, 2015 at 1:20 PM, Vin Shelton > wrote: > > The most recent changes to builtin.c result in a double free in running > the > > test suite. > > > > I have more details if you need them. > > > > - Vin > > > > zsh > > remote: Counting objects: 9, done. > > remote: Compressing objects: 100% (5/5), done. > > remote: Total 5 (delta 4), reused 0 (delta 0) > > Unpacking objects: 100% (5/5), done. > > From git://zsh.git.sf.net/gitroot/zsh/zsh > > 5b00bfe..1e6fb1a master -> origin/master > > Updating 5b00bfe..1e6fb1a > > Fast-forward > > ChangeLog | 4 ++++ > > Src/builtin.c | 7 ++++--- > > 2 files changed, 8 insertions(+), 3 deletions(-) > > > > Building zsh > > /opt/src/zsh-2015-05-04 > > cd . && ./.preconfig > > Configuring zsh-2015-05-04 for installation prefix /opt/zsh-2015-05-04. > > Building zsh...done. > > Running tests...% > > print ten ten nine one print > > print print one two three four five six seven eight nine ten one two > > print mystery sequence > > print one > > print two > > print mystery sequence > > print metaphor\? shmetaphor! > > print metaphor! > > print -l metophor, Molochi, > > echo $(echo foo bar) again > > echo more $( echo $(echo foo bar) again ) > > done. > > *** Error in `zsh': double free or corruption (out): 0x00007fff694af880 > *** > > > > Doesn't happen here with or without --enable-zsh-{mem,debug}. Valgrind > also didn't complain at all. Enable the MALLOC_CHECK_ flag that > enables backtrace on double free and see if it says anything useful. > > "If MALLOC_CHECK_ is set to 0, any detected heap corruption is > silently ignored; if set to 1, a diagnostic is printed on stderr; if > set to 2, abort is called immediately." > Thanks for the suggestion, but I can no longer trigger a failure. I tried running make check from the command line. I also tried running it from a #!/usr/bin/env zsh script (as my nightly build script does). In each case, all tests passed and no double free was recorded. I will run with this shell and will let you know if I observe any failures. Sorry for any troubles this may have caused. - Vin --20cf307f3886ebb9f20515438296--