zsh-workers
 help / color / mirror / code / Atom feed
From: Michael Giuffrida <michaelpg@google.com>
To: Bart Schaefer <schaefer@brasslantern.com>,
	Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: No incremental undo in vi mode
Date: Sat, 27 Feb 2016 21:33:15 +0000	[thread overview]
Message-ID: <CACi5S_0Fxz-oS=+DezScn9PGijkyf8EsPOH2uDaAWBppZsp2zg@mail.gmail.com> (raw)
In-Reply-To: <CAH+w=7a8fRGVYj7G8y8kDZ8YP2Rg80+9vx1DWVpjvyhh_EqeMA@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1246 bytes --]

Explicitly binding "undo" to a key didn't help.

However, I've gone ahead and bisected this; looks like it was introduced
between 5.0.2 and 5.0.3, and fixed in 5.0.5-dev-1.

Introduced in: 0ed3c5c (31765: If zle starts in viins mark as insertion.
    This allows undo to work on everything entered.)
Fixed in: a8c4ed6 (32314: merge undo events corresponding to vi change in
the vi-cmd-mode widget so undo from insert mode is useful again)

Guess I'll upgrade. Thanks!

On Sat, Feb 27, 2016 at 8:47 AM Bart Schaefer <schaefer@brasslantern.com>
wrote:

> On Fri, Feb 26, 2016 at 10:35 PM, Michael Giuffrida
> <michaelpg@google.com> wrote:
> > When using vi bindings, my understanding is that `C-_` should trigger
> > readline's undo behavior, as should `u` when in command mode.[1]
>
> Zsh does not use readline.  It has its own editor with its own set of
> key bindings.
>
> > In zsh in vi mode, it just clears the whole line. So it's not useful for
> > undoing the effect of glob expansion or other tab completion.
>
> Are you sure you have C-_ bound to what you think you do?  With
>
> bindkey -v
> bindkey '\C-_' undo
>
> I get the behavior you expect rather than the behavior you report.
>
> What does
>
> bindkey '\C-_'
>
> output for you?
>

      reply	other threads:[~2016-02-27 21:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-27  6:35 Michael Giuffrida
2016-02-27 16:47 ` Bart Schaefer
2016-02-27 21:33   ` Michael Giuffrida [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACi5S_0Fxz-oS=+DezScn9PGijkyf8EsPOH2uDaAWBppZsp2zg@mail.gmail.com' \
    --to=michaelpg@google.com \
    --cc=schaefer@brasslantern.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).