From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=3.4.4 Received: from zero.zsh.org (zero.zsh.org [IPv6:2a02:898:31:0:48:4558:7a:7368]) by inbox.vuxu.org (Postfix) with ESMTP id 4C8702E649 for ; Sun, 8 Sep 2024 22:17:05 +0200 (CEST) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1725826625; b=Rs2wr2svyIHBqja+UcA3H2tGa4MxgaxrKQHSr94lNj+3ADw+OaTP8R9wKloCPgwX0KbH58AvmR R4B5z1qHiH+EUJDZOX1McfpUZjzPFlbDKrC8/j5emNwK+XqVcHcnmgKtZ8fuhY5cXNQmGpNSGL 8s0ET7DuvqWq90RGU/bSHASvmaDk+SYMfkuOgMMAHsQS5exw/zBAEmZ/b32Bac9Yekq2FaKS3w gvIyl/3M9VgPCYDdjyYbiA3bjkFeEOlpNToHc9JV4/q8mU3h1tW2DoRYbUdA2mRgFuTLkK9oQF J6I9Yqj4z/lheRQZv3xsgoIJexBDhzM4fm6UTuagvmC2Sg==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (mail-lj1-f182.google.com) smtp.remote-ip=209.85.208.182; dkim=pass header.d=gmail.com header.s=20230601 header.a=rsa-sha256; dmarc=pass header.from=gmail.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1725826625; bh=pa0GFIi5Qmor96OeklCgfTUT7QMrlDtozVqFhrUFtqE=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:DKIM-Signature:DKIM-Signature; b=IzVxF4Epu4CXQ0KtnbSOUAfkObBpqvdMbuxB9uxYuzsKv9XpSMir54eXNDgMWiYi0gSqwcTV/O bCm737XcJ/c6CpdrQBHdwhRP0Cbzzddsv7lCM2uWcAOcNodilQ6PH6D3nifzbnjmeVgp9GpnEB Uy+QWegEBnCodXsm3gHAJTrBDNsDoin2C+RJ6l4S7Bp++pqg78P6kslGYcFLOjwtoRNTTSUquk 6nI06BZZqRPnZtdcsXFH5mwtAOApfBGmtzAYAQJG5NNl+2M+4jESsT9cQwm2dfC87veTk69qKk dDKeu1OQjRWbymQOoIhMv+5wx/gU3IXw4w9USkU5yKzCWw==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Type:Cc:To:Subject:Message-ID :Date:From:In-Reply-To:References:MIME-Version:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=pa0GFIi5Qmor96OeklCgfTUT7QMrlDtozVqFhrUFtqE=; b=dx5iAQM6wgh01pqPhSG/2puBub cUmISvALHyEqvjM8luWTcxRS8FSaqqHBbNohUlAlK2fITLMEMWIaYwiInt51xlzUfpFVuhqcydTTm Vug88lb59wiTwUXxfyhKR1CxmH6A/48efhckFGbAAnj4p/cocztzjV6C/xgrzwyrLrkuffhogiSNc /kYPkI+S7k+lTb52hw63ya8gWZ1W9gElJMlR/5j5Yof1Pqzea0p36Tr8kLQF7qxpbi/ZjP75ivD4k 7EMXOboEIRRBT81kSHdkxBPm5ss22LVOGnAWk08FhZQky+tAU7yvJRsmasKHJOsny0ZZAErmiLtsb krKsYxqQ==; Received: by zero.zsh.org with local id 1snOLJ-00017x-0y; Sun, 08 Sep 2024 20:17:05 +0000 Authentication-Results: zsh.org; iprev=pass (mail-lj1-f182.google.com) smtp.remote-ip=209.85.208.182; dkim=pass header.d=gmail.com header.s=20230601 header.a=rsa-sha256; dmarc=pass header.from=gmail.com; arc=none Received: from mail-lj1-f182.google.com ([209.85.208.182]:53521) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) id 1snOKq-0000lG-4v; Sun, 08 Sep 2024 20:16:36 +0000 Received: by mail-lj1-f182.google.com with SMTP id 38308e7fff4ca-2f75428b9f8so16096121fa.3; Sun, 08 Sep 2024 13:16:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1725826595; x=1726431395; darn=zsh.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=pa0GFIi5Qmor96OeklCgfTUT7QMrlDtozVqFhrUFtqE=; b=O3RCFDNYN2TdtKW5v2hZfQC89s0yKi+EjE4xOPSYInE1HDClkSPgRU6G2JusdqqMh5 JG9fJOVV2xmzi0JLlz1KzIRKdDaWZz1MDns3tpp0GkeusYiab6kOmLWIwbkRypSGk84C 4X+3tJ4gnu1ZIst12OyBMg4LKoAEMf14BWMjBPS/+pasEhQZjQIyI4/CbVh9K12+KPv3 7USPOcyu8IRag7fmJNktlWylKm2xh52/At3/KEM+psGYKhnl5eu7SlptqSm6AwZGyxlf jSdGlt5pWOcBh+SAp4TQHxchL9dVp5YaJFWMYIBJiFsCjJgDiCAeMaUlDQLf0tKBQJ6O 0m5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725826595; x=1726431395; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=pa0GFIi5Qmor96OeklCgfTUT7QMrlDtozVqFhrUFtqE=; b=CnWCF9/YvUcwbvPYu7uI69AYBF3J93GI66hYjJNA6sGWpGfZUc7bkDbULX+NEEstff AcoiemI/1gyYkaokWDvOmlu2djaLTACZrQy2fhRnGX6FgXf4TCvAeauI3CpRoLPJeSPx TzvcH6WCl1OKO3X8SBJxw2TQTSH3GQFsod5muYvRRMsoXsB2EiVwWZZLWzCbfe/15VMB DEFYnLj9O3oxegr4IhQ/dTQOLjFnkaHqOBAz7wAMtKFiBs3tTloRe3eAcfO2oxtPqfe9 NISHnyRMafYxxwotWF1MrQ/n9OxDP/Yd4v5w3h056C7rm7KX3lI3Om0zlRfAGCyTUknx ZC8Q== X-Gm-Message-State: AOJu0YwGZI3xtc5ND9aDMZPTIu2vL5NbyDimrzB1NGCNrMUlOmGbSH6z 3c8Fj9B6UyNTt33GPBbSujI9HLWYVvHl3uN5uYnEQdmph44CdQN5yiwhjq3KtKq5wAA9Yd6mJ/l wJYBuWip9CADJsG9lob9V5yHZ63ISkBpY X-Google-Smtp-Source: AGHT+IGWbWuSx+9IPpXT7hUwXHQasUHdxzNoFFEMzIyT8PI/r6uKMnilTua7fWlnCooFvN5Lq+JPBGOh1CXn5D9EP2I= X-Received: by 2002:a2e:b88a:0:b0:2f3:cb70:d447 with SMTP id 38308e7fff4ca-2f75aa0f918mr49280801fa.40.1725826594206; Sun, 08 Sep 2024 13:16:34 -0700 (PDT) MIME-Version: 1.0 References: <92928-1725811080.428123@V0ZG.ZDVw.IOkd> In-Reply-To: <92928-1725811080.428123@V0ZG.ZDVw.IOkd> From: Emil Velikov Date: Sun, 8 Sep 2024 21:16:22 +0100 Message-ID: Subject: Re: Integrating the kmod completions upstream To: Oliver Kiddle Cc: zsh-workers@zsh.org Content-Type: text/plain; charset="UTF-8" X-Seq: 53076 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: , List-Subscribe: , List-Unsubscribe: , List-Post: List-Owner: List-Archive: Greetings Oliver, Thanks for the prompt reply o/ On Sun, 8 Sept 2024 at 16:58, Oliver Kiddle wrote: > > Emil Velikov wrote: > > Hello team, I'm considering pulling the zsh completion files (as do > > bash and fish fwiw) in the upstream kmod project. > > This seems to correspond to the Linux _modutils function in zsh. > (I guess modutils must have been renamed to kmod at some point) > Even if the function stays in zsh, it should be renamed. > modutils is the old project which went EOL ~2011 and kmod superseded it. I don't think it makes much sense to rename at this point. > > At a glance, a few questions come up: > > - what is the license of the completion files? > > Same as the rest of zsh: a variant of the MIT license. > Looking through https://spdx.org/licenses/ - there are a bunch of MIT variants. Can you let me know which is the correct one? > > - would the team be comfortable with relicensing under LGPL-2.1-or-later? > > The LGPL is a superset of the zsh license so from a legal standpoint > you can do that. A good portion of the function was written by me and > I don't mind it being changed to match any OSI licence of an upstream > project wanting to pull their completions in. An alternative you might > consider is explicitly dual-licencing the completion file. > Right, let me see if upstream kmod is OK with the (to be confirmed) MIT license. And if needed will get back to you. > > - are there any copyright holders which I could/should add in the > > files themselves? > > As a minimum, I would suggest acknowledging in the header that it has > been imported from the zsh project, crediting just "Zsh developers". > About 15 different people have contributed to that function so naming > them all might be a bit much. Or you cut that down to a shorter list. > Instead of extensive lists, covering decades and dozens of people, I'm considering adding the following for fish. What would a zsh equivalent look like - there is no official git repo afaict. If you can suggest something I can copy/paste that would be great. ``` This file is based on the completion from https://github.com/fish-shell/fish-shell, git tag 3.7.1. See the repository for the original authors and copyright holders. ``` > > - is there a particular process/coordination that you'd suggest? > > Not really, just import the function. Have your build system install the > file to $DESTDIR$PREFIX/share/zsh/site-functions and let us know once it > reaches a released version of kmod. It's better that there is an overlap > period when the function is available from both zsh and kmod than a gap > where users get no completion. > Ack will do. As you can see from my other email, upstream dkms was released with the zsh completion already. > > In general, would you recommend me going this route, or perhaps it's > > better to rewrite them from scratch? > > Yes, I would recommend that route. In most cases, the upstream project is a > better home for completions because they can better track changes in the > upstream project. > Indeed that's my train of thought as well. > There's no point in duplicating the effort with a rewrite. The > completions included with zsh have the advantage of having been written > by people who know zsh completion well - if not the kmod project well. > On the other hand, since we're not zsh experts, some of the micro-optimisations might go away. Apologies in advance if that happens :-) Thanks for all the help, Emil