Git commands or aliases first?

Git commands or aliases first?

[Nikolai Weibull]

Hi!

What is the desired tag order for Git commands and aliases?

My conclusion is that the current behavior is incorrect.  My reasoning
is that git will prefer invoking a command over an alias with the same
name.

Does anyone have a contradictory opinion, or should I merge this change?

Re: Git commands or aliases first?

[Mikael Magnusson]

On 22 July 2011 13:40, Nikolai Weibull <now@bitwi.se> wrote:
> Hi!
>
> What is the desired tag order for Git commands and aliases?
>
> My conclusion is that the current behavior is incorrect.  My reasoning
> is that git will prefer invoking a command over an alias with the same
> name.
>
> Does anyone have a contradictory opinion, or should I merge this change?

We could show aliases first, but leave out ones that are also
commands? On the one hand, I would want to complete my aliases before
the commands, on the other hand I usually make alias names short
enough to not need completing. On the third hand it's configurable
with group-order anyway, so either is fine with me :). Ie
zstyle ':completion:*:git:*' group-order main-porcelain-commands

-- 
Mikael Magnusson

Re: Git commands or aliases first?

[Nikolai Weibull]

On Fri, Jul 22, 2011 at 13:58, Mikael Magnusson <mikachu@gmail.com> wrote:
> On 22 July 2011 13:40, Nikolai Weibull <now@bitwi.se> wrote:
>> Hi!
>>
>> What is the desired tag order for Git commands and aliases?
>>
>> My conclusion is that the current behavior is incorrect.  My reasoning
>> is that git will prefer invoking a command over an alias with the same
>> name.
>>
>> Does anyone have a contradictory opinion, or should I merge this change?
>
> We could show aliases first, but leave out ones that are also
> commands? On the one hand, I would want to complete my aliases before
> the commands, on the other hand I usually make alias names short
> enough to not need completing. On the third hand it's configurable
> with group-order anyway, so either is fine with me :). Ie
> zstyle ':completion:*:git:*' group-order main-porcelain-commands

Yes, I realize that it’s configurable, but I’d prefer the default to
be what most users want.

Hm, perhaps __git_aliases_or_commands is doing this wrong.  Perhaps
adding the filtering that you suggest is the best way to do it.

Re: Git commands or aliases first?

[Frank Terbeck]

Mikael Magnusson wrote:
> On 22 July 2011 13:40, Nikolai Weibull <now@bitwi.se> wrote:
>> Hi!
>>
>> What is the desired tag order for Git commands and aliases?
>>
>> My conclusion is that the current behavior is incorrect.  My reasoning
>> is that git will prefer invoking a command over an alias with the same
>> name.
>>
>> Does anyone have a contradictory opinion, or should I merge this change?
>
> We could show aliases first, but leave out ones that are also
> commands? On the one hand, I would want to complete my aliases before
> the commands, on the other hand I usually make alias names short
> enough to not need completing. On the third hand it's configurable
> with group-order anyway, so either is fine with me :). Ie
> zstyle ':completion:*:git:*' group-order main-porcelain-commands

If there is a git alias "add", git will still use the command, not the
alias. So that would make sense.

I also think aliases should be completed before commands, since that
will probably be "commands" the user calls regularly.

Regards, Frank

Re: Git commands or aliases first?

[Nikolai Weibull]

On Fri, Jul 22, 2011 at 14:06, Frank Terbeck <ft@bewatermyfriend.org> wrote:
> Mikael Magnusson wrote:
>> On 22 July 2011 13:40, Nikolai Weibull <now@bitwi.se> wrote:
>>> Hi!
>>>
>>> What is the desired tag order for Git commands and aliases?
>>>
>>> My conclusion is that the current behavior is incorrect.  My reasoning
>>> is that git will prefer invoking a command over an alias with the same
>>> name.
>>>
>>> Does anyone have a contradictory opinion, or should I merge this change?
>>
>> We could show aliases first, but leave out ones that are also
>> commands? On the one hand, I would want to complete my aliases before
>> the commands, on the other hand I usually make alias names short
>> enough to not need completing. On the third hand it's configurable
>> with group-order anyway, so either is fine with me :). Ie
>> zstyle ':completion:*:git:*' group-order main-porcelain-commands
>
> If there is a git alias "add", git will still use the command, not the
> alias. So that would make sense.
>
> I also think aliases should be completed before commands, since that
> will probably be "commands" the user calls regularly.

OK, I’ve implemented it this way now.