From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20085 invoked by alias); 30 Jul 2013 14:37:21 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 31614 Received: (qmail 27992 invoked from network); 30 Jul 2013 14:37:17 -0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 Received-SPF: pass (ns1.primenet.com.au: SPF record at _netblocks.google.com designates 209.85.220.46 as permitted sender) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=DoFaIgAadmSxAploDYX+RfP4u0JxoM/uUWj3hbHs3vk=; b=ZUTSBq/KgfgKDuzbgT4k/vvqg7v/3YfoztINjANqJQZ1GklawuCHZUuxk7upVpZLR5 n36M8jicN9eHXqFeLi6tCTT4Jkg8+Ban6CJTOHWftDHYgM0k8k2rnVV37vRAaxfCBzGw Mz8FLuXwqlFfu94EHAAsxfOcQ4Je10YExfJ8of+5LPL+e+k0h/sqUfZq9a6imroyvfk5 NJFbQTSP/VjUagVezrHzOg6WkTdYpV9eP+poOh2xA08G7KGYHK3/TZUc3p6djyTm7Wtn 5VL3CJ+EFr5a9HyzZCHNCqNIk3J7e8JxfXdeGn3gMicUH0CQZeobtYGVgDW85Tw4oz1O wg/g== MIME-Version: 1.0 X-Received: by 10.68.237.3 with SMTP id uy3mr35362426pbc.155.1375195034035; Tue, 30 Jul 2013 07:37:14 -0700 (PDT) Sender: nikolai.weibull@gmail.com In-Reply-To: <3debebad8c56f7f8ad681b7c0b4d226e33e5e011.1375006129.git.oystwa@gmail.com> References: <3debebad8c56f7f8ad681b7c0b4d226e33e5e011.1375006129.git.oystwa@gmail.com> Date: Tue, 30 Jul 2013 16:37:13 +0200 X-Google-Sender-Auth: 7TxsaahxfWw_VuAMwzYz4OV8o1A Message-ID: Subject: Re: [PATCH 15/16] _git: git rm: make git rm --cached work as intended From: Nikolai Weibull To: =?UTF-8?Q?=C3=98ystein_Walle?= Cc: zsh-workers@zsh.org, m0viefreak.cm@googlemail.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Sun, Jul 28, 2013 at 6:22 PM, =C3=98ystein Walle wrot= e: > From: m0viefreak > > While limiting the completion to __git_changed-in-index_files > makes perfect sense for "git diff", it is wrong to use for > "git rm", because it prevents it from completing files present in > HEAD. Giving --cached to git rm is supposed to > "just remove it from the index, keep the working tree copy" > and is in no way related to the file needing to be > modified in the index in the first place. If I understand --cached, it=E2=80=99s exactly like you described, and if y= ou specify --cached, you only want files actually modified in the index to be completed. I may be wrong, but please clarify, as you seem to be stating a tautology.