From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6013 invoked by alias); 22 Jul 2011 12:04:40 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 29586 Received: (qmail 28213 invoked from network); 22 Jul 2011 12:04:30 -0000 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 Received-SPF: pass (ns1.primenet.com.au: SPF record at _spf.google.com designates 209.85.160.171 as permitted sender) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=LeWXKb6NMos4vr0AEwvQxjcJXQhqs/FsB873cJLOcNE=; b=mOMv34OzRhQQWfUfrrDKQpMjxBLxMxJP2/SolurqLmEqirtdZw5G9D1lgr6gVNFF2V gf9ixJiM+zxiOULRUQehcoNz8YFdXX5fb0ajK6c87TEioravVL/IRs5pT80VCkWj7+tA x69tY40+8jXpql7798jE/Mj7rWwZ4KMqBRyag= MIME-Version: 1.0 Sender: nikolai.weibull@gmail.com In-Reply-To: <878vrslslj.fsf@ft.bewatermyfriend.org> References: <1309379833-31315-1-git-send-email-ft@bewatermyfriend.org> <1309383009-18575-1-git-send-email-ft@bewatermyfriend.org> <878vrslslj.fsf@ft.bewatermyfriend.org> Date: Fri, 22 Jul 2011 13:58:13 +0200 X-Google-Sender-Auth: 9sfZ7bUuo9fy_xyfIbYS2wpIHLA Message-ID: Subject: Re: PATCH: (4/3) _git-buildpackage: use a #desc: line From: Nikolai Weibull To: Frank Terbeck Cc: zsh workers , Mikael Magnusson Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Wed, Jul 20, 2011 at 20:22, Frank Terbeck wrote= : > Nikolai Weibull wrote: >> On Wed, Jun 29, 2011 at 23:30, Frank Terbeck wr= ote: >> >>> =C2=A0If workers-29519 is applied, then this would make the already-exi= sting >>> =C2=A0`git-buildpackage' completion use a proper "#desc:" line, which c= ould >>> =C2=A0look like this: >> >> Does anyone have a better solution than this lying around? =C2=A0I feel >> that this should be set with a zstyle, but I can=E2=80=99t figure out ho= w, for >> example, _git-buildpackage would call zstyle when it=E2=80=99s only bein= g >> autoloaded. =C2=A0Should _git, once loaded, load all autoloaded _git-* >> functions so that they may set their description using zstyle? > > Actually, I don't think this is something styles are right for. There's > no context sensitivity required, nor is there anything that needs to be > configured. > > This is very much like `compinit' looking at the first line of _* files > from $fpath. That's probably not what all completions should be doing, > but _git isn't quite the common completion either. And this solution is > pretty straight forward. =C2=A0So, unless there's some corner case I am > missing, I don't see why it should be changed to something that's (as I > pointed out earlier) less suited. Hm, OK, perhaps you=E2=80=99re right. I still don=E2=80=99t like it, but I= =E2=80=99ll live with it. I will, however, change this to be =E2=80=9C#description =E2=80= =9D instead of the slightly cryptic =E2=80=9C#desc:=E2=80=9D. =E2=80=9C#Description = =E2=80=9D reads better with the =E2=80=9C#compdef =E2=80=9D on line one. I hope this change is OK with= you.