From: Nikolai Weibull <now@disu.se>
To: "Øystein Walle" <oystwa@gmail.com>
Cc: zsh-workers@zsh.org
Subject: Re: [PATCH 11/16] _git: remove TODOs of actually documented options
Date: Tue, 30 Jul 2013 22:41:35 +0200 [thread overview]
Message-ID: <CADdV=Mv9-yeggTVKNqUm_dz-aJEbx_nBtKW3MpOGUp5C=+onzg@mail.gmail.com> (raw)
In-Reply-To: <CAFaJEquW7QY7Xa6gmrEJuMS2U6dtJsCAtjFcE-=n5cwAs0iFwg@mail.gmail.com>
On Tue, Jul 30, 2013 at 8:01 PM, Øystein Walle <oystwa@gmail.com> wrote:
> On 30 July 2013 16:40, Nikolai Weibull <now@disu.se> wrote:
>> Here too, undocumented means that it isn’t documented in Git’s
>> documentation. Please do what I should have done and send them
>> patches as well.
>
> Our misunderstanding of the TODOs has caused some unfortunate trouble...
It’s my fault for never putting out any real documentation on the to-do list.
> I have "vetted" this particular patch. Some options are in fact documented
> (--null, --local, -v and --verbose, --break-rewrites) while some are not even
> supported by git (--detect-renames, --detect-copies, --for-rewrite).
>
> You are completely right about the rest.
>
> Should I send a corrected patch to replace this one (an 11/16 v2 so to speak)?
> If it is of interest I can vet the others that touch TODOs as well.
I think that you may apply them, but please try to send patches to the
Git project as well so that the options can get documented properly in
the man files as well.
next prev parent reply other threads:[~2013-07-30 20:41 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-28 16:21 [PATCH 00/16] Improvements to the Git completion functions Øystein Walle
2013-07-28 16:21 ` [PATCH 01/16] _git: fix a wrong variable in __git_config_values Øystein Walle
2013-07-28 16:21 ` [PATCH 02/16] _git: fix usage of ->int: for some entries in _git-config Øystein Walle
2013-07-28 16:22 ` [PATCH 03/16] _git: make git submodule <cmd> completion work Øystein Walle
2013-07-28 16:22 ` [PATCH 04/16] _git: correctly use __git_guard_number in some cases Øystein Walle
2013-07-28 16:22 ` [PATCH 05/16] _git: completion updates to match latest git v1.8.3 Øystein Walle
2013-07-28 16:22 ` [PATCH 06/16] _git: completion updates to match latest git v1.8.3 part 2 Øystein Walle
2013-07-28 16:22 ` [PATCH 07/16] _git: add new configuration options to match latest git v1.8.3 Øystein Walle
2013-07-28 16:22 ` [PATCH 08/16] _git: reword _git-config TODO Øystein Walle
2013-07-28 16:22 ` [PATCH 09/16] _git: support completing remote branches without <remote>/ prefix Øystein Walle
2013-07-28 16:22 ` [PATCH 10/16] _git: fix some typos Øystein Walle
2013-07-28 16:22 ` [PATCH 11/16] _git: remove TODOs of actually documented options Øystein Walle
2013-07-30 14:40 ` Nikolai Weibull
2013-07-30 18:01 ` Øystein Walle
2013-07-30 20:41 ` Nikolai Weibull [this message]
2013-07-28 16:22 ` [PATCH 12/16] _git: correct some "undocumented" options Øystein Walle
2013-07-30 14:39 ` Nikolai Weibull
2013-07-30 16:06 ` m0viefreak
2013-07-30 20:45 ` Nikolai Weibull
2013-07-28 16:22 ` [PATCH 13/16] _git: change completion text for consistency Øystein Walle
2013-07-28 16:22 ` [PATCH 14/16] _git: move --(no-)follow to be log-specific option Øystein Walle
2013-07-28 16:22 ` [PATCH 15/16] _git: git rm: make git rm --cached work as intended Øystein Walle
2013-07-30 14:37 ` Nikolai Weibull
2013-07-30 15:04 ` Aaron Schrab
2013-07-30 15:47 ` Nikolai Weibull
2013-07-28 16:22 ` [PATCH 16/16] _git: Document --early-output Øystein Walle
2013-07-30 14:35 ` Nikolai Weibull
2013-07-30 16:31 ` Øystein Walle
2013-07-30 20:42 ` Nikolai Weibull
2013-07-28 17:25 ` [PATCH 00/16] Improvements to the Git completion functions Peter Stephenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADdV=Mv9-yeggTVKNqUm_dz-aJEbx_nBtKW3MpOGUp5C=+onzg@mail.gmail.com' \
--to=now@disu.se \
--cc=oystwa@gmail.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).