From: Nikolai Weibull <now@bitwi.se>
To: Frank Terbeck <ft@bewatermyfriend.org>
Cc: zsh workers <zsh-workers@zsh.org>, Mikael Magnusson <mikachu@gmail.com>
Subject: Re: PATCH: (3/3) _git: re-add `user-commands' support again
Date: Fri, 22 Jul 2011 15:05:12 +0200 [thread overview]
Message-ID: <CADdV=Mv9NhtNuTkWF9u2qDGdqQuwGbWHpjgwN4xzfZv+941w5g@mail.gmail.com> (raw)
In-Reply-To: <8762mujx8y.fsf@ft.bewatermyfriend.org>
On Fri, Jul 22, 2011 at 14:49, Frank Terbeck <ft@bewatermyfriend.org> wrote:
> Nikolai Weibull wrote:
> [...]
>> Well, I’ve never guaranteed backwards compatibility in any of the
>> releases of _git. It’s always been a work in progress. The
>> user-commands style wasn’t something that I added, either. Things are
>> stabilizing now, but that also means that I would like to cut cruft
>> like this. Backwards compatibility isn’t in itself a strong enough
>> argument for keeping it around.
>>
>> So, what exactly is the use case for user-commands? Does it solve
>> something that something else won’t solve with greater satisfaction?
>
> It solves the case mentioned in the comment on top of the file.
>
> I don't say that there isn't a better way. Now there is, with the _git
> completion add-ons. But I don't think we should break compatibility
> unless we need to. And the code is simple enough and doesn't break
> performance or impair usability. So I'd say just throwing it away
> doesn't bring any advantages. But it would bring the disadvantage of
> breaking existing working setups for no good reason.
>
> So I'd be against removing it.
OK, it stays for now. I’m marking it as deprecated, however, and it
may be removed once we hit 5.0.
next prev parent reply other threads:[~2011-07-22 13:05 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-27 21:55 PATCH: Fall back to file completion if nothing else works Frank Terbeck
2011-06-28 2:03 ` Johan Sundström
2011-06-28 5:17 ` Frank Terbeck
2011-06-29 21:46 ` Johan Sundström
2011-06-29 22:33 ` Frank Terbeck
2011-06-29 20:37 ` PATCH: (0/3) _git fixes and enhancements Frank Terbeck
2011-06-29 20:37 ` PATCH: (1/3) _git: Fall back to file completion if nothing else works Frank Terbeck
2011-06-29 20:37 ` PATCH: (2/3) _git: Pick up addon completions from $fpath Frank Terbeck
2011-06-29 21:15 ` Frank Terbeck
2011-06-29 20:37 ` PATCH: (3/3) _git: re-add `user-commands' support again Frank Terbeck
2011-07-22 11:54 ` Nikolai Weibull
2011-07-22 11:55 ` Nikolai Weibull
2011-07-22 12:00 ` Frank Terbeck
2011-07-22 12:48 ` Nikolai Weibull
2011-07-22 12:49 ` Frank Terbeck
2011-07-22 13:05 ` Nikolai Weibull [this message]
2011-06-29 21:30 ` PATCH: (4/3) _git-buildpackage: use a #desc: line Frank Terbeck
2011-07-20 18:11 ` Nikolai Weibull
2011-07-20 18:22 ` Frank Terbeck
2011-07-22 11:58 ` Nikolai Weibull
2011-07-22 12:01 ` Frank Terbeck
2011-06-30 9:17 ` PATCH: (5/3) _git: Make file-completion fallback optional Frank Terbeck
2011-07-22 9:35 ` Nikolai Weibull
2011-10-27 8:00 ` Nikolai Weibull
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADdV=Mv9NhtNuTkWF9u2qDGdqQuwGbWHpjgwN4xzfZv+941w5g@mail.gmail.com' \
--to=now@bitwi.se \
--cc=ft@bewatermyfriend.org \
--cc=mikachu@gmail.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).