From: Nikolai Weibull <now@disu.se>
To: Frank Terbeck <ft@bewatermyfriend.org>
Cc: Ramkumar Ramachandra <artagnon@gmail.com>, zsh-workers@zsh.org
Subject: Re: [PATCH 2/3] Completion/Unix/Command/_git: fix shortlog completer
Date: Sat, 27 Apr 2013 11:01:45 +0200 [thread overview]
Message-ID: <CADdV=MvaDD8tyrrJCS=gWBdfNte=8mnD=kigOpK_C4xE0SSDVA@mail.gmail.com> (raw)
In-Reply-To: <CADdV=MsZCtr_D9O=ph+O142iLKDv2kvMkpRW8iVP8iP=CNHiXw@mail.gmail.com>
On Sat, Apr 27, 2013 at 10:56 AM, Nikolai Weibull <now@disu.se> wrote:
> Anyway, I mostly use Magit now, so I might not be the right maintainer anymore.
This being the case, here’s my TODO items that haven’t been DONE yet:
** Git completion
*** Add return 1 after any _message or _nothing?
*** Add support for url.*.insteadof=* for __git_any_repositories
*** git rm --cached should also complete files in the repository
*** git diff-index doesn’t work for the initial commit for
__git_changed-in-index_files
*** Check that all _alternative options are 'users:: _users', not
'users: :_users' or 'users::_users'
*** Change _arguments * && ret=0 to _arguments * && return 0
*** Change _call_function ret * && ret=0 to _call_function ret * && return ret
*** Use loops when $state may contain multiple items
*** Should we add && ret=0 to _guard and __git_guard_*?
*** Remove _git_command_successful
*** Check all uses of compadd
*** Check all uses of _call_program
*** Add = to all local
*** All commands (more or less) take --help|-h
*** Unify --help description
*** Add _git_arguments for describing argument specifications using
Git’s argument parser
This will allow us to unify the --help command, any uses of --verbose and
similar and so on.
*** Decide on terminology for show/display/report
*** A lot of short options should be specified with a + so that they
can take their argument in the same word
*** Tree-ish should bee treeish
*** __git_tags can, for, for example, git verify-tag, be a hexadecimal
object name
How do we fix that?
*** Use compadd -a array instead of compadd $array
*** Git config ->days should complete __git_datetimes
*** Use __all_labels in tag loop for mergetool
*** Instead of -prefix * use if compset *
There’s no need to check this twice.
*** OPT_BOOLEAN can be both --blah and --no-blah
Oh, my, that’s going to be a lot of work.
*** Replace __git_guard_branch-name with __git_branches
We don’t have _guard_files for _files
next prev parent reply other threads:[~2013-04-27 9:01 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-20 12:56 [PATCH 0/3] Completion/Unix/Command/_git: misc fixes Ramkumar Ramachandra
2013-04-20 12:56 ` [PATCH 1/3] Completion/Unix/Command/_git: add a couple of browsers Ramkumar Ramachandra
2013-04-20 12:56 ` [PATCH 2/3] Completion/Unix/Command/_git: fix shortlog completer Ramkumar Ramachandra
2013-04-20 13:03 ` Nikolai Weibull
2013-04-20 15:05 ` Frank Terbeck
2013-04-20 17:13 ` Ramkumar Ramachandra
2013-04-20 17:35 ` Bart Schaefer
2013-04-20 17:50 ` Ramkumar Ramachandra
2013-04-25 12:42 ` Frank Terbeck
2013-04-25 13:11 ` Nikolai Weibull
2013-04-25 18:12 ` Ramkumar Ramachandra
2013-04-25 17:48 ` Ramkumar Ramachandra
2013-04-25 19:06 ` Frank Terbeck
2013-04-27 8:56 ` Nikolai Weibull
2013-04-27 9:01 ` Nikolai Weibull [this message]
2013-04-28 14:30 ` Nikolai Weibull
2013-05-11 16:55 ` Nikolai Weibull
2013-05-12 17:48 ` Peter Stephenson
2013-04-27 10:22 ` Ramkumar Ramachandra
2013-04-27 11:27 ` Frank Terbeck
2013-04-20 12:56 ` [PATCH 3/3] Completion/Unix/Command/_git: branch.*.pushremote, remote.pushdefault Ramkumar Ramachandra
2013-04-21 10:16 ` [PATCH 0/3] Completion/Unix/Command/_git: misc fixes Frank Terbeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADdV=MvaDD8tyrrJCS=gWBdfNte=8mnD=kigOpK_C4xE0SSDVA@mail.gmail.com' \
--to=now@disu.se \
--cc=artagnon@gmail.com \
--cc=ft@bewatermyfriend.org \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).