From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18379 invoked by alias); 27 Apr 2013 09:01:55 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 31340 Received: (qmail 17003 invoked from network); 27 Apr 2013 09:01:52 -0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 Received-SPF: pass (ns1.primenet.com.au: SPF record at _netblocks.google.com designates 209.85.210.171 as permitted sender) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=rcNPTEE2bP0srrEtUwPIcmOtFGibRRLfQegWhBOsXAU=; b=UkxIePIsor6LbKYQCeUOsGNjDYoMrybJeld+PHPGcBmXSYWjZ0zSs+9vvByS1fArDo LdBWFFWlz8thVqRI96JSsI4HvF6lSwm++N/W0vFbmb2gRtbO9YD7GIkL4HrLO1/9SIJD nWppmATH2XxN4XIeBkEJDyZshN0LR/xanx0eq2pUmzWiFHWGrKHHVl9Iy24797LW6L3T 2Z/iv/Q9YzAjRtFe66cidpCa816ci5ZWgmAQfZxYzNhbYNt70thplMkZLo5t5pn/lDW4 ryuYkA69LE5HVGdHHjlVRw0c8CZvIbF1xmTNeGMfDDBheTKKpeloHzuqCucGohJq6lDs qz/w== MIME-Version: 1.0 X-Received: by 10.50.33.73 with SMTP id p9mr3528489igi.90.1367053305115; Sat, 27 Apr 2013 02:01:45 -0700 (PDT) Sender: nikolai.weibull@gmail.com In-Reply-To: References: <1366462573-15545-1-git-send-email-artagnon@gmail.com> <1366462573-15545-3-git-send-email-artagnon@gmail.com> <87mwsm3ho5.fsf@ft.bewatermyfriend.org> <87haiu2zwk.fsf@ft.bewatermyfriend.org> Date: Sat, 27 Apr 2013 11:01:45 +0200 X-Google-Sender-Auth: JgJ2ujAWiad2Y3nWqZltMNeSAL8 Message-ID: Subject: Re: [PATCH 2/3] Completion/Unix/Command/_git: fix shortlog completer From: Nikolai Weibull To: Frank Terbeck Cc: Ramkumar Ramachandra , zsh-workers@zsh.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Sat, Apr 27, 2013 at 10:56 AM, Nikolai Weibull wrote: > Anyway, I mostly use Magit now, so I might not be the right maintainer an= ymore. This being the case, here=E2=80=99s my TODO items that haven=E2=80=99t been= DONE yet: ** Git completion *** Add return 1 after any _message or _nothing? *** Add support for url.*.insteadof=3D* for __git_any_repositories *** git rm --cached should also complete files in the repository *** git diff-index doesn=E2=80=99t work for the initial commit for __git_changed-in-index_files *** Check that all _alternative options are 'users:: _users', not 'users: :_users' or 'users::_users' *** Change _arguments * && ret=3D0 to _arguments * && return 0 *** Change _call_function ret * && ret=3D0 to _call_function ret * && retur= n ret *** Use loops when $state may contain multiple items *** Should we add && ret=3D0 to _guard and __git_guard_*? *** Remove _git_command_successful *** Check all uses of compadd *** Check all uses of _call_program *** Add =3D to all local *** All commands (more or less) take --help|-h *** Unify --help description *** Add _git_arguments for describing argument specifications using Git=E2=80=99s argument parser This will allow us to unify the --help command, any uses of --verbose a= nd similar and so on. *** Decide on terminology for show/display/report *** A lot of short options should be specified with a + so that they can take their argument in the same word *** Tree-ish should bee treeish *** __git_tags can, for, for example, git verify-tag, be a hexadecimal object name How do we fix that? *** Use compadd -a array instead of compadd $array *** Git config ->days should complete __git_datetimes *** Use __all_labels in tag loop for mergetool *** Instead of -prefix * use if compset * There=E2=80=99s no need to check this twice. *** OPT_BOOLEAN can be both --blah and --no-blah Oh, my, that=E2=80=99s going to be a lot of work. *** Replace __git_guard_branch-name with __git_branches We don=E2=80=99t have _guard_files for _files